Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strip Hit Efficiency from DQM: first push #37530

Merged
merged 40 commits into from Apr 22, 2022
Merged

Strip Hit Efficiency from DQM: first push #37530

merged 40 commits into from Apr 22, 2022

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Apr 11, 2022 •
edited

PR description:

There is a standing plan to move the strip hit efficiency analysis to DQM (either at PCL, or in standard DQM), so that the creation of custom SiStrip calibration trees could be finally relinquished for Run-3.
This PR collects the commits available so far in order to move on with the integration.

PR validation:

cmssw compiles, the introduced unit tests in CalibTracker/SiStripHitEfficiency pass.

if this PR is a backport please specify the original PR and why you need to backport that PR:

N.A.

cc:
@robervalwalsh @mdelcourt @sroychow @cms-sw/trk-dpg-l2

@cmsbuild cmsbuild added this to the CMSSW_12_4_X milestone Apr 11, 2022
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37530/29241

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • CalibFormats/SiStripObjects (alca)
  • CalibTracker/SiStripHitEfficiency (alca)
  • DQM/SiStripCommon (dqm)

@malbouis, @yuanchao, @pmandrik, @emanueleusai, @ahmad3213, @tvami, @cmsbuild, @jfernan2, @francescobrivio, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@echabert, @hdelanno, @erikbutz, @sroychow, @pieterdavid, @robervalwalsh, @gbenelli, @tocheng, @fioriNTU, @jandrea, @idebruyn, @mmusich, @threus, @arossi83 this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

tvami
tvami reviewed Apr 11, 2022
View reviewed changes
Copy link
Contributor

@tvami tvami left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Marco, All,

This is a nice development plan. I welcome the idea of moving this to DQM/PCL.

I made a few comments, I wasnt sure if you wanted me to point out all occurrences, as of new I only pointed to a few cases

  • cout-s should be moved to MsgLogger
  • there are some cases where float could be considered instead of double
  • some of the magic numbers should be named constants
  • the tokens I think could be const-s
  • in a few cases the int could be made unsigned

CalibTracker/SiStripHitEfficiency/plugins/SiStripHitEfficiencyHarvester.cc Outdated Show resolved Hide resolved
CalibTracker/SiStripHitEfficiency/plugins/SiStripHitEfficiencyHarvester.cc
//legend: nBadComp[i][j][k]= SubSystem i, layer/disk/wheel j, BadModule/Fiber/Apv k
// i: 0=TIB, 1=TID, 2=TOB, 3=TEC
// k: 0=BadModule, 1=BadFiber, 2=BadApv, 3=BadStrips
std::stringstream ssV[4][19];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should the 4 and the 19 be names constants?

CalibTracker/SiStripHitEfficiency/plugins/SiStripHitEfficiencyWorker.cc Outdated Show resolved Hide resolved
CalibTracker/SiStripHitEfficiency/plugins/SiStripHitEfficiencyHarvester.cc Outdated Show resolved Hide resolved
CalibTracker/SiStripHitEfficiency/plugins/SiStripHitEfficiencyHarvester.cc Outdated Show resolved Hide resolved
@mmusich
Copy link
Contributor Author

mmusich commented Apr 11, 2022

please test

  • just to see if there's more to fix

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-65994f/23822/summary.html
COMMIT: 7523ef1
CMSSW: CMSSW_12_4_X_2022-04-11-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37530/23822/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3593039
  • DQMHistoTests: Total failures: 13
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3593003
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 200 log files, 45 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37530/29257

@cmsbuild
Copy link
Contributor

Pull request #37530 was updated. @malbouis, @yuanchao, @pmandrik, @emanueleusai, @ahmad3213, @tvami, @cmsbuild, @jfernan2, @francescobrivio, @micsucmed, @rvenditti can you please check and sign again.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-65994f/23979/summary.html
COMMIT: 5aa8dd6
CMSSW: CMSSW_12_4_X_2022-04-17-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37530/23979/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3589937
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3589913
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 200 log files, 45 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

+1

@tvami
Copy link
Contributor

tvami commented Apr 18, 2022

Hi Marco, given there are virtual contributions in #37530 (comment) , could you please squash the commits that cause them? Thanks!

@mmusich
Copy link
Contributor Author

mmusich commented Apr 18, 2022

could you please squash the commits that cause them?

I'd rather not, as they would hide the actual main contributor which has left the collaboration.

@tvami
Copy link
Contributor

tvami commented Apr 18, 2022

Hmmm there are 40 commits changing 18 files. Maybe the author's name could be included in the package header description? @cms-sw/orp-l2 what's your take?

@tvami
Copy link
Contributor

tvami commented Apr 18, 2022

+alca

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@mmusich
Copy link
Contributor Author

mmusich commented Apr 20, 2022

Hmmm there are 40 commits changing 18 files. Maybe the author's name could be included in the package header description? https://github.com/orgs/cms-sw/teams/orp-l2 what's your take?

@cms-sw/orp-l2 what's the integration plan for this PR? Shall I rebase? This is not urgent, so it can also go after 12_4_0_pre3 is built, but I'd just like to understand if more actions are needed on my side

@qliphy
Copy link
Contributor

qliphy commented Apr 20, 2022

Hmmm there are 40 commits changing 18 files. Maybe the author's name could be included in the package header description? https://github.com/orgs/cms-sw/teams/orp-l2 what's your take?

@cms-sw/orp-l2 what's the integration plan for this PR? Shall I rebase? This is not urgent, so it can also go after 12_4_0_pre3 is built, but I'd just like to understand if more actions are needed on my side

No strong opinion as for this specific PR. If mainly for historic reason to keep the contributor's name, probably we can keep as it is.

@mmusich
Copy link
Contributor Author

mmusich commented Apr 21, 2022

type trk

@cmsbuild cmsbuild added the trk label Apr 21, 2022
@mmusich
Copy link
Contributor Author

mmusich commented Apr 22, 2022

kindly pinging @cms-sw/orp-l2

@qliphy
Copy link
Contributor

qliphy commented Apr 22, 2022

+1

@cmsbuild cmsbuild merged commit 0d9fe99 into cms-sw:master Apr 22, 2022
@mmusich mmusich mentioned this pull request Apr 27, 2022
Merged
@mmusich mmusich mentioned this pull request May 5, 2022
Merged
@mmusich mmusich mentioned this pull request May 18, 2022
Merged
@dan131riley dan131riley mentioned this pull request May 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfernan2 jfernan2 jfernan2 left review comments

@tvami tvami tvami left review comments

Assignees
No one assigned
Labels
alca-approved code-checks-approved dqm-approved fully-signed orp-approved tests-approved trk
Projects
None yet
Milestone
CMSSW_12_4_X
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mmusich @cmsbuild @jfernan2 @tvami @qliphy @pieterdavid