Pilot blades enabling/disabling in pixel digitizer

[ahazi137]

Prevent the digitisation and reconstruction of simhits originated from pilot blades.

[cmsbuild]

A new Pull Request was created by @ahazi137 for CMSSW_7_1_X.

Pilot blades enabling/disabling in pixel digitizer

It involves the following packages:

SimTracker/SiPixelDigitizer

@cmsbuild, @civanch, @Degano, @mdhildreth, @nclopezo can you please review it and eventually sign? Thanks.
@cerati, @GiacomoSguazzoni, @rovere, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[nclopezo]

Hi @ahazi137,

This pull request is unmergeable, could you please rebase it?

You can see instructions here:

http://cms-sw.github.io/cmssw/tutorial-forward-port.html

[ahazi137]

Conflict is fixed.
Thanks for instructions.

[cmsbuild]

Pull request #3754 was updated. @cmsbuild, @civanch, @Degano, @mdhildreth, @nclopezo can you please check and sign again.

[cmsbuild]

-1
I found an error when building:

class edm::Wrapperedm::Association > >
class edm::Wrapperstd::vector > >
class edm::Wrapperstd::vector,reco::FFTAnyJetreco::JPTJet,edm::refhelper::FindUsingAdvancestd::vector,reco::FFTAnyJetreco::JPTJet > > > >
class edm>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-05-08-0200/src/SimTracker/TrackerHitAssociation/test/myTrackAnalyzer.cc 
/build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-05-08-0200/src/SimTracker/SiPixelDigitizer/plugins/SiPixelDigitizer.cc: In member function 'void cms::SiPixelDigitizer::accumulatePixelHits(edm::Handlestd::vector, CLHEP::HepRandomEngine_)':
/build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-05-08-0200/src/SimTracker/SiPixelDigitizer/plugins/SiPixelDigitizer.cc:145:91: error: conversion from 'std::map::iterator {aka std::_Rb_tree_iterator >}' to non-scalar type 'std::map::iterator {aka std::_Rb_tree_iterator >}' requested
       std::map::iterator itDet = detectorUnits.find(detId);  
                                                                                           ^
/build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-05-08-0200/src/SimTracker/SiPixelDigitizer/plugins/SiPixelDigitizer.cc:146:17: error: no match for 'operator==' (operand types are 'std::map::iterator {aka std::_Rb_tree_iterator >}' and 'std::map::iterator {aka std::_Rb_tree_iterator >}')
       if (itDet == detectorUnits.end()) continue;
                 ^


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3754/1402/summary.html

[cmsbuild]

Pull request #3754 was updated. @cmsbuild, @civanch, @Degano, @mdhildreth, @nclopezo can you please check and sign again.

[cmsbuild]

-1
I ran the usual tests and I found errors in the following unit tests:

---> test runtestPhysicsToolsPatAlgos had ERRORS
---> test testJetMETCorrectionsType1MET had ERRORS
---> test runtestTqafTopKinFitter had ERRORS
---> test runtestTqafTopEventProducers had ERRORS
---> test runtestTqafTopHitFit had ERRORS
---> test runtestTqafTopTools had ERRORS
---> test runtestTqafTopJetCombination had ERRORS
---> test runtestTqafTopEventSelection had ERRORS
---> test runtestTqafExamples had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3754/1411/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3754/1411/summary.html

[ktf]

Error unrelated. Will be rerun.

[cmsbuild]

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3754/1447/summary.html

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3754/1447/summary.html