Remove some dead assignments in L1Trigger/DTTriggerPhase2/src/HoughGrouping.cc #37540
Conversation
|
please test |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37540/29264
|
|
A new Pull Request was created by @perrotta (Andrea Perrotta) for master. It involves the following packages:
@epalencia, @AdrianoDee, @srimanob, @cecilecaillol, @rekovic can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e5016f/23848/summary.html Comparison SummarySummary:
|
|
+l1 |
| // Filling info | ||
| returnPC.nLayersWithHits_++; | ||
| returnPC.isThereNeighBourHitInLayer_[abslay] = true; | ||
|
|
||
| returnPC.xDistToPattern_[abslay] = abs(tmpx - (tmpLocalCh.x() - 1.05)); |
There was a problem hiding this comment.
Don't we need these three returnPC(s) at all? Were it there on purpose, i.e. define in case bool check is false?
There was a problem hiding this comment.
They were overwritten two lines below...
There was a problem hiding this comment.
Ah, OK. Thanks.
There is else of if (isDistRight) which did not show up on my screen.
|
+Upgrade Technical PR, no change is expected. |
cmsbuild
added
fully-signed
upgrade-approved
and removed
pending-signatures
upgrade-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
Title says all.
Spotted by the static analyzer
It should not interfere with any of the ongoing L1T related developments, but if so this PR can be simply postponed
PR validation:
It builds.