Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable EMTF regional showers with unpacked info #37544

Merged
merged 1 commit into from Apr 15, 2022

Conversation

zuoxunwu
Copy link
Contributor

PR description:

This PR updates the config in L1T DQM for EMTF showers.
The shower DQM are developed in PR36128 and PR36396, when the unpacker for EMTF shower was not available. The unpacker has been added in PR37194.
Now the EMTF shower DQM modules are enabled with unpacked info as inputs.

PR validation:

Tested with recent cosmic data Run 349840. The workflow runs without error. The plots for EMTF showers are empty, which is expected as there is no CSC shower input for the moment and the EMTF gives an empty shower collection.
Passed unit test and matrix tests.

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37544/29270

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @zuoxunwu (Xunwu Zuo) for master.

It involves the following packages:

  • DQM/L1TMonitor (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ab613b/23891/summary.html
COMMIT: 4fa58e4
CMSSW: CMSSW_12_4_X_2022-04-13-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37544/23891/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3593039
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3593009
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 216.96000000000012 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 10024.0,... ): 10.848 KiB L1T/L1TStage2EMTF
  • Checked 200 log files, 45 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Apr 15, 2022

+1

@makortel
Copy link
Contributor

This PR might have caused the TestDQMOnlineClient-l1tstage2_dqm_sourceclient test to fail

----- Begin Fatal Exception 15-Apr-2022 15:47:14 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 344518 lumi: 2 event: 31571 stream: 0
   [1] Running path 'l1tMonitorPath'
   [2] Calling method for module L1TStage2RegionalShower/'l1tStage2RegionalShower'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: MuonDigiCollection<CSCDetId,CSCShowerDigi>
Looking for module label: muonCSCDigis
Looking for productInstanceName: MuonCSCShowerDigi

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

see #37584

@qliphy
Copy link
Contributor

qliphy commented Apr 15, 2022

@zuoxunwu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants