Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove workaround for fixed ROOT6 bug #3759

Merged
merged 1 commit into from May 8, 2014

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented May 8, 2014

There was a bug in ROOT6 that caused fatal errors if certain classes did not have a default ctor,
We added default ctor's in the ROOT6 branch to two classes to avoid the problem.
The ROOT6 bug has now been fixed, and the fix is in the CMSSW ROOT6 IB.
This pull request removes the workaround, which is no longer needed.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2014

A new Pull Request was created by @wmtan for CMSSW_7_1_ROOT6_X.

Remove workaround for fixed ROOT6 bug

It involves the following packages:

CondFormats/HcalObjects

@apfeiffer1, @diguida, @cmsbuild, @nclopezo, @rcastello, @ggovi, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

ktf added a commit that referenced this pull request May 8, 2014
ROOT6 -- Remove workaround for fixed ROOT6 bug
@ktf ktf merged commit 13c936b into cms-sw:CMSSW_7_1_ROOT6_X May 8, 2014
@wmtan wmtan deleted the RemoveWorkaround branch May 9, 2014 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants