Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark legacy EDModule constructors deprecated #37592

Merged
merged 2 commits into from Apr 29, 2022

Commits on Apr 16, 2022

  1. Mark the legacy EDModule constructors deprecated

    Attributing the (base) class deprecated does not lead to as wide
    coverage of the deprecation warnings as we hoped, but attributing
    functions seems to work. Let's try marking the constructors as
    deprecated (on a small test it seems to work).
    makortel committed Apr 16, 2022
    Configuration menu
    Copy the full SHA
    90a7a5d View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2022

  1. Remove the class-level deprecation annotation from legacy EDModules

    While in principle annotating the entire class would be the proper
    thing to do, with gcc the constructor annotation appears to work
    better for identifying the deriving classes that need to be migrated
    to thread-friendly base classes.
    makortel committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    f401fce View commit details
    Browse the repository at this point in the history