Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLT menu development for 12_3_X #37595

Merged
merged 1 commit into from Apr 17, 2022

Conversation

missirol
Copy link
Contributor

backport of #37594

PR description:

Development of HLT menus for CMSSW_12_3_X.

Includes the integration of the following JIRA tickets.

  • CMSHLT-2268: [MUO] Update of muon inside-out reco with pT-dependent Regions-Of-Interest.
  • CMSHLT-2269: [MUO] Update of muon outside-in track seeding with DNN.
  • CMSHLT-2277: [MUO] Renaming of old single-muon triggers.
  • CMSHLT-2279: [EXO] Update of LLP triggers (incl. change of L1T seeds).
  • CMSHLT-2283: [EXO] Fix to jet-timing producer in delayed-jet triggers.

PR validation:

TSG tests.

If this PR is a backport, please specify the original PR and why you need to backport that PR:

#37594

Development of HLT menus for Run-3 startup.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 16, 2022

A new Pull Request was created by @missirol (Marino Missiroli) for CMSSW_12_3_X.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24a6ee/23967/summary.html
COMMIT: 030f9d6
CMSSW: CMSSW_12_3_X_2022-04-15-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37595/23967/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3697105
  • DQMHistoTests: Total failures: 2333
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3694750
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -76.35600000000001 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): -12.760 KiB HLT/Muon
  • DQMHistoSizes: changed ( 11634.0,... ): 0.034 KiB HLT/Filters
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: found differences in 2 / 48 workflows

@missirol
Copy link
Contributor Author

+hlt

  • differences in outputs of Run-3 wfs in line with changes to the HLT GRun menu.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit b80b0a6 into cms-sw:CMSSW_12_3_X Apr 17, 2022
@missirol missirol deleted the HLTdevelopment123X branch April 25, 2022 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants