[12_3_X] [L1-O2O] ESGetToken migration L1CondDBPayloadWriter and O2O unit tests #37601

panoskatsoulis · 2022-04-17T15:32:37Z

backport #37602

PR description:

This PR implements WriterProxy from CondTools/L1TriggerExt to inherit from edm::EDConsumerBase as it's required for running esConsumes() to register ESGetToken objects when is called by CondDBPayloadWriter

PR validation:

This pkg is part of the L1 O2O and there is not any central wf to be tested
Tested Locally and from custom patch on machine conddb-1 writing to sqlite file and Prep respectively
The local replica of the p5 script is commited together in this PR ( runL1-O2O-iov.sh )

if this PR is a backport please specify the original PR and why you need to backport that PR:

backport of #37602

cmsbuild · 2022-04-17T15:33:05Z

A new Pull Request was created by @panoskatsoulis (Panos) for CMSSW_12_3_X.

It involves the following packages:

CondTools/L1Trigger (db, l1)
L1TriggerConfig/L1TConfigProducers (l1)

@malbouis, @epalencia, @cmsbuild, @rekovic, @ggovi, @tvami, @cecilecaillol, @francescobrivio can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

Backported from [L1-O2O] ESGetToken migration L1CondDBPayloadWriter and O2O unit tests #37602

cmsbuild · 2022-04-17T15:59:14Z

Pull request #37601 was updated. @malbouis, @epalencia, @cmsbuild, @rekovic, @ggovi, @tvami, @cecilecaillol, @francescobrivio can you please check and sign again.

panoskatsoulis · 2022-04-17T16:08:51Z

hold

tvami · 2022-04-17T16:42:30Z

Hi @panoskatsoulis thanks for this PR!

can you please include the the title that this is for [12_3_X]
What's the reason for the hold?
Please add the L1TriggerConfig/L1TConfigProducers/test/runL1-O2O-iov.sh to the BuildFile so it's run like a unit test! Thanks!

panoskatsoulis · 2022-04-17T16:54:20Z

have a look here [L1-O2O] ESGetToken migration L1CondDBPayloadWriter and O2O unit tests #37602 (comment)
it needs some local sqlite that will be able to use locally, in short I don't know how to set up a new unit test
so it's better to come back for this in the next days

cmsbuild · 2022-04-19T19:51:36Z

Pull request #37601 was updated. @malbouis, @epalencia, @cmsbuild, @rekovic, @ggovi, @tvami, @cecilecaillol, @francescobrivio can you please check and sign again.

cmsbuild · 2022-04-20T16:12:04Z

Pull request #37601 was updated. @malbouis, @epalencia, @cmsbuild, @rekovic, @ggovi, @tvami, @cecilecaillol, @francescobrivio can you please check and sign again.

cmsbuild · 2022-04-21T08:20:06Z

Pull request #37601 was updated. @malbouis, @epalencia, @cmsbuild, @rekovic, @ggovi, @tvami, @cecilecaillol, @francescobrivio can you please check and sign again.

cmsbuild · 2022-04-21T13:00:45Z

Pull request #37601 was updated. @malbouis, @epalencia, @cmsbuild, @rekovic, @ggovi, @tvami, @cecilecaillol, @francescobrivio can you please check and sign again.

cmsbuild · 2022-04-22T18:45:06Z

Pull request #37601 was updated. @malbouis, @epalencia, @cmsbuild, @rekovic, @ggovi, @tvami, @cecilecaillol, @francescobrivio can you please check and sign again.

tvami · 2022-04-22T19:31:58Z

@cmsbuild , please test

cmsbuild · 2022-04-23T00:00:19Z

-1

Failed Tests: UnitTests RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-70faf5/24141/summary.html
COMMIT: e98a14f
CMSSW: CMSSW_12_3_X_2022-04-22-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37601/24141/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test L1O2O_L1TSubs had ERRORS
---> test L1O2O_L1TMenu had ERRORS

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3697135
DQMHistoTests: Total failures: 8
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3697105
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 204 log files, 45 edm output root files, 49 DQM output files
TriggerResults: no differences found

mmusich · 2022-04-23T06:58:23Z

so, the O2O tests failed:

----- Begin Fatal Exception 22-Apr-2022 21:51:59 CEST-----------------------
An exception of category 'StdException' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing service of type PoolDBOutputService
Exception Message:
A std::exception was thrown.
Connection on "sqlite_file:/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_X_2022-04-22-1100/src/L1TriggerConfig/L1TConfigProducers/data/l1config.db" cannot be established ( CORAL : "ConnectionPool::getSessionFromNewConnection" from "CORAL/Services/ConnectionService" )
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 22-Apr-2022 21:51:59 CEST-----------------------
An exception of category 'StdException' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing service of type PoolDBOutputService
Exception Message:
A std::exception was thrown.
Connection on "sqlite_file:/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_X_2022-04-22-1100/src/L1TriggerConfig/L1TConfigProducers/data/l1config.db" cannot be established ( CORAL : "ConnectionPool::getSessionFromNewConnection" from "CORAL/Services/ConnectionService" )
----- End Fatal Exception -------------------------------------------------

I guess because the local sqlite file was not included in this PR (as instead it has been done in the master PR)

cmsbuild · 2022-04-23T17:22:02Z

Pull request #37601 was updated. @malbouis, @epalencia, @cmsbuild, @rekovic, @ggovi, @tvami, @cecilecaillol, @francescobrivio can you please check and sign again.

cmsbuild · 2022-04-26T16:35:47Z

Pull request #37601 was updated. @malbouis, @epalencia, @cmsbuild, @rekovic, @ggovi, @tvami, @cecilecaillol, @francescobrivio can you please check and sign again.

panoskatsoulis · 2022-04-26T16:36:18Z

this backport PR has also been squashed to 5 commits

tvami · 2022-04-26T16:46:58Z

@panoskatsoulis please update the PR title for this too, thanks!

tvami · 2022-04-26T16:47:03Z

@cmsbuild , please test

cmsbuild · 2022-04-26T21:02:50Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-70faf5/24240/summary.html
COMMIT: 2313443
CMSSW: CMSSW_12_3_X_2022-04-26-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37601/24240/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 12 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3697135
DQMHistoTests: Total failures: 19
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 3697093
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 48 files compared)
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 204 log files, 45 edm output root files, 49 DQM output files
TriggerResults: no differences found

tvami · 2022-04-26T21:21:32Z

+db

epalencia · 2022-04-27T05:10:51Z

+l1

cmsbuild · 2022-04-27T05:11:12Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

panoskatsoulis · 2022-04-27T11:10:06Z

@perrotta @qliphy
this is the P5 backport of #37602
it's also required to be merged

perrotta · 2022-04-27T18:45:51Z

+1

Verbatim backport of [L1-O2O] ESGetToken migration L1CondDBPayloadWriter and O2O unit tests #37602, successfully merged in IB since CMSSW_12_4_X_2022-04-27-1100
cms-data externals already available in 12_3 via [12.3.X] added L1TriggerConfig-L1TConfigProducers V00-01-00 cmsdist#7825

cmsbuild added this to the CMSSW_12_3_X milestone Apr 17, 2022

cmsbuild added backport db-pending l1-pending orp-pending pending-signatures tests-pending labels Apr 17, 2022

panoskatsoulis mentioned this pull request Apr 17, 2022

es get() migration of L1CondDBPayloadWriter and L1CondDBPayloadWriterExt #36383

Merged

panoskatsoulis changed the title ~~[L1-O2O] WriterProxyT changes to use ESGetToken~~ [12_3_X] [L1-O2O] WriterProxyT changes to use ESGetToken Apr 17, 2022

qliphy mentioned this pull request Apr 18, 2022

Fix typo in L1T prescales files #37582

Merged

cmsbuild added tests-started and removed tests-pending labels Apr 22, 2022

cmsbuild added tests-rejected and removed tests-started labels Apr 23, 2022

cmsbuild added tests-pending and removed tests-rejected labels Apr 23, 2022

unit tests final adjustments

2313443

panoskatsoulis force-pushed the l1o2o_WriterProxyT_migrationTo_ESGetToken branch from c3eacc3 to 2313443 Compare April 26, 2022 16:35

cmsbuild added tests-pending and removed tests-started labels Apr 26, 2022

cmsbuild added tests-started and removed tests-pending labels Apr 26, 2022

panoskatsoulis changed the title ~~[12_3_X] [L1-O2O] WriterProxyT changes to use ESGetToken~~ [12_3_X] [L1-O2O] ESGetToken migration L1CondDBPayloadWriter and O2O unit tests Apr 26, 2022

cmsbuild added tests-approved and removed tests-started labels Apr 26, 2022

cmsbuild added db-approved and removed db-pending labels Apr 26, 2022

cmsbuild added fully-signed l1-approved and removed l1-pending pending-signatures labels Apr 27, 2022

cmsbuild added backport-ok and removed backport labels Apr 27, 2022

cmsbuild added orp-approved and removed orp-pending labels Apr 27, 2022

cmsbuild merged commit 86a7528 into cms-sw:CMSSW_12_3_X Apr 27, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[12_3_X] [L1-O2O] ESGetToken migration L1CondDBPayloadWriter and O2O unit tests #37601

[12_3_X] [L1-O2O] ESGetToken migration L1CondDBPayloadWriter and O2O unit tests #37601

panoskatsoulis commented Apr 17, 2022 •

edited

cmsbuild commented Apr 17, 2022 •

edited

cmsbuild commented Apr 17, 2022

panoskatsoulis commented Apr 17, 2022

tvami commented Apr 17, 2022

panoskatsoulis commented Apr 17, 2022 •

edited

cmsbuild commented Apr 19, 2022

cmsbuild commented Apr 20, 2022

cmsbuild commented Apr 21, 2022

cmsbuild commented Apr 21, 2022

cmsbuild commented Apr 22, 2022

tvami commented Apr 22, 2022

cmsbuild commented Apr 23, 2022

mmusich commented Apr 23, 2022

cmsbuild commented Apr 23, 2022

cmsbuild commented Apr 26, 2022

panoskatsoulis commented Apr 26, 2022

tvami commented Apr 26, 2022

tvami commented Apr 26, 2022

cmsbuild commented Apr 26, 2022

tvami commented Apr 26, 2022

epalencia commented Apr 27, 2022

cmsbuild commented Apr 27, 2022

panoskatsoulis commented Apr 27, 2022

perrotta commented Apr 27, 2022

[12_3_X] [L1-O2O] ESGetToken migration L1CondDBPayloadWriter and O2O unit tests #37601

[12_3_X] [L1-O2O] ESGetToken migration L1CondDBPayloadWriter and O2O unit tests #37601

Conversation

panoskatsoulis commented Apr 17, 2022 • edited

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Apr 17, 2022 • edited

cmsbuild commented Apr 17, 2022

panoskatsoulis commented Apr 17, 2022

tvami commented Apr 17, 2022

panoskatsoulis commented Apr 17, 2022 • edited

cmsbuild commented Apr 19, 2022

cmsbuild commented Apr 20, 2022

cmsbuild commented Apr 21, 2022

cmsbuild commented Apr 21, 2022

cmsbuild commented Apr 22, 2022

tvami commented Apr 22, 2022

cmsbuild commented Apr 23, 2022

Unit Tests

RelVals-INPUT

Comparison Summary

mmusich commented Apr 23, 2022

cmsbuild commented Apr 23, 2022

cmsbuild commented Apr 26, 2022

panoskatsoulis commented Apr 26, 2022

tvami commented Apr 26, 2022

tvami commented Apr 26, 2022

cmsbuild commented Apr 26, 2022

Comparison Summary

tvami commented Apr 26, 2022

epalencia commented Apr 27, 2022

cmsbuild commented Apr 27, 2022

panoskatsoulis commented Apr 27, 2022

perrotta commented Apr 27, 2022

panoskatsoulis commented Apr 17, 2022 •

edited

cmsbuild commented Apr 17, 2022 •

edited

panoskatsoulis commented Apr 17, 2022 •

edited