Add wfs with HLT as separate step (refactor) #37633

kskovpen · 2022-04-20T14:11:13Z

PR description:

Introduce an additional Run 3 wf where the HLT step is separated out from DIGI, following the studies mentioned in #37564

PR validation:

Tested on the newly created 11634.601.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport.

update master

cmsbuild · 2022-04-20T14:18:17Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37633/29417

This PR adds an extra 64KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): DeepSC algorithm for ECAL SuperClusters #37115, Dynamic Reduction Network for photon energy regression in miniAOD using the SonicTriton service #37134, GPUvsCPU: updates to modules and workflows for pixel reconstruction #37617, Add run3 tracking low pu era #33532

cmsbuild · 2022-04-20T14:18:36Z

A new Pull Request was created by @kskovpen for master.

It involves the following packages:

Configuration/PyReleaseValidation (pdmv, upgrade)

@jordan-martins, @bbilin, @wajidalikhan, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen can you please review it and eventually sign? Thanks.
@makortel, @kpedro88, @Martin-Grunewald, @missirol, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

kskovpen · 2022-04-20T14:18:58Z

test parameters:

workflow = 11634.601

kskovpen · 2022-04-20T14:19:11Z

please test

srimanob · 2022-04-20T15:18:19Z

Configuration/PyReleaseValidation/python/relval_steps.py

+
+    upgradeStepDict['HLTRun3'][k] = {'-s':'HLT:%s'%(hltversion),
+                                 '--conditions':gt,
+                                 '--datatier':'GEN-SIM-DIGI-RAW',


This datatier may cause the issue if workflow runs with stepchain, I think. It used to be an issue that stepchain can't handle same datatiers.

What about referencing it as SIM-RAW?

cmsbuild · 2022-04-20T17:54:14Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0ecb09/24066/summary.html
COMMIT: bf7c19a
CMSSW: CMSSW_12_4_X_2022-04-20-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37633/24066/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/pool/condor/dir_16160/jenkins/workspace/compare-root-files-short-matrix/data/PR-0ecb09/39434.75_TTbar_14TeV+2026D88_HLT75e33+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HLT75e33+HARVESTGlobal

Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3695434
DQMHistoTests: Total failures: 7
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 3695404
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.004 KiB( 48 files compared)
DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
Checked 205 log files, 45 edm output root files, 49 DQM output files
TriggerResults: no differences found

srimanob · 2022-04-21T02:42:22Z

test parameters:

workflows = 11634.601
relvals_opt = --what upgrade,standard,highstats,pileup,generator,extendedgen,production,ged,machine,premix

srimanob · 2022-04-21T02:43:01Z

@cmsbuild please test

srimanob · 2022-04-21T02:43:41Z

If the workflow is expected to run every IB, the workflow should be added to relval2017.

kskovpen · 2022-04-22T06:57:29Z

Thanks a lot @srimanob and @makortel for your comments.
I would propose to keep this wf at 11634.601. It has not been tested in the production system yet, so let's have it for tests for now and in the meantime we can run some tests in production in order to see if any problem appears (such as the possible data tier adjustment, as mentioned by @srimanob). Once it is fully tested, we can put it in ProdLike. The description has been added in README, as suggested.

cmsbuild · 2022-04-22T06:58:57Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37633/29453

This PR adds an extra 12KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/README.md modified in PR(s): DeepSC algorithm for ECAL SuperClusters #37115, Dynamic Reduction Network for photon energy regression in miniAOD using the SonicTriton service #37134, Add run3 tracking low pu era #33532
- File Configuration/PyReleaseValidation/python/relval_2017.py modified in PR(s): DeepSC algorithm for ECAL SuperClusters #37115, Dynamic Reduction Network for photon energy regression in miniAOD using the SonicTriton service #37134, GPUvsCPU: updates to modules and workflows for pixel reconstruction #37617, Add Run-3 FastSim wf to runTheMatrix #37493
- File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): DeepSC algorithm for ECAL SuperClusters #37115, Pixel Heterogeneous DQM: add modules for Tracks and Vertices @cpu / @gpu comparisons #37619, Dynamic Reduction Network for photon energy regression in miniAOD using the SonicTriton service #37134, GPUvsCPU: updates to modules and workflows for pixel reconstruction #37617, Add run3 tracking low pu era #33532

cmsbuild · 2022-04-22T06:59:22Z

Pull request #37633 was updated. @jordan-martins, @bbilin, @wajidalikhan, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen can you please check and sign again.

kskovpen · 2022-04-22T07:02:18Z

please test

cmsbuild · 2022-04-22T11:05:05Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0ecb09/24121/summary.html
COMMIT: d579a07
CMSSW: CMSSW_12_4_X_2022-04-21-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37633/24121/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-0ecb09/11634.601_TTbar_14TeV+2021_DigiNoHLT+TTbar_14TeV_TuneCP5_GenSim+Digi+HLTRun3+RecoNano+HARVESTNano
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-0ecb09/39434.75_TTbar_14TeV+2026D88_HLT75e33+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HLT75e33+HARVESTGlobal

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3695434
DQMHistoTests: Total failures: 8
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3695404
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 205 log files, 45 edm output root files, 49 DQM output files
TriggerResults: no differences found

srimanob · 2022-04-22T15:47:55Z

+Upgrade

The workflow 1634.601 run as expected.

kskovpen · 2022-04-22T15:50:42Z

+pdmv

cmsbuild · 2022-04-22T15:51:01Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2022-04-22T18:05:57Z

+1

kskovpen added 7 commits December 3, 2021 16:17

Merge pull request #16 from cms-sw/master

43ac400

update master

Merge pull request #17 from cms-sw/master

0c7b484

update master

Merge branch 'cms-sw:master' into master

2fa8e6b

Merge branch 'cms-sw:master' into master

5726847

Merge branch 'cms-sw:master' into master

6aaf42b

add test wf for separate hlt

3356cd4

add test wf for separate hlt

bf7c19a

cmsbuild added this to the CMSSW_12_4_X milestone Apr 20, 2022

cmsbuild added code-checks-pending orp-pending pdmv-pending pending-signatures tests-pending upgrade-pending labels Apr 20, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 20, 2022

cmsbuild added tests-started and removed tests-pending labels Apr 20, 2022

srimanob reviewed Apr 20, 2022

View reviewed changes

cmsbuild added tests-approved and removed tests-started labels Apr 20, 2022

cmsbuild mentioned this pull request Apr 20, 2022

Pixel Heterogeneous DQM: add modules for Tracks and Vertices @cpu / @gpu comparisons #37619

Merged

cmsbuild added code-checks-pending tests-pending and removed tests-approved code-checks-approved labels Apr 22, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 22, 2022

cmsbuild added tests-started and removed tests-pending labels Apr 22, 2022

cmsbuild added tests-approved and removed tests-started labels Apr 22, 2022

cmsbuild added upgrade-approved and removed upgrade-pending labels Apr 22, 2022

cmsbuild added fully-signed pdmv-approved and removed pending-signatures pdmv-pending labels Apr 22, 2022

cmsbuild added orp-approved and removed orp-pending labels Apr 22, 2022

cmsbuild merged commit 93fc391 into cms-sw:master Apr 22, 2022

makortel mentioned this pull request Apr 22, 2022

Workflow mimicing UL MC production where HLT was run in a separate step #37564

Closed

makortel mentioned this pull request Jul 15, 2022

Define a runTheMatrix workflow with a separate HLT step cms-sw/framework-team#384

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add wfs with HLT as separate step (refactor) #37633

Add wfs with HLT as separate step (refactor) #37633

kskovpen commented Apr 20, 2022

cmsbuild commented Apr 20, 2022

cmsbuild commented Apr 20, 2022

kskovpen commented Apr 20, 2022

kskovpen commented Apr 20, 2022

srimanob Apr 20, 2022

kskovpen Apr 21, 2022

cmsbuild commented Apr 20, 2022

srimanob commented Apr 21, 2022

srimanob commented Apr 21, 2022

srimanob commented Apr 21, 2022

kskovpen commented Apr 22, 2022

cmsbuild commented Apr 22, 2022

cmsbuild commented Apr 22, 2022

kskovpen commented Apr 22, 2022

cmsbuild commented Apr 22, 2022

srimanob commented Apr 22, 2022

kskovpen commented Apr 22, 2022

cmsbuild commented Apr 22, 2022

perrotta commented Apr 22, 2022

Add wfs with HLT as separate step (refactor) #37633

Add wfs with HLT as separate step (refactor) #37633

Conversation

kskovpen commented Apr 20, 2022

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Apr 20, 2022

cmsbuild commented Apr 20, 2022

kskovpen commented Apr 20, 2022

kskovpen commented Apr 20, 2022

srimanob Apr 20, 2022

Choose a reason for hiding this comment

kskovpen Apr 21, 2022

Choose a reason for hiding this comment

cmsbuild commented Apr 20, 2022

Comparison Summary

srimanob commented Apr 21, 2022

srimanob commented Apr 21, 2022

srimanob commented Apr 21, 2022

kskovpen commented Apr 22, 2022

cmsbuild commented Apr 22, 2022

cmsbuild commented Apr 22, 2022

kskovpen commented Apr 22, 2022

cmsbuild commented Apr 22, 2022

Comparison Summary

srimanob commented Apr 22, 2022

kskovpen commented Apr 22, 2022

cmsbuild commented Apr 22, 2022

perrotta commented Apr 22, 2022