Update of L3MuonCandidateProducerFromMuons to work also with displaced #37636

alexsr-98 · 2022-04-20T16:52:52Z

PR description:

This PR implements a small change in the L3MuonCandidateProducerFromMuons module. A summary of this PR can be found on this slides.

When this module was used with displaced muons a degradation in efficiency and resolution was observed. The reason was that this module was taking the innerTrack of the muon by default for momentum estimation. For displaced muons its better to take the globalTrack as shown in the attached slides (better efficiency and resolution).

We propose to add a flag to turn on the displaced reconstruction. This flag is set false by default to not interfere with the prompt reconstruction.

PR validation:

This PR passed the scram b runtests and code quality checks.

cmsbuild · 2022-04-20T17:02:03Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37636/29426

This PR adds an extra 16KB to repository

cmsbuild · 2022-04-20T17:23:24Z

A new Pull Request was created by @alexsr-98 for master.

It involves the following packages:

RecoMuon/L3MuonProducer (hlt, reconstruction)

@Martin-Grunewald, @clacaputo, @cmsbuild, @missirol, @slava77, @jpata can you please review it and eventually sign? Thanks.
@HuguesBrun, @silviodonato, @abbiendi, @Fedespring, @bellan, @sscruz, @jhgoh, @CeliaFernandez, @trocino, @cericeci, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

missirol · 2022-04-20T17:32:59Z

RecoMuon/L3MuonProducer/src/L3MuonCandidateProducerFromMuons.cc

+        if ((*muons)[i].isGlobalMuon() == 1) {
+          tkref = (*muons)[i].globalTrack();
+        } else {
+          tkref = (*muons)[i].muonBestTrack();
+        }


Suggested change

if ((*muons)[i].isGlobalMuon() == 1) {

tkref = (*muons)[i].globalTrack();

} else {

tkref = (*muons)[i].muonBestTrack();

}

tkref = (*muons)[i].isGlobalMuon() ? (*muons)[i].globalTrack() : (*muons)[i].muonBestTrack();

missirol · 2022-04-20T17:37:41Z

RecoMuon/L3MuonProducer/src/L3MuonCandidateProducerFromMuons.h

  /// produce candidates
  void produce(edm::StreamID, edm::Event&, const edm::EventSetup&) const override;

 private:
  // L3/GLB Collection Label
  edm::InputTag m_L3CollectionLabel;
  edm::EDGetTokenT<reco::MuonCollection> muonToken_;
+  bool m_displacedReco;


Suggested change

bool m_displacedReco;

bool const m_displacedReco;

The other two could also be made const using the following in the ctor:
(i changed muonToken_ to m_muonToken to follow the naming convention of the other data members)

: m_L3CollectionLabel(parameterSet.getParameter<InputTag>("InputObjects")), // standAlone Collection Label m_muonToken(consumes(m_L3CollectionLabel)), m_displacedReco(parameterSet.getParameter<bool>("DisplacedReconstruction")) { LogTrace(category) << " constructor called"; produces<RecoChargedCandidateCollection>();

I have changed the name to the one you suggest and made const the other two attributes.

cmsbuild · 2022-04-20T22:06:57Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37636/29431

This PR adds an extra 16KB to repository

cmsbuild · 2022-04-20T22:07:17Z

Pull request #37636 was updated. @Martin-Grunewald, @clacaputo, @cmsbuild, @missirol, @slava77, @jpata can you please check and sign again.

missirol · 2022-04-20T22:09:11Z

please test

cmsbuild · 2022-04-21T02:03:41Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2307cb/24078/summary.html
COMMIT: d109396
CMSSW: CMSSW_12_4_X_2022-04-20-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37636/24078/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-2307cb/39434.75_TTbar_14TeV+2026D88_HLT75e33+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HLT75e33+HARVESTGlobal

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3695434
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3695410
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 205 log files, 45 edm output root files, 49 DQM output files
TriggerResults: no differences found

missirol

Late comments from my side. Feel free to squash into 1 commit in the next update.

missirol · 2022-04-21T06:02:01Z

RecoMuon/L3MuonProducer/src/L3MuonCandidateProducerFromMuons.cc

+      if (m_displacedReco) {
+        tkref = (*muons)[i].isGlobalMuon() ? (*muons)[i].globalTrack() : (*muons)[i].muonBestTrack();
+      } else {
+        tkref = ((*muons)[i].innerTrack().isNonnull()) ? (*muons)[i].innerTrack() : (*muons)[i].muonBestTrack();


Suggested change

tkref = ((*muons)[i].innerTrack().isNonnull()) ? (*muons)[i].innerTrack() : (*muons)[i].muonBestTrack();

tkref = (*muons)[i].innerTrack().isNonnull() ? (*muons)[i].innerTrack() : (*muons)[i].muonBestTrack();

missirol · 2022-04-21T06:03:08Z

RecoMuon/L3MuonProducer/python/l3MuonCandidateProducerFromMuons_cfi.py

@@ -1,5 +1,6 @@
 import FWCore.ParameterSet.Config as cms



This cfi file can now be removed. I don't see it used anywhere, and it will now be created automatically via fillDescriptions.

…muons Applied comments from PR review Removed cfi and small change

cmsbuild · 2022-04-21T07:45:13Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37636/29435

This PR adds an extra 16KB to repository

cmsbuild · 2022-04-21T07:45:40Z

Pull request #37636 was updated. @Martin-Grunewald, @clacaputo, @cmsbuild, @missirol, @slava77, @jpata can you please check and sign again.

missirol · 2022-04-21T08:02:24Z

please test

cmsbuild · 2022-04-21T12:31:08Z

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2307cb/24088/summary.html
COMMIT: 14733ac
CMSSW: CMSSW_12_4_X_2022-04-20-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37636/24088/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-2307cb/39434.75_TTbar_14TeV+2026D88_HLT75e33+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HLT75e33+HARVESTGlobal

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3695434
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3695410
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 205 log files, 45 edm output root files, 49 DQM output files
TriggerResults: no differences found

missirol · 2022-04-21T18:51:23Z

The RelVals-INPUT error in the PR tests is unrelated to this PR, I believe.

missirol · 2022-04-21T18:52:30Z

+hlt

adds a new option, disabled by default, to a producer used at HLT
no differences seen in PR tests, as expected

clacaputo · 2022-04-25T09:12:13Z

+reconstruction

new flag in L3MuonCandidateProducerFromMuons for displaced muons
flag is set to false by default
no reco changes observed

cmsbuild · 2022-04-25T09:12:34Z

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2022-04-25T09:51:20Z

+1

RelVals-INPUT error is unrelated

perrotta · 2022-04-25T09:52:06Z

merge

cmsbuild added this to the CMSSW_12_4_X milestone Apr 20, 2022

cmsbuild added code-checks-pending hlt-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Apr 20, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 20, 2022

missirol reviewed Apr 20, 2022

View reviewed changes

cmsbuild added code-checks-pending and removed code-checks-approved labels Apr 20, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 20, 2022

cmsbuild added tests-started and removed tests-pending labels Apr 20, 2022

cmsbuild added tests-approved and removed tests-started labels Apr 21, 2022

missirol reviewed Apr 21, 2022

View reviewed changes

Updated L3MuonCandidateProducerFromMuons to work also with displaced …

14733ac

…muons Applied comments from PR review Removed cfi and small change

alexsr-98 force-pushed the recoChargedCandidatesForDisplacedMuon branch from d109396 to 14733ac Compare April 21, 2022 07:37

cmsbuild added code-checks-pending and removed tests-approved code-checks-approved labels Apr 21, 2022

cmsbuild added the tests-pending label Apr 21, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 21, 2022

cmsbuild added tests-started and removed tests-pending labels Apr 21, 2022

cmsbuild added tests-rejected and removed tests-started labels Apr 21, 2022

cmsbuild added hlt-approved and removed hlt-pending labels Apr 21, 2022

cmsbuild added fully-signed reconstruction-approved and removed reconstruction-pending pending-signatures labels Apr 25, 2022

cmsbuild added orp-approved and removed orp-pending labels Apr 25, 2022

cmsbuild merged commit 7f48b04 into cms-sw:master Apr 25, 2022

This was referenced Apr 25, 2022

[CXXMODULE] Update to latest root master changes cms-sw/cmsdist#7819

Merged

Can now disable CondorStatusUpdator #37673

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update of L3MuonCandidateProducerFromMuons to work also with displaced #37636

Update of L3MuonCandidateProducerFromMuons to work also with displaced #37636

alexsr-98 commented Apr 20, 2022

cmsbuild commented Apr 20, 2022

cmsbuild commented Apr 20, 2022

missirol Apr 20, 2022

missirol Apr 20, 2022

alexsr-98 Apr 20, 2022

cmsbuild commented Apr 20, 2022

cmsbuild commented Apr 20, 2022

missirol commented Apr 20, 2022

cmsbuild commented Apr 21, 2022

missirol left a comment

missirol Apr 21, 2022

missirol Apr 21, 2022

cmsbuild commented Apr 21, 2022

cmsbuild commented Apr 21, 2022

missirol commented Apr 21, 2022

cmsbuild commented Apr 21, 2022

missirol commented Apr 21, 2022

missirol commented Apr 21, 2022

clacaputo commented Apr 25, 2022

cmsbuild commented Apr 25, 2022

perrotta commented Apr 25, 2022

perrotta commented Apr 25, 2022

	tkref = ((muons)[i].innerTrack().isNonnull()) ? (muons)[i].innerTrack() : (*muons)[i].muonBestTrack();
	tkref = (muons)[i].innerTrack().isNonnull() ? (muons)[i].innerTrack() : (*muons)[i].muonBestTrack();

Update of L3MuonCandidateProducerFromMuons to work also with displaced #37636

Update of L3MuonCandidateProducerFromMuons to work also with displaced #37636

Conversation

alexsr-98 commented Apr 20, 2022

PR description:

PR validation:

cmsbuild commented Apr 20, 2022

cmsbuild commented Apr 20, 2022

missirol Apr 20, 2022

Choose a reason for hiding this comment

missirol Apr 20, 2022

Choose a reason for hiding this comment

alexsr-98 Apr 20, 2022

Choose a reason for hiding this comment

cmsbuild commented Apr 20, 2022

cmsbuild commented Apr 20, 2022

missirol commented Apr 20, 2022

cmsbuild commented Apr 21, 2022

Comparison Summary

missirol left a comment

Choose a reason for hiding this comment

missirol Apr 21, 2022

Choose a reason for hiding this comment

missirol Apr 21, 2022

Choose a reason for hiding this comment

cmsbuild commented Apr 21, 2022

cmsbuild commented Apr 21, 2022

missirol commented Apr 21, 2022

cmsbuild commented Apr 21, 2022

RelVals-INPUT

Comparison Summary

missirol commented Apr 21, 2022

missirol commented Apr 21, 2022

clacaputo commented Apr 25, 2022

cmsbuild commented Apr 25, 2022

perrotta commented Apr 25, 2022

perrotta commented Apr 25, 2022