Phase2-hgx310A Extend HGCalWaferMask to provide list of corners of partial wafers with new definition of placement index

[bsunanda]

PR description:

Extend HGCalWaferMask to provide list of corners of partial wafers with new definition of placement index

PR validation:

Use the runTheMatrix test workflows

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37664/29465

• This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37664/29465/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37664/29465/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37664/29466

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

• Geometry/HGCalCommonData (geometry, upgrade)

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks.
@trtomei, @beaucero, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fbf31e/24152/summary.html
COMMIT: 45bac75
CMSSW: CMSSW_12_4_X_2022-04-23-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37664/24152/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-fbf31e/39434.75_TTbar_14TeV+2026D88_HLT75e33+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HLT75e33+HARVESTGlobal

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3695434
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3695410
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 205 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37664/29484

• This PR adds an extra 20KB to repository

[cmsbuild]

Pull request #37664 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @AdrianoDee, @srimanob can you please check and sign again.

[bsunanda]

@cvuosalo @civanch @srimanob Please sign this PR so that we can proceed for the next step of V17 geometry

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fbf31e/24251/summary.html
COMMIT: 0f1e204
CMSSW: CMSSW_12_4_X_2022-04-26-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37664/24251/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3695434
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3695404
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 48 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 205 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[rovere]

Ciao @bsunanda
thanks for the prompt fix. It would still be useful to have some accompanying documentation, in the format you prefer, to complement this PR to explain what the "magic numbers" that appear mean.

Also, I see that you introduce an additional waferXY method, w/o modifying the existing one: is there a particular reason for this? Is the old method still needed somewhere? At some point some general cleaning of legacy/unused code is mandatory.

For the occasional reader this will generate quite some confusion to try and understand which one to use. Maybe adding a couple of lines as comments could help.

[bsunanda]

waferXY method gives corners of the partial wafers in its local coordinate system. We have moved from one set of conventions to a different one from V16 and V17. The two methods correspond to the 2 methods. Prithvi, Indra and I discussed the documentation and we shall provide it there. Once this PR is added to the master (which we need urgently so that Prithvi can add the algorithm and complete the wafer definition for v17), I shall add some inline documentation in the code.

[bsunanda]

@srimanob Please test

[bsunanda]

@srimanob Please sign this PR. We are waiting for adding the next steps

[bsunanda]

@srimanob Please sign this PR. We are waiting for adding the next steps

[srimanob]

+Upgrade

The PR introduce another way to get a list of corners of partial wafers. Documentation will be provided in the later PR.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

• Please don't forget to add some inline documentation, as you are anticipating in Phase2-hgx310A Extend HGCalWaferMask to provide list of corners of partial wafers with new definition of placement index #37664 (comment)