Remove some unnecessary framework includes from ReggeGribovPartonMCHadronizer #37710

makortel · 2022-04-27T15:56:55Z

PR description:

Identified as part of #37592.

PR validation:

Code compiles.

cmsbuild · 2022-04-27T16:03:06Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37710/29538

This PR adds an extra 16KB to repository

cmsbuild · 2022-04-27T16:03:29Z

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

GeneratorInterface/ReggeGribovPartonMCInterface (generators)

@SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @GurpreetSinghChahal, @alberto-sanchez can you please review it and eventually sign? Thanks.
@alberto-sanchez, @cbaus, @mkirsano this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

makortel · 2022-04-27T16:06:38Z

@cmsbuild, please test

cmsbuild · 2022-04-27T17:31:09Z

-1

Failed Tests: RelVals RelVals-INPUT AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3c6495/24272/summary.html
COMMIT: 4bb392d
CMSSW: CMSSW_12_4_X_2022-04-27-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37710/24272/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

312.0

----- Begin Fatal Exception 27-Apr-2022 16:34:12 UTC-----------------------
An exception of category 'FileOpenError' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'HLTAnalyzerEndpath'
   [2] Prefetching for module L1TRawToDigi/'hltGtStage2Digis'
   [3] Prefetching for module RawDataCollectorByLabel/'rawDataCollector'
   [4] Prefetching for module SiStripDigiToRawModule/'SiStripDigiToRaw'
   [5] Calling method for module MixingModule/'mix'
   [6] Calling RootInputFileSequence::initTheFile()
   [7] Calling StorageFactory::open()
   [8] Calling XrdFile::open()
Exception Message:
Failed to open the file 'root://cms-xrd-global.cern.ch//store/relval/CMSSW_12_1_0_pre4/RelValHydjetQ_B12_5020GeV_2021_ppReco/GEN-SIM/121X_mcRun3_2021_realistic_HI_v10-v1/10000/e2fc79c2-9ac7-4e01-af0c-85e4bee00bee.root'
   Additional Info:
      [a] Calling RootInputFileSequence::initTheFile(): fail to open the file with name root://eoscms.cern.ch//eos/cms/store/user/cmsbuild/store/relval/CMSSW_12_1_0_pre4/RelValHydjetQ_B12_5020GeV_2021_ppReco/GEN-SIM/121X_mcRun3_2021_realistic_HI_v10-v1/10000/e2fc79c2-9ac7-4e01-af0c-85e4bee00bee.root
      [b] Input file root://cms-xrd-global.cern.ch//store/relval/CMSSW_12_1_0_pre4/RelValHydjetQ_B12_5020GeV_2021_ppReco/GEN-SIM/121X_mcRun3_2021_realistic_HI_v10-v1/10000/e2fc79c2-9ac7-4e01-af0c-85e4bee00bee.root could not be opened.
      [c] XrdCl::File::Open(name='root://cms-xrd-global.cern.ch//store/relval/CMSSW_12_1_0_pre4/RelValHydjetQ_B12_5020GeV_2021_ppReco/GEN-SIM/121X_mcRun3_2021_realistic_HI_v10-v1/10000/e2fc79c2-9ac7-4e01-af0c-85e4bee00bee.root', flags=0x10, permissions=0660) => error '[ERROR] Server responded with an error: [3014] Unable to open file  /eos/cms/store/relval/CMSSW_12_1_0_pre4/RelValHydjetQ_B12_5020GeV_2021_ppReco/GEN-SIM/121X_mcRun3_2021_realistic_HI_v10-v1/10000/e2fc79c2-9ac7-4e01-af0c-85e4bee00bee.root; Network is unreachable
' (errno=3014, code=400). No additional data servers were found.
      [d] Last URL tried: root://eoscms.cern.ch:1094//store/relval/CMSSW_12_1_0_pre4/RelValHydjetQ_B12_5020GeV_2021_ppReco/GEN-SIM/121X_mcRun3_2021_realistic_HI_v10-v1/10000/e2fc79c2-9ac7-4e01-af0c-85e4bee00bee.root?tried=&xrdcl.requuid=ca5c5d2a-0c51-4966-b83f-19cb3be76fac
      [e] Problematic data server: eoscms.cern.ch:1094
      [f] Disabled source: eoscms.cern.ch:1094
----- End Fatal Exception -------------------------------------------------

RelVals-INPUT

136.735136.735_RunNoBPTX2016B+RunNoBPTX2016B+HLTDR2_2016+RECODR2reHLTAlCaTkCosmics_HIPM+HARVESTDR2/step2_RunNoBPTX2016B+RunNoBPTX2016B+HLTDR2_2016+RECODR2reHLTAlCaTkCosmics_HIPM+HARVESTDR2.log
136.74136.74_RunMET2016C+RunMET2016C+HLTDR2_2016+RECODR2_2016reHLT_skimMET_HIPM+HARVESTDR2_skimMET/step2_RunMET2016C+RunMET2016C+HLTDR2_2016+RECODR2_2016reHLT_skimMET_HIPM+HARVESTDR2_skimMET.log
136.741136.741_RunMuonEG2016C+RunMuonEG2016C+HLTDR2_2016+RECODR2_2016reHLT_skimMuonEG_HIPM+HARVESTDR2_skimMuonEG/step2_RunMuonEG2016C+RunMuonEG2016C+HLTDR2_2016+RECODR2_2016reHLT_skimMuonEG_HIPM+HARVESTDR2_skimMuonEG.log

Expand to see more relval errors ...

AddOn Tests

hlt_data_PRef

----- Begin Fatal Exception 27-Apr-2022 18:34:21 CEST-----------------------
An exception of category 'FileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootInputFileSequence::initTheFile()
   [3] Calling StorageFactory::open()
   [4] Calling XrdFile::open()
Exception Message:
Failed to open the file 'root://eoscms.cern.ch//eos/cms/store/group/dpg_trigger/comm_trigger/TriggerStudiesGroup/STORM/RAW/Commissioning2021_MinimumBias1_run346304/0949cd03-66a6-4034-a630-b9fef4dde3d2.root'
   Additional Info:
      [a] Input file root://eoscms.cern.ch//eos/cms/store/group/dpg_trigger/comm_trigger/TriggerStudiesGroup/STORM/RAW/Commissioning2021_MinimumBias1_run346304/0949cd03-66a6-4034-a630-b9fef4dde3d2.root could not be opened.
      [b] XrdCl::File::Open(name='root://eoscms.cern.ch//eos/cms/store/group/dpg_trigger/comm_trigger/TriggerStudiesGroup/STORM/RAW/Commissioning2021_MinimumBias1_run346304/0949cd03-66a6-4034-a630-b9fef4dde3d2.root', flags=0x10, permissions=0660) => error '[ERROR] Server responded with an error: [3014] Unable to open file  /eos/cms/store/group/dpg_trigger/comm_trigger/TriggerStudiesGroup/STORM/RAW/Commissioning2021_MinimumBias1_run346304/0949cd03-66a6-4034-a630-b9fef4dde3d2.root; Network is unreachable
' (errno=3014, code=400). No additional data servers were found.
      [c] Last URL tried: root://eoscms.cern.ch:1094//eos/cms/store/group/dpg_trigger/comm_trigger/TriggerStudiesGroup/STORM/RAW/Commissioning2021_MinimumBias1_run346304/0949cd03-66a6-4034-a630-b9fef4dde3d2.root?tried=&xrdcl.requuid=01190633-0a8d-4d90-8e57-297f3de58e24
      [d] Problematic data server: eoscms.cern.ch:1094
      [e] Disabled source: eoscms.cern.ch:1094
----- End Fatal Exception -------------------------------------------------

hlt_mc_PRefcmsRun /cvmfs/cms-ib.cern.ch/nweek-02730/slc7_amd64_gcc10/cms/cmssw/CMSSW_12_4_X_2022-04-27-1100/src/HLTrigger/Configuration/test/OnLine_HLT_PRef.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Wed Apr 27 18:35:08 2022-date Wed Apr 27 18:33:06 2022 s - exit: 21504
hlt_data_PRef

----- Begin Fatal Exception 27-Apr-2022 18:35:08 CEST-----------------------
An exception of category 'FileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootInputFileSequence::initTheFile()
   [3] Calling StorageFactory::open()
   [4] Calling File::sysopen()
Exception Message:
Failed to open the file 'RelVal_Raw_PRef_DATA.root'
   Additional Info:
      [a] Input file file:RelVal_Raw_PRef_DATA.root could not be opened.
      [b] open() failed with system error 'No such file or directory' (error code 2)
----- End Fatal Exception -------------------------------------------------

makortel · 2022-04-28T13:37:47Z

@cmsbuild, please test

Failures look transient

cmsbuild · 2022-04-28T17:21:19Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3c6495/24317/summary.html
COMMIT: 4bb392d
CMSSW: CMSSW_12_4_X_2022-04-27-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37710/24317/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3695434
DQMHistoTests: Total failures: 14
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3695398
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 205 log files, 45 edm output root files, 49 DQM output files
TriggerResults: no differences found

SiewYan · 2022-05-02T07:36:53Z

+1

cmsbuild · 2022-05-02T07:37:14Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2022-05-02T08:37:00Z

+1

Remove (some) unnecessary includes

4bb392d

cmsbuild added this to the CMSSW_12_4_X milestone Apr 27, 2022

cmsbuild added code-checks-pending generators-pending orp-pending pending-signatures tests-pending labels Apr 27, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 27, 2022

cmsbuild added tests-started and removed tests-pending labels Apr 27, 2022

cmsbuild added tests-rejected and removed tests-started labels Apr 27, 2022

makortel mentioned this pull request Apr 28, 2022

Improve legacy EDModule deprecation warnings cms-sw/framework-team#393

Closed

6 tasks

cmsbuild added tests-started and removed tests-rejected labels Apr 28, 2022

cmsbuild added tests-approved and removed tests-started labels Apr 28, 2022

cmsbuild added fully-signed generators-approved and removed generators-pending pending-signatures labels May 2, 2022

cmsbuild added orp-approved and removed orp-pending labels May 2, 2022

cmsbuild merged commit 667b084 into cms-sw:master May 2, 2022

makortel deleted the unnecessaryIncludesGen branch May 2, 2022 13:48

cmsbuild mentioned this pull request May 2, 2022

EL9 warning fix: use mallinfo2 for glibc>=2.33 #37768

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove some unnecessary framework includes from ReggeGribovPartonMCHadronizer #37710

Remove some unnecessary framework includes from ReggeGribovPartonMCHadronizer #37710

makortel commented Apr 27, 2022

cmsbuild commented Apr 27, 2022

cmsbuild commented Apr 27, 2022

makortel commented Apr 27, 2022

cmsbuild commented Apr 27, 2022

makortel commented Apr 28, 2022

cmsbuild commented Apr 28, 2022

SiewYan commented May 2, 2022

cmsbuild commented May 2, 2022

perrotta commented May 2, 2022

Remove some unnecessary framework includes from ReggeGribovPartonMCHadronizer #37710

Remove some unnecessary framework includes from ReggeGribovPartonMCHadronizer #37710

Conversation

makortel commented Apr 27, 2022

PR description:

PR validation:

cmsbuild commented Apr 27, 2022

cmsbuild commented Apr 27, 2022

makortel commented Apr 27, 2022

cmsbuild commented Apr 27, 2022

RelVals

RelVals-INPUT

AddOn Tests

makortel commented Apr 28, 2022

cmsbuild commented Apr 28, 2022

Comparison Summary

SiewYan commented May 2, 2022

cmsbuild commented May 2, 2022

perrotta commented May 2, 2022