Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reco] Remove (some) unnecessary framework includes #37715

Merged
merged 1 commit into from Apr 29, 2022

Conversation

makortel
Copy link
Contributor

@makortel makortel commented Apr 27, 2022

PR description:

This PR removes unnecessary #includes of legacy EDModule headers plus some more of framework headers (that were clearly unused). These #includes were identified as part of #37592.

PR validation:

Code compiles.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37715/29552

  • This PR adds an extra 56KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

  • CommonTools/ParticleFlow (reconstruction)
  • PhysicsTools/IsolationAlgos (reconstruction)
  • RecoHI/HiJetAlgos (reconstruction)
  • RecoLocalCalo/EcalRecProducers (reconstruction)
  • RecoLocalMuon/CSCRecHitD (reconstruction)
  • RecoMuon/GlobalTrackingTools (reconstruction)
  • RecoMuon/MuonIsolationProducers (reconstruction)
  • RecoMuon/MuonSeedGenerator (reconstruction)
  • RecoPPS/Local (reconstruction)
  • RecoTracker/ConversionSeedGenerators (reconstruction)

@jpata, @cmsbuild, @clacaputo, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @grzanka, @yslai, @felicepantaleo, @abbiendi, @CeliaFernandez, @argiro, @Fedespring, @thomreis, @mmusich, @cericeci, @jdolen, @ahinzmann, @JanFSchulte, @jhgoh, @dgulhan, @apsallid, @sscruz, @simonepigazzini, @trocino, @rociovilar, @GiacomoSguazzoni, @rovere, @VinInn, @bellan, @gkasieczka, @hatakeyamak, @ebrondol, @ptcox, @mtosi, @amagitte, @HuguesBrun, @rchatter, @mandrenguyen, @jazzitup, @yenjie, @kurtejung, @gpetruc, @yetkinyilmaz this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-45df59/24282/summary.html
COMMIT: 074fe09
CMSSW: CMSSW_12_4_X_2022-04-27-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37715/24282/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
1001.2 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3695434
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3695410
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 205 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@jpata
Copy link
Contributor

jpata commented Apr 29, 2022

+reconstruction

  • technical, no changes

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 06ecd48 into cms-sw:master Apr 29, 2022
@makortel makortel deleted the unnecessaryIncludesReco branch April 29, 2022 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants