Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the .gitignore rules #37719

Merged
merged 1 commit into from May 3, 2022

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Apr 27, 2022

PR description:

Update the .gitignore rules:

  • ignore files under the top level $CMSSW_BASE/src directory, but not its subdirectories
  • ignore partially applied patches and their backup

PR validation:

Before:

$ touch x
$ git status
On branch CMSSW_12_4_X
Your branch is up to date with 'cmssw/CMSSW_12_4_X'.

Untracked files:
  (use "git add <file>..." to include in what will be committed)
        x

nothing added to commit but untracked files present (use "git add" to track)

After:

$ touch x
$ git status
On branch CMSSW_12_4_X_update_gitignore
Your branch is up to date with 'fwyzard/CMSSW_12_4_X_update_gitignore'.

nothing to commit, working tree clean

Update the .gitignore rules:
  - ignore files under the top level $CMSSW_BASE/src directory, but not its subdirectories;
  - ignore partially applied patches and their backup.
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37719/29555

  • This PR adds an extra 12KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

  • .gitignore (core)

@cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@fwyzard
Copy link
Contributor Author

fwyzard commented Apr 30, 2022

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 1, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-165f40/24358/summary.html
COMMIT: fe03dbb
CMSSW: CMSSW_12_4_X_2022-04-30-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37719/24358/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3704146
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3704122
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 205 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@makortel
Copy link
Contributor

makortel commented May 2, 2022

Looks ok to me, @smuzaffar what do you think?

@smuzaffar
Copy link
Contributor

looks good to me too

@makortel
Copy link
Contributor

makortel commented May 2, 2022

+core

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented May 3, 2022

+1

@cmsbuild cmsbuild merged commit c685615 into cms-sw:master May 3, 2022
@fwyzard fwyzard deleted the CMSSW_12_4_X_update_gitignore branch July 31, 2022 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants