Create infrastructure to allow alternative module types to be loaded #37731

Dr15Jones · 2022-04-28T20:35:19Z

PR description:

Provide API to allow alternative module implementation to be loaded based on the name of the type of the module given in the configuration.

PR validation:

Framework unit tests (including the newly added one for this change) all pass.

solves cms-sw/framework-team#392

cmsbuild · 2022-04-28T20:42:18Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37731/29583

This PR adds an extra 32KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37731/29583/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37731/29583/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2022-04-28T20:55:42Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37731/29584

This PR adds an extra 32KB to repository

cmsbuild · 2022-04-28T20:56:07Z

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

FWCore/Framework (core)

@cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please review it and eventually sign? Thanks.
@makortel, @wddgit this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

Dr15Jones · 2022-04-28T21:02:09Z

please test

Dr15Jones · 2022-04-28T21:09:14Z

FWCore/Framework/src/Factory.cc

-      std::unique_ptr<Maker> wm(MakerPluginFactory::get()->create(modtype));
-
-      if (wm.get() == nullptr)
-        throw edm::Exception(errors::Configuration, "UnknownModule")


Turns out, the code can never get here since MakerPluginFactory::create throws an exception if it fails to load a module.

cmsbuild · 2022-04-29T01:07:05Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6c1a9c/24321/summary.html
COMMIT: bc8b17c
CMSSW: CMSSW_12_4_X_2022-04-28-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37731/24321/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

@bsunanda Run3-hcx332 Replace some of the getByLabel with getHandle in SimCalorimetry/HcalSimProducers #37721
@makortel [L1] Remove (some) unnecessary framework includes #37713
@cecilecaillol [L1] CSCTF fix issue with writing beyond array boundaries #37707
@makortel Remove unnecessary include of legacy EDAnalyzer header from HLTGenericFilter #37709
@CMSTrackerDPG Pixel Heterogeneous DQM: add modules for Tracks and Vertices @cpu / @gpu comparisons #37619
@bsunanda Run3-hcx333 Replace getByLabel with getHandle in SimCalorimetry/HcalTestBeam #37723
@bsunanda Run3-sim117X Replace getByLabel with getHandle in SimG4Core/CustomPhysics #37699

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6c1a9c/24321/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6c1a9c/24321/git-merge-result

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 6 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3695434
DQMHistoTests: Total failures: 13
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 3695398
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 48 files compared)
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 205 log files, 45 edm output root files, 49 DQM output files
TriggerResults: no differences found

cmsbuild · 2022-04-29T13:49:06Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37731/29603

This PR adds an extra 20KB to repository

Provide API to allow alternative module implementation to be loaded based on the name of the type of the module given in the configuration.

cmsbuild · 2022-05-05T16:13:17Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37731/29739

This PR adds an extra 32KB to repository

cmsbuild · 2022-05-05T16:13:38Z

Pull request #37731 was updated. @cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please check and sign again.

Dr15Jones · 2022-05-05T16:13:58Z

please test

cmsbuild · 2022-05-05T20:16:17Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6c1a9c/24479/summary.html
COMMIT: 7c4483d
CMSSW: CMSSW_12_4_X_2022-05-05-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37731/24479/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 9 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3700704
DQMHistoTests: Total failures: 19
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 3700662
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.004 KiB( 48 files compared)
DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
Checked 206 log files, 45 edm output root files, 49 DQM output files
TriggerResults: no differences found

makortel · 2022-05-06T19:18:16Z

+1

cmsbuild · 2022-05-06T19:18:34Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2022-05-06T19:35:24Z

+1

cmsbuild added this to the CMSSW_12_4_X milestone Apr 28, 2022

cmsbuild added code-checks-pending core-pending orp-pending pending-signatures tests-pending labels Apr 28, 2022

cmsbuild added code-checks-rejected and removed code-checks-pending labels Apr 28, 2022

Dr15Jones force-pushed the loadAlternativeModuleTypes branch from c23d4d2 to bc8b17c Compare April 28, 2022 20:49

cmsbuild added code-checks-pending and removed code-checks-rejected labels Apr 28, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 28, 2022

cmsbuild added tests-started and removed tests-pending labels Apr 28, 2022

Dr15Jones commented Apr 28, 2022

View reviewed changes

cmsbuild added tests-approved and removed tests-started labels Apr 29, 2022

Dr15Jones force-pushed the loadAlternativeModuleTypes branch from bc8b17c to 3b229cc Compare April 29, 2022 13:41

cmsbuild added code-checks-pending tests-pending and removed tests-approved code-checks-approved labels Apr 29, 2022

cmsbuild removed the code-checks-pending label Apr 29, 2022

cmsbuild added code-checks-rejected and removed code-checks-pending labels May 5, 2022

Create infrastructure to allow alternative module types to be loaded

7c4483d

Provide API to allow alternative module implementation to be loaded based on the name of the type of the module given in the configuration.

Dr15Jones force-pushed the loadAlternativeModuleTypes branch from 8f84851 to 7c4483d Compare May 5, 2022 16:06

cmsbuild added code-checks-pending and removed code-checks-rejected labels May 5, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels May 5, 2022

cmsbuild added tests-started and removed tests-pending labels May 5, 2022

cmsbuild added tests-approved and removed tests-started labels May 5, 2022

cmsbuild added core-approved fully-signed and removed core-pending pending-signatures labels May 6, 2022

cmsbuild added orp-approved and removed orp-pending labels May 6, 2022

cmsbuild merged commit 597cff2 into cms-sw:master May 6, 2022

Dr15Jones deleted the loadAlternativeModuleTypes branch May 9, 2022 18:27

This was referenced Sep 10, 2022

Extend "alternative module loading" infrastructure to ESModules cms-sw/framework-team#435

Closed

Extend alternative module type loading to EventSetup #39391

Merged

makortel mentioned this pull request Dec 21, 2022

Improve module type resolver system so that it would be usable for Alpaka modules #40383

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create infrastructure to allow alternative module types to be loaded #37731

Create infrastructure to allow alternative module types to be loaded #37731

Dr15Jones commented Apr 28, 2022 •

edited

cmsbuild commented Apr 28, 2022

cmsbuild commented Apr 28, 2022

cmsbuild commented Apr 28, 2022

Dr15Jones commented Apr 28, 2022

Dr15Jones Apr 28, 2022

cmsbuild commented Apr 29, 2022

cmsbuild commented Apr 29, 2022

cmsbuild commented May 5, 2022

cmsbuild commented May 5, 2022

Dr15Jones commented May 5, 2022

cmsbuild commented May 5, 2022

makortel commented May 6, 2022

cmsbuild commented May 6, 2022

perrotta commented May 6, 2022

Create infrastructure to allow alternative module types to be loaded #37731

Create infrastructure to allow alternative module types to be loaded #37731

Conversation

Dr15Jones commented Apr 28, 2022 • edited

PR description:

PR validation:

cmsbuild commented Apr 28, 2022

cmsbuild commented Apr 28, 2022

cmsbuild commented Apr 28, 2022

Dr15Jones commented Apr 28, 2022

Dr15Jones Apr 28, 2022

Choose a reason for hiding this comment

cmsbuild commented Apr 29, 2022

Comparison Summary

cmsbuild commented Apr 29, 2022

cmsbuild commented May 5, 2022

cmsbuild commented May 5, 2022

Dr15Jones commented May 5, 2022

cmsbuild commented May 5, 2022

Comparison Summary

makortel commented May 6, 2022

cmsbuild commented May 6, 2022

perrotta commented May 6, 2022

Dr15Jones commented Apr 28, 2022 •

edited