Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.3.X] Pixel Heterogeneous DQM: add modules for Tracks and Vertices @cpu / @gpu comparisons #37737

Merged
merged 13 commits into from May 3, 2022

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Apr 29, 2022

backport of #37619

PR description:

Title says it all.
The code is actually from @sroychow and @arossi83.

PR validation:

Tested running wf. runTheMatrix.py --what gpu -l 11634.503 on lxplus-gpu successfully.

if this PR is a backport please specify the original PR and why you need to backport that PR:

verbatim backport of #37619

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 29, 2022

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_12_3_X.

It involves the following packages:

  • Configuration/ProcessModifiers (operations)
  • Configuration/PyReleaseValidation (pdmv, upgrade)
  • DQM/SiPixelPhase1Heterogeneous (dqm)

@perrotta, @jordan-martins, @bbilin, @emanueleusai, @ahmad3213, @cmsbuild, @AdrianoDee, @srimanob, @jfernan2, @pmandrik, @kskovpen, @qliphy, @rvenditti, @micsucmed, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@hdelanno, @makortel, @kpedro88, @fabiocos, @Martin-Grunewald, @missirol, @fioriNTU, @jandrea, @trtomei, @idebruyn, @threus, @beaucero, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Apr 29, 2022

test parameters:

  • enable_tests = gpu
  • workflows_gpu = 11634.503, 11634.506, 11634.583, 11634.587

@mmusich
Copy link
Contributor Author

mmusich commented Apr 29, 2022

enable gpu

@mmusich
Copy link
Contributor Author

mmusich commented Apr 29, 2022

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4e47a4/24330/summary.html
COMMIT: 6db5e71
CMSSW: CMSSW_12_3_X_2022-04-28-2300/slc7_amd64_gcc10
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37737/24330/install.sh to create a dev area with all the needed externals and cmssw changes.

GPU Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-4e47a4/11634.503_TTbar_14TeV+2021_Patatrack_PixelOnlyGPU_Validation+TTbar_14TeV_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-4e47a4/11634.583_TTbar_14TeV+2021_Patatrack_AllGPU_Validation+TTbar_14TeV_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-4e47a4/11634.587_TTbar_14TeV+2021_Patatrack_AllTripletsGPU_Validation+TTbar_14TeV_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 7
  • DQMHistoTests: Total histograms compared: 75632
  • DQMHistoTests: Total failures: 32
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 75600
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -12948.525000000001 KiB( 6 files compared)
  • DQMHistoSizes: changed ( 11634.503,... ): -8031.437 KiB SiPixelHeterogeneous/PixelRecHitsSoA
  • DQMHistoSizes: changed ( 11634.503,... ): 3437.216 KiB SiPixelHeterogeneous/PixelTrackCompareGPUvsCPU
  • DQMHistoSizes: changed ( 11634.503,... ): 263.467 KiB SiPixelHeterogeneous/PixelVertexCompareSoAGPUvsCPU
  • DQMHistoSizes: changed ( 11634.503,... ): 12.031 KiB SiPixelHeterogeneous/PixelTrackSoACPU
  • DQMHistoSizes: changed ( 11634.503,... ): 12.031 KiB SiPixelHeterogeneous/PixelTrackSoAGPU
  • DQMHistoSizes: changed ( 11634.503,... ): -11.981 KiB SiPixelHeterogeneous/PixelTrackSoA
  • DQMHistoSizes: changed ( 11634.503,... ): 2.475 KiB SiPixelHeterogeneous/PixelVertexSoACPU
  • DQMHistoSizes: changed ( 11634.503,... ): 2.475 KiB SiPixelHeterogeneous/PixelVertexSoAGPU
  • DQMHistoSizes: changed ( 11634.503,... ): -2.451 KiB SiPixelHeterogeneous/PixelVertexSoA
  • Checked 24 log files, 18 edm output root files, 7 DQM output files
  • TriggerResults: no differences found

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3697135
  • DQMHistoTests: Total failures: 14
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3697099
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

+1

@fwyzard
Copy link
Contributor

fwyzard commented May 2, 2022

urgent

We would like to have this in the next (patch) release so it can be deployed at P5.

@cmsbuild cmsbuild added the urgent label May 2, 2022
@perrotta
Copy link
Contributor

perrotta commented May 2, 2022

Verbatim backport of #37619
(mostly a promemoria for orp, for when this will get fully signed...)

@kskovpen
Copy link
Contributor

kskovpen commented May 2, 2022

+pdmv

@AdrianoDee
Copy link
Contributor

+upgrade

@perrotta
Copy link
Contributor

perrotta commented May 3, 2022

+1

  • Backport of the identical PR successfully merged in master since CMSSW_12_4_X_2022-04-28-2300

@perrotta
Copy link
Contributor

perrotta commented May 3, 2022

ping

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2022

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_4_X is complete. This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 474f2db into cms-sw:CMSSW_12_3_X May 3, 2022
@mmusich mmusich deleted the gpuvalidPixtrkvtx_12_3_X branch May 3, 2022 17:17
@perrotta
Copy link
Contributor

perrotta commented May 5, 2022

CMSSW_12_3_2_patch1 is now available, see https://github.com/cms-sw/cmssw/releases/CMSSW_12_3_2_patch1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants