[NanoAOD] Setup AK4 Puppi jets as default AK4 collection for Run 3 #37744

nurfikri89 · 2022-04-29T18:20:02Z

PR description:

This PR sets the AK4 Puppi jet collection as the default AK4 jet collection for Run 3 NanoAOD production. The AK4 Puppi jet collection is retrieved from MiniAOD (slimmedJetsPuppi) and are saved in the Jet table in NanoAODs, although with less variables stored, compared to AK4 CHS jets, due to the unavailable trainings for PileUp Id, Quark-Gluon Likelihood and b-jet/c-jet energy regression.

The reco jet configurations have been split up into three different cff files. Two new cff files for AK4 Puppi jets (jetsAK4_Puppi_cff.py) and AK8 Puppi jets (jetsAK8_cff.py) with jets_cff.py renamed to jetsAK4_CHS_cff.py. All AK8 Puppi related configurations in jets_cff.py are moved to jetsAK8_cff.py. For Run 2 compatibility, Run 2 modifiers are set up in various files to switch from AK4 Puppi jets to AK4 CHS jets. Some housekeeping were also done like moving the AK4 and AK8 DeepInfo functions and switches from nano_cff.py to jetsAK4_CHS_cff.py and jetsAK8_cff.py.

…ff files. Move jet tagging switches from nano_cff to AK4 CHS and AK8 cff files. Setup switches to AK4 CHS using Run2 modifiers.

mariadalfonso · 2022-04-29T18:25:42Z

please test

cmsbuild · 2022-04-29T18:28:48Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37744/29608

This PR adds an extra 40KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File PhysicsTools/NanoAOD/python/electrons_cff.py modified in PR(s): Adding HZZ electron MVA ID #37429
- File PhysicsTools/NanoAOD/python/nano_cff.py modified in PR(s): LowPtElectrons: updates for nano v10 #37137, Refactoring gen weight storage in EDM + Nano integration #32167

cmsbuild · 2022-04-29T18:29:13Z

A new Pull Request was created by @nurfikri89 (Nurfikri Norjoharuddeen) for master.

It involves the following packages:

PhysicsTools/NanoAOD (xpog)

@mariadalfonso, @gouskos, @fgolf can you please review it and eventually sign? Thanks.
@gpetruc, @swertz this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2022-04-29T22:17:22Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b9a22a/24344/summary.html
COMMIT: 9927904
CMSSW: CMSSW_12_4_X_2022-04-29-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37744/24344/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3695434
DQMHistoTests: Total failures: 1000
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3694412
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 205 log files, 45 edm output root files, 49 DQM output files
TriggerResults: no differences found

PhysicsTools/NanoAOD/python/jetsAK4_Puppi_cff.py

cmsbuild · 2022-04-30T02:43:43Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37744/29623

This PR adds an extra 40KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File PhysicsTools/NanoAOD/python/electrons_cff.py modified in PR(s): Adding HZZ electron MVA ID #37429
- File PhysicsTools/NanoAOD/python/nano_cff.py modified in PR(s): LowPtElectrons: updates for nano v10 #37137, Refactoring gen weight storage in EDM + Nano integration #32167

cmsbuild · 2022-04-30T02:44:06Z

Pull request #37744 was updated. @cmsbuild, @mariadalfonso, @gouskos, @fgolf can you please check and sign again.

mariadalfonso · 2022-04-30T06:45:10Z

please test

nurfikri89 · 2022-05-25T09:20:21Z

@mariadalfonso, anything left for me to add/remove?

mariadalfonso · 2022-05-25T10:00:00Z

@mariadalfonso, anything left for me to add/remove?

Hi @nurfikri89,
at the moment it's very unclear how to proceed.

For Run3, given the recent addition in Port DeepJet and ParticleNetAK4 taggers to Puppi jets in MiniAOD #37814 I would like to get a signed off table from JMAR and BTV of what will be actually the default.
For Run2, if the GT with JEC-AK4 puppi, all the JMAR/BTV training and their calibration are not available for the Run2-puppiAK4 we have to postpone the switch. And for the time being we will need to restore the CHS. Furthermore those will need to be in synch with Run3. If we blindly make the switch now we will not be able to do any analysis with the V10nano of UL.

Hopefully these will be clear next week : JME meeting on the may 30th and at the XPOG meeting on the June 1st

mariadalfonso · 2022-06-01T17:43:44Z

please test

(to recheck with updated IB)

cmsbuild · 2022-06-01T21:32:27Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b9a22a/25172/summary.html
COMMIT: f3d6e21
CMSSW: CMSSW_12_5_X_2022-06-01-1600/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37744/25172/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3649923
DQMHistoTests: Total failures: 909
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3648992
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 208 log files, 45 edm output root files, 50 DQM output files
TriggerResults: no differences found

mariadalfonso · 2022-06-02T08:49:02Z

+xpog

Run3 jets moved to puppi
Run2 jets stay with CHS

Changes here #37744 (comment)
BTV branches and training need to be finalised

cmsbuild · 2022-06-02T08:49:24Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

mariadalfonso · 2022-06-02T16:56:05Z

@nurfikri89
we need the 12_4 backport

qliphy · 2022-06-03T06:29:25Z

+1

…srun3_forPR [NanoAOD] Backport of #37744 (Setup AK4 Puppi jets as default AK4 collection for Run 3) to 12_4_X

nurfikri89 added 2 commits April 29, 2022 19:50

Rename file jets_cf as prep for Run3 updates

c9e6314

Setup AK4 Puppi for Nano Run3. Split reco jet configurations into 3 c…

9927904

…ff files. Move jet tagging switches from nano_cff to AK4 CHS and AK8 cff files. Setup switches to AK4 CHS using Run2 modifiers.

cmsbuild added this to the CMSSW_12_4_X milestone Apr 29, 2022

cmsbuild added code-checks-pending orp-pending pending-signatures tests-pending xpog-pending labels Apr 29, 2022

cmsbuild added tests-started and removed tests-pending labels Apr 29, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 29, 2022

cmsbuild added tests-approved and removed tests-started labels Apr 29, 2022

nurfikri89 commented Apr 30, 2022

View reviewed changes

PhysicsTools/NanoAOD/python/jetsAK4_Puppi_cff.py Show resolved Hide resolved

Add muonSubtrFactor variable for AK4 Puppi table

e230b0e

cmsbuild added code-checks-pending tests-pending and removed tests-approved code-checks-approved labels Apr 30, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 30, 2022

cmsbuild removed the tests-pending label Apr 30, 2022

smuzaffar modified the milestones: CMSSW_12_4_X, CMSSW_12_5_X May 16, 2022

cmsbuild mentioned this pull request May 24, 2022

Adding DeepMET SONIC Producer to CMSSW #37963

Merged

cmsbuild mentioned this pull request May 25, 2022

Adding HZZ electron MVA ID #37429

Closed

cmsbuild added tests-started and removed tests-approved labels Jun 1, 2022

cmsbuild added tests-approved and removed tests-started labels Jun 1, 2022

cmsbuild added fully-signed xpog-approved and removed pending-signatures xpog-pending labels Jun 2, 2022

nurfikri89 mentioned this pull request Jun 2, 2022

[NanoAOD] Backport of #37744 (Setup AK4 Puppi jets as default AK4 collection for Run 3) to 12_4_X #38207

Merged

cmsbuild added orp-approved and removed orp-pending labels Jun 3, 2022

cmsbuild merged commit b54d06d into cms-sw:master Jun 3, 2022

mariadalfonso mentioned this pull request Jun 3, 2022

new features for V10 nanoAOD cms-nanoAOD/cmssw#580

Closed

39 tasks

cmsbuild added a commit that referenced this pull request Jun 4, 2022

Merge pull request #38207 from nurfikri89/portFrom125XTo124X_nano_jet…

bedc8e5

…srun3_forPR [NanoAOD] Backport of #37744 (Setup AK4 Puppi jets as default AK4 collection for Run 3) to 12_4_X

nurfikri89 deleted the from1240pre3_nano_jetsrun3_forPR branch October 18, 2022 15:26

nurfikri89 restored the from1240pre3_nano_jetsrun3_forPR branch October 18, 2022 15:26

nurfikri89 deleted the from1240pre3_nano_jetsrun3_forPR branch January 11, 2023 15:02

swertz mentioned this pull request Mar 23, 2023

Integration of extended ParticleNet trainings for simultaneous jet flavor tagging, pT regression, and tau ID + reconstruction #40745

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[NanoAOD] Setup AK4 Puppi jets as default AK4 collection for Run 3 #37744

[NanoAOD] Setup AK4 Puppi jets as default AK4 collection for Run 3 #37744

nurfikri89 commented Apr 29, 2022

mariadalfonso commented Apr 29, 2022

cmsbuild commented Apr 29, 2022

cmsbuild commented Apr 29, 2022

cmsbuild commented Apr 29, 2022

cmsbuild commented Apr 30, 2022

cmsbuild commented Apr 30, 2022

mariadalfonso commented Apr 30, 2022

nurfikri89 commented May 25, 2022

mariadalfonso commented May 25, 2022

mariadalfonso commented Jun 1, 2022

cmsbuild commented Jun 1, 2022

mariadalfonso commented Jun 2, 2022 •

edited

cmsbuild commented Jun 2, 2022

mariadalfonso commented Jun 2, 2022

qliphy commented Jun 3, 2022

[NanoAOD] Setup AK4 Puppi jets as default AK4 collection for Run 3 #37744

[NanoAOD] Setup AK4 Puppi jets as default AK4 collection for Run 3 #37744

Conversation

nurfikri89 commented Apr 29, 2022

PR description:

mariadalfonso commented Apr 29, 2022

cmsbuild commented Apr 29, 2022

cmsbuild commented Apr 29, 2022

cmsbuild commented Apr 29, 2022

Comparison Summary

cmsbuild commented Apr 30, 2022

cmsbuild commented Apr 30, 2022

mariadalfonso commented Apr 30, 2022

nurfikri89 commented May 25, 2022

mariadalfonso commented May 25, 2022

mariadalfonso commented Jun 1, 2022

cmsbuild commented Jun 1, 2022

Comparison Summary

mariadalfonso commented Jun 2, 2022 • edited

cmsbuild commented Jun 2, 2022

mariadalfonso commented Jun 2, 2022

qliphy commented Jun 3, 2022

mariadalfonso commented Jun 2, 2022 •

edited