implement multiple working points in ID for e/g triggers based on HGCAL clusters #37758

jbsauvan · 2022-05-01T09:47:30Z

PR description:

Add the possibility to define several working points in the identification BDTs for the L1 e/g triggers based on HGCAL clusters.
FYI @cerminar

PR validation:

Private tests in L1Trigger/L1THGCalUtilities/test:

cmsRun testHGCalL1T_RelValV11_cfg.py
cmsRun testHGCalL1T_multialgo_V11_cfg.py

Tested D49, D60, D68, D77, D86 workflows

runTheMatrix.py -w upgrade -l 23234.0 --maxSteps=2 
runTheMatrix.py -w upgrade -l 28234.0 --maxSteps=2 
runTheMatrix.py -w upgrade -l 31434.0 --maxSteps=2
runTheMatrix.py -w upgrade -l 35034.0 --maxSteps=2
runTheMatrix.py -w upgrade -l 38634.0 --maxSteps=2

cmsbuild · 2022-05-01T09:54:21Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37758/29633

This PR adds an extra 24KB to repository

cmsbuild · 2022-05-01T09:54:43Z

A new Pull Request was created by @jbsauvan (Jean-Baptiste Sauvan) for master.

It involves the following packages:

L1Trigger/L1THGCal (upgrade, l1)

@rekovic, @epalencia, @cmsbuild, @AdrianoDee, @srimanob, @cecilecaillol can you please review it and eventually sign? Thanks.
@lgray, @Martin-Grunewald, @missirol, @trtomei, @amarini, @beaucero this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

AdrianoDee · 2022-05-02T07:21:56Z

test parameters:

workflows = 23234.0,28234.0,31434.0,35034.0,38634.0
relvals_opt= -w standard,highstats,pileup,generator,extendedgen,production,upgrade,cleanedupgrade,ged

AdrianoDee · 2022-05-02T07:22:24Z

please test

cmsbuild · 2022-05-02T11:54:01Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c1cf59/24369/summary.html
COMMIT: 279e17f
CMSSW: CMSSW_12_4_X_2022-05-01-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37758/24369/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-c1cf59/31434.0_TTbar_14TeV+2026D68+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

Summary:

No significant changes to the logs found
Reco comparison results: 6 differences found in the comparisons
DQMHistoTests: Total files compared: 51
DQMHistoTests: Total histograms compared: 3915231
DQMHistoTests: Total failures: 14
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3915195
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
Checked 213 log files, 45 edm output root files, 51 DQM output files
TriggerResults: found differences in 1 / 50 workflows

cecilecaillol · 2022-05-03T16:33:07Z

+l1

AdrianoDee · 2022-05-04T11:28:54Z

+upgrade

tests run with no issue or difference;
implement multiple wps through a simple WorkingPoint class.

cmsbuild · 2022-05-04T11:29:11Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2022-05-04T15:15:39Z

L1Trigger/L1THGCal/plugins/backend/HGCalTriggerClusterIdentificationBDT.cc

    throw cms::Exception("HGCalTriggerClusterIdentificationBDT|BadInitialization")
        << "Inconsistent numbers of categories, BDT weight files and working points";
  }
-  categories_.reserve(working_points_.size());
-  bdts_.reserve(working_points_.size());
+


To improve readability, what about definining here an, e..g.

size_t categories_size = categories_etamin.size();

and use if in the following instead of categories_etamin.size() repeatedly?

cmsbuild · 2022-05-05T11:28:03Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37758/29733

This PR adds an extra 16KB to repository

cmsbuild · 2022-05-05T11:28:25Z

Pull request #37758 was updated. @rekovic, @epalencia, @cmsbuild, @AdrianoDee, @srimanob, @cecilecaillol can you please check and sign again.

perrotta · 2022-05-05T12:18:54Z

please test

cmsbuild · 2022-05-05T16:37:54Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c1cf59/24471/summary.html
COMMIT: 9a3116b
CMSSW: CMSSW_12_4_X_2022-05-04-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37758/24471/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-c1cf59/31434.0_TTbar_14TeV+2026D68+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 51
DQMHistoTests: Total histograms compared: 3912843
DQMHistoTests: Total failures: 7
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 3912813
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.004 KiB( 50 files compared)
DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
Checked 214 log files, 45 edm output root files, 51 DQM output files
TriggerResults: found differences in 1 / 50 workflows

AdrianoDee · 2022-05-09T09:50:29Z

+upgrade

cecilecaillol · 2022-05-10T10:35:55Z

+l1

cmsbuild · 2022-05-10T10:36:13Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2022-05-10T12:08:03Z

+1

implement multiple working points in ID

279e17f

cmsbuild added this to the CMSSW_12_4_X milestone May 1, 2022

cmsbuild added code-checks-pending l1-pending orp-pending pending-signatures tests-pending upgrade-pending labels May 1, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels May 1, 2022

cmsbuild added tests-started and removed tests-pending labels May 2, 2022

cmsbuild added tests-approved and removed tests-started labels May 2, 2022

cmsbuild added l1-approved and removed l1-pending labels May 3, 2022

cmsbuild added fully-signed upgrade-approved and removed pending-signatures upgrade-pending labels May 4, 2022

perrotta reviewed May 4, 2022

View reviewed changes

jbsauvan added a commit to jbsauvan/cmssw that referenced this pull request May 5, 2022

comments PR cms-sw#37758

70db7d8

cmsbuild added code-checks-approved and removed code-checks-pending labels May 5, 2022

cmsbuild added tests-started and removed tests-pending labels May 5, 2022

cerminar mentioned this pull request May 5, 2022

Fixes and improvements for Layer-2 e/g objects and quality bits in the endcap p2l1pfp/cmssw#91

Merged

cmsbuild added tests-approved and removed tests-started labels May 5, 2022

cmsbuild added upgrade-approved and removed upgrade-pending labels May 9, 2022

cerminar pushed a commit to cerminar/cmssw that referenced this pull request May 9, 2022

comments PR cms-sw#37758

a25554f

cmsbuild added fully-signed l1-approved and removed l1-pending pending-signatures labels May 10, 2022

cmsbuild added orp-approved and removed orp-pending labels May 10, 2022

cmsbuild merged commit cda40b4 into cms-sw:master May 10, 2022

jbsauvan mentioned this pull request May 10, 2022

Implemented multiple working point ID upstream hgc-tpg/cmssw#37

Closed

This was referenced May 10, 2022

Addition of moduleType variable in tracking NTuple #37893

Merged

Update SCRAM and build rules cms-sw/cmsdist#7851

Merged

Particle flow identification of electrons in extended eta #37880

Merged

cerminar pushed a commit to cerminar/cmssw that referenced this pull request May 11, 2022

comments PR cms-sw#37758

30bf645

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

implement multiple working points in ID for e/g triggers based on HGCAL clusters #37758

implement multiple working points in ID for e/g triggers based on HGCAL clusters #37758

jbsauvan commented May 1, 2022

cmsbuild commented May 1, 2022

cmsbuild commented May 1, 2022

AdrianoDee commented May 2, 2022

AdrianoDee commented May 2, 2022

cmsbuild commented May 2, 2022

cecilecaillol commented May 3, 2022

AdrianoDee commented May 4, 2022

cmsbuild commented May 4, 2022

perrotta May 4, 2022

cmsbuild commented May 5, 2022

cmsbuild commented May 5, 2022

perrotta commented May 5, 2022

cmsbuild commented May 5, 2022

AdrianoDee commented May 9, 2022

cecilecaillol commented May 10, 2022

cmsbuild commented May 10, 2022

perrotta commented May 10, 2022

implement multiple working points in ID for e/g triggers based on HGCAL clusters #37758

implement multiple working points in ID for e/g triggers based on HGCAL clusters #37758

Conversation

jbsauvan commented May 1, 2022

PR description:

PR validation:

cmsbuild commented May 1, 2022

cmsbuild commented May 1, 2022

AdrianoDee commented May 2, 2022

AdrianoDee commented May 2, 2022

cmsbuild commented May 2, 2022

Comparison Summary

cecilecaillol commented May 3, 2022

AdrianoDee commented May 4, 2022

cmsbuild commented May 4, 2022

perrotta May 4, 2022

Choose a reason for hiding this comment

cmsbuild commented May 5, 2022

cmsbuild commented May 5, 2022

perrotta commented May 5, 2022

cmsbuild commented May 5, 2022

Comparison Summary

AdrianoDee commented May 9, 2022

cecilecaillol commented May 10, 2022

cmsbuild commented May 10, 2022

perrotta commented May 10, 2022