Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move modules to be thread_unsafe::DQMEDAnalyzers #3777

Merged
merged 26 commits into from May 9, 2014

Conversation

deguio
Copy link
Contributor

@deguio deguio commented May 9, 2014

this PR supersedes #3730

@deguio deguio mentioned this pull request May 9, 2014
@deguio
Copy link
Contributor Author

deguio commented May 9, 2014

hello @rociovilar
please have a look at the changes I have made on top of yours. In some cases I have removed the endJob which is a transition which is not triggered anymore in stream::EDAnalyzers. I don't think I have altered any functionality.

waiting for the tests to approve this one.
thanks,
F.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2014

A new Pull Request was created by @deguio for CMSSW_7_1_X.

move modules to be thread_unsafe::DQMEDAnalyzers

It involves the following packages:

DQM/PhysicsHWW
DQMOffline/Trigger
Validation/MuonIdentification
Validation/MuonIsolation
Validation/RecoMuon

@ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2014

@deguio
Copy link
Contributor Author

deguio commented May 9, 2014

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

nclopezo added a commit that referenced this pull request May 9, 2014
DQMEDAnalyzers -- move modules to be thread_unsafe::DQMEDAnalyzers
@nclopezo nclopezo merged commit 250f017 into cms-sw:CMSSW_7_1_X May 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants