Added IOV synchronization callbacks to ActivityRegistry

[Dr15Jones]

PR description:

• Can now follow when EventSetup is attempting to synchronize its Records
• Extended the Tracer service to use new callbacks

PR validation:

Code compiles. All framework unit tests pass.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37771/29665

• This PR adds an extra 92KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File FWCore/Framework/src/EventProcessor.cc modified in PR(s): Improve IndexIntoFile for concurrent lumis/runs #37532

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37771/29665/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37771/29665/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37771/29666

• This PR adds an extra 92KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File FWCore/Framework/src/EventProcessor.cc modified in PR(s): Improve IndexIntoFile for concurrent lumis/runs #37532

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

• FWCore/Framework (core)
• FWCore/Integration (core)
• FWCore/ServiceRegistry (core)
• FWCore/Services (core)

@cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please review it and eventually sign? Thanks.
@makortel, @wddgit, @fwyzard this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

Please test

[cmsbuild]

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-127e95/24397/summary.html
COMMIT: d610b60
CMSSW: CMSSW_12_4_X_2022-05-02-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37771/24397/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @kpedro88 Puppi speedup: use reserve for vectors #37717
• @cms-tsg-storm HLT menu development for 12_3_X [12_4_X] #37754
• @Dr15Jones Changed CSCRecoBadChannelsAnalyzer to be a one::EDAnalyzer #37751
• @drkovalskyi added NanoAOD to PromptReco #37728
• @Dr15Jones Fixed deprecation warnings in RecoLocalMuon/CSCSegment #37750
• @Dr15Jones Fixed deprecation warnings in CSCEfficiency #37748
• @radla118 Modifying the AlcaPCCIntegrator for processing concurrent lumiblocks #37538
• @Dr15Jones Fixed CMS deprecation warnings in CommonTools/ParticleFlow #37746
• @bsunanda Phase2-hgx310C Add in line documentation to some service methods in Geometry/HGCalCommonData #37759
• @esiam JME DQM updates for Run3 (12_4_X) #37725

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-127e95/24397/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-127e95/24397/git-merge-result

Build

I found compilation error when building:

>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_4_X_2022-05-02-1100/src/RecoMuon/MuonIdentification/plugins/MuonsFromRefitTracksProducer.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_4_X_2022-05-02-1100/src/RecoMuon/MuonIdentification/plugins/TrajectorySeedFromMuonProducer.cc
>> Building  edm plugin tmp/slc7_amd64_gcc10/src/RecoMuon/MuonIdentification/plugins/RecoMuonMuonIdentificationPlugins/libRecoMuonMuonIdentificationPlugins.so
/cvmfs/cms-ib.cern.ch/nweek-02731/slc7_amd64_gcc10/external/gcc/10.3.0-84898dea653199466402e67d73657f10/bin/../lib/gcc/x86_64-unknown-linux-gnu/10.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: tmp/slc7_amd64_gcc10/src/RecoMuon/MuonIdentification/plugins/RecoMuonMuonIdentificationPlugins/Module.cc.o: in function `VersionedSelector >::VersionedSelector(edm::ParameterSet const&)':
Module.cc:(.text._ZN17VersionedSelectorIN3edm3PtrIN4reco4MuonEEEEC2ERKNS0_12ParameterSetE[_ZN17VersionedSelectorIN3edm3PtrIN4reco4MuonEEEEC5ERKNS0_12ParameterSetE]+0x189): undefined reference to `cms::openssl_init()'
collect2: error: ld returned 1 exit status
gmake: *** [tmp/slc7_amd64_gcc10/src/RecoMuon/MuonIdentification/plugins/RecoMuonMuonIdentificationPlugins/libRecoMuonMuonIdentificationPlugins.so] Error 1
Leaving library rule at src/RecoMuon/MuonIdentification/plugins
Entering library rule at src/RecoMuon/MuonIdentification/plugins
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_4_X_2022-05-02-1100/src/RecoMuon/MuonIdentification/plugins/cuts/GlobalMuonPromptTightCut.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_4_X_2022-05-02-1100/src/RecoMuon/MuonIdentification/plugins/cuts/MuonDxyCut.cc


[Dr15Jones]

Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-127e95/24412/summary.html
COMMIT: d610b60
CMSSW: CMSSW_12_4_X_2022-05-03-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37771/24412/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3700548
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3700518
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 205 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[makortel]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1