More clang fixes. #3778
More clang fixes. #3778
Conversation
| @@ -37,13 +37,13 @@ GlobalError GetLineCovMatrix::GetMatrix(GlobalPoint PointThree) | |||
| { | |||
| // the linear equation is K = PointOne + (PointTwo-PointOne)*s | |||
| double s; | |||
| if( !fabs(PointTwo.x() - PointOne.x()) < 0.00000001 ) | |||
There was a problem hiding this comment.
Logic changes. I assume this is what was meant to begin with.
|
A new Pull Request was created by @ktf (Giulio Eulisse) for CMSSW_7_1_X. More clang fixes. It involves the following packages: DataFormats/ParticleFlowCandidate @civanch, @ojeda, @danduggan, @mdhildreth, @monttj, @cmsbuild, @anton-a, @thspeer, @rovere, @deguio, @slava77, @vadler, @Degano, @nclopezo can you please review it and eventually sign? Thanks. |
|
+1 |
|
-1 from /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-05-08-0200/src/DataFormats/TrackReco/interface/TrackBase.h:56,
from /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-05-08-0200/src/DataFormats/TrackReco/interface/Track.h:19,
from /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-05-08-0200/src/DataFormats/GsfTrackReco/interface/GsfTrack.h:6,
from /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-05-08-0200/src/TrackingTools/GsfTracking/interface/GsfConstraintAtVertex.h:3,
from /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-05-08-0200/src/TrackingTools/GsfTracking/src/GsfConstraintAtVertex.cc:1:
/build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-05-08-0200/src/DataFormats/TrackingRecHit/interface/TrackingRecHit.h:174:28: error: 'virtual TrackingRecHit\* TrackingRecHit::clone(const TkCloner&, const TrajectoryStateOnSurface&) const' is private
virtual TrackingRecHit \* clone(TkCloner const&, TrajectoryStateOnSurface const&) const {
^
In file included from /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-05-08-0200/src/TrackingTools/GsfTracking/interface/GsfConstraintAtVertex.h:14:0,
from /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-05-08-0200/src/TrackingTools/GsfTracking/src/GsfConstraintAtVertex.cc:1:
/build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-05-08-0200/src/RecoTracker/TransientTrackingRecHit/interface/TRecHit2DPosConstraint.h:9:7: error: within this context
you can see the results of the tests here: |
|
+1 |
|
I had to rebase. |
|
Bypassing simulation. @mdhildreth @civanch, complain if not ok. |
|
+1 |
This fixes more clang issues. Many of them are simple changes, however there is a few that are genuine bugs and that could affect results if the code is actually triggered.