Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CSCCluster skim config #37782

Merged
merged 5 commits into from Jul 21, 2022
Merged

Add CSCCluster skim config #37782

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3515db5
Add CSCCluster skim config
May 2, 2022
519131c
Add CSC, DT rechits
May 3, 2022
51a56b3
update test script
May 3, 2022
9836662
get output commands from python script
Jun 20, 2022
c0a4dba
update datatier
Jul 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 14 additions & 0 deletions Configuration/Skimming/python/PDWG_EXOCSCCluster_cff.py
View file
Open in desktop
@@ -0,0 +1,14 @@
import FWCore.ParameterSet.Config as cms

import HLTrigger.HLTfilters.hltHighLevel_cfi
CSCClusterTrigger = HLTrigger.HLTfilters.hltHighLevel_cfi.hltHighLevel.clone()
CSCClusterTrigger.TriggerResultsTag = cms.InputTag( "TriggerResults", "", "HLT" )
CSCClusterTrigger.HLTPaths = cms.vstring(
["*CscCluster*","*L1CSCShower*"]
)
CSCClusterTrigger.throw = False
CSCClusterTrigger.andOr = True
Comment on lines +4 to +10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not for this PR, but for a possible cleaning in another PR:

Suggested change
CSCClusterTrigger = HLTrigger.HLTfilters.hltHighLevel_cfi.hltHighLevel.clone()
CSCClusterTrigger.TriggerResultsTag = cms.InputTag( "TriggerResults", "", "HLT" )
CSCClusterTrigger.HLTPaths = cms.vstring(
["*CscCluster*","*L1CSCShower*"]
)
CSCClusterTrigger.throw = False
CSCClusterTrigger.andOr = True
CSCClusterTrigger = HLTrigger.HLTfilters.hltHighLevel_cfi.hltHighLevel.clone(
TriggerResultsTag = ( "TriggerResults", "", "HLT" ),
HLTPaths = ["*CscCluster*","*L1CSCShower*"],
throw = False,
andOr = True
)


EXOCSCClusterSkimSequence = cms.Sequence(
CSCClusterTrigger
)
12 changes: 12 additions & 0 deletions Configuration/Skimming/python/Skims_PDWG_cff.py
View file
Open in desktop
Expand Up @@ -282,6 +282,18 @@
dataTier = cms.untracked.string('AOD')
)

from Configuration.Skimming.PDWG_EXOCSCCluster_cff import *
EXOCSCClusterPath = cms.Path(EXOCSCClusterSkimSequence)
SKIMStreamEXOCSCCluster = cms.FilteredStream(
responsible = 'PDWG',
name = 'EXOCSCCluster',
paths = (EXOCSCClusterPath),
content = skimRawAODContent.outputCommands+['keep *_csc2DRecHits_*_*','keep *_dt1DRecHits_*_*'],
selectEvents = cms.untracked.PSet(),
dataTier = cms.untracked.string('AOD')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it doesn't seem that "AOD" is the correct data tier for this event content...

Also by changing skimRawAODContent here, you change it for everyone. If that is intended, the additional keep statements should go instead into Configuration.Skimming.PDWG_cff.py

Copy link
Contributor Author

@kakwok kakwok Jun 20, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'm just taking the value of skimRawAODContent output command and adding the extra collections that I need here, which shouldn't change what's in skimRawAODContent for everyone?
What should I put for the data tier here then?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah. - yes, you are correct I agree. I'm not sure what naming convention is being followed for raw+aod skims. (Hopefully it is not AOD)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed the convention in this PR (similar skim for DTClusters):
https://github.com/cms-sw/cmssw/pull/37509/files

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kskovpen so it this really supposed to be AOD after all?

Copy link
Contributor

@sam7k9621 sam7k9621 Jul 20, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it can be modified as "USER" to follow EXODisplacedJet

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(hmm it's not supposed to be my business, but since I'm following the PR...) isnt USER only meant for private productions from the users? I saw the other skims mostly use RAW-RECO, why shouldnt this use that too?

Copy link
Contributor

@sam7k9621 sam7k9621 Jul 20, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my understanding, different “types” only affect how it will be categorized in the DAS.
Since it shares the same content with EXODisplacedJet, I think we can follow the settings

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this should be USER, it's AOD with customized event content.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kakwok please modify it to USER then

)


from Configuration.Skimming.PDWG_EXODisappTrk_cff import *
EXODisappTrkPath = cms.Path(EXODisappTrkSkimSequence)
SKIMStreamEXODisappTrk = cms.FilteredStream(
Expand Down