(DAQ, DQM) FileSaverPB fix when exception is thrown (12_3_X)

[smorovic]

PR description:

Get abort flag by the DQMFileSaverPB, to avoids writing out files when
exception is thrown. Fix is necessary for correct functioning of output merging in HLT and aligns behavior of DQMHistograms stream with other output streams.
DQMFileSaver behaved as described, but not the new module.

PR validation:

Patch has been tested in DAQ test environment with HLT processes throwing exception.

if this PR is a backport please specify the original PR and why you need to backport that PR:

backport of #37830

[cmsbuild]

A new Pull Request was created by @smorovic (Srecko Morovic) for CMSSW_12_3_X.

It involves the following packages:

• DQMServices/FileIO (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@barvic this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

• Backported from (DAQ, DQM) FileSaverPB fix when exception is thrown #37830

[smorovic]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0cecb5/24503/summary.html
COMMIT: 1def761
CMSSW: CMSSW_12_3_X_2022-05-06-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37843/24503/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3696087
• DQMHistoTests: Total failures: 13
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3696051
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 48 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 204 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[emanueleusai]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

backport of #37830

[perrotta]

+1

• Merged in master since CMSSW_12_4_X_2022-05-08-2300