Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AlCaNano and inherit AlCaPhiSymEcal_Nano from it #37854

Merged
merged 1 commit into from May 8, 2022

Conversation

tvami
Copy link
Contributor

@tvami tvami commented May 7, 2022

PR description:

Follow-up to dmwm/T0#4664 (comment)
Inheriting from the AlCa scenario does not allow us to costumize the RECO step
while inheriting from the pp scenario forces to use the DQM step. This apparently cannot be switched off in the T0 config. So now I introduce AlCaNano and inherit AlCaPhiSymEcal_Nano from it.

PR validation:

 python3 Configuration/DataProcessing/test/RunPromptReco.py --scenario AlCaPhiSymEcal_Nano --reco --global-tag 123X_dataRun3_Prompt_v6 --lfn=file:/eos/cms/tier0/store/backfill/1/data/Tier0_REPLAY_2022/AlCaPhiSym/RAW/v91/000/346/512/00000/4887980a-dac3-48e0-be08-d99284f75c5b.root --alcareco EcalPhiSymByRun

Retrieved Scenario: AlCaPhiSymEcal_Nano
Using Global Tag: 123X_dataRun3_Prompt_v6
Configuring to Write out RECO
Configuring to Write out ALCARECO
[{'dataTier': 'RECO', 'eventContent': 'RECO', 'moduleLabel': 'write_RECO'}, {'dataTier': 'ALCARECO', 'eventContent': 'ALCARECO', 'moduleLabel': 'write_ALCARECO'}]
['Calibration/EcalCalibAlgos/EcalPhiSymRecoSequence_cff.customise']
Step: RECO Spec: ['bunchSpacingProducer', 'ecalMultiFitUncalibRecHitTask', 'ecalCalibratedRecHitTask']
Step: ALCAPRODUCER Spec: ['EcalPhiSymByRun']
customising the process with customise from Calibration/EcalCalibAlgos/EcalPhiSymRecoSequence_cff
Now do:
cmsRun -e RunPromptRecoCfg.py
07-May-2022 15:46:13 CEST  Initiating request to open file file:/eos/cms/tier0/store/backfill/1/data/Tier0_REPLAY_2022/AlCaPhiSym/RAW/v91/000/346/512/00000/4887980a-dac3-48e0-be08-d99284f75c5b.root
07-May-2022 15:46:16 CEST  Successfully opened file file:/eos/cms/tier0/store/backfill/1/data/Tier0_REPLAY_2022/AlCaPhiSym/RAW/v91/000/346/512/00000/4887980a-dac3-48e0-be08-d99284f75c5b.root
Begin processing the 1st record. Run 346512, Event 387150, LumiSection 1 on stream 0 at 07-May-2022 15:46:41.306 CEST
Begin processing the 2nd record. Run 346512, Event 683762, LumiSection 1 on stream 0 at 07-May-2022 15:46:42.515 CEST
Begin processing the 3rd record. Run 346512, Event 749995, LumiSection 1 on stream 0 at 07-May-2022 15:46:42.515 CEST
Begin processing the 4th record. Run 346512, Event 688096, LumiSection 1 on stream 0 at 07-May-2022 15:46:42.516 CEST
Begin processing the 5th record. Run 346512, Event 181224, LumiSection 1 on stream 0 at 07-May-2022 15:46:42.517 CEST
Begin processing the 6th record. Run 346512, Event 487945, LumiSection 1 on stream 0 at 07-May-2022 15:46:42.517 CEST
Begin processing the 7th record. Run 346512, Event 630492, LumiSection 1 on stream 0 at 07-May-2022 15:46:42.517 CEST
Begin processing the 8th record. Run 346512, Event 649218, LumiSection 1 on stream 0 at 07-May-2022 15:46:42.518 CEST
Begin processing the 9th record. Run 346512, Event 451961, LumiSection 1 on stream 0 at 07-May-2022 15:46:42.518 CEST
Begin processing the 10th record. Run 346512, Event 453408, LumiSection 1 on stream 0 at 07-May-2022 15:46:42.519 CEST
07-May-2022 15:46:43 CEST  Closed file file:/eos/cms/tier0/store/backfill/1/data/Tier0_REPLAY_2022/AlCaPhiSym/RAW/v91/000/346/512/00000/4887980a-dac3-48e0-be08-d99284f75c5b.root

=============================================

MessageLogger Summary

 type     category        sev    module        subroutine        count    total
 ---- -------------------- -- ---------------- ----------------  -----    -----
    1 fileAction           -s file_close                             1        1
    2 fileAction           -s file_open                              2        2

 type    category    Examples: run/evt        run/evt          run/evt
 ---- -------------------- ---------------- ---------------- ----------------
    1 fileAction           End Run: 346512                   
    2 fileAction           pre-events       pre-events       

Severity    # Occurrences   Total Occurrences
--------    -------------   -----------------
System                  3                   3

dropped waiting message count 0

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport to 12_3_X will be submitted after T0 replay with the 12_4_0_pre4

@tvami
Copy link
Contributor Author

tvami commented May 7, 2022

assign alca

@tvami
Copy link
Contributor Author

tvami commented May 7, 2022

atn @simonepigazzini @jhonatanamado

@tvami
Copy link
Contributor Author

tvami commented May 7, 2022

type ecal

@cmsbuild cmsbuild added the ecal label May 7, 2022
@tvami
Copy link
Contributor Author

tvami commented May 7, 2022

@cmsbuild , please test

@tvami
Copy link
Contributor Author

tvami commented May 7, 2022

urgent

  • need it to go into 12_4_0_pre4 for a further (limited) T0 replay

@cmsbuild cmsbuild added the urgent label May 7, 2022
@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37854/29788

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2022

New categories assigned: alca

@yuanchao,@francescobrivio,@malbouis,@tvami you have been requested to review this Pull request/Issue and eventually sign? Thanks

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2022

A new Pull Request was created by @tvami (Tamas Vami) for master.

It involves the following packages:

  • Configuration/DataProcessing (operations)

@perrotta, @malbouis, @yuanchao, @tvami, @qliphy, @davidlange6, @fabiocos, @francescobrivio can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8d5197/24517/summary.html
COMMIT: 224bf0c
CMSSW: CMSSW_12_4_X_2022-05-07-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37854/24517/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3701451
  • DQMHistoTests: Total failures: 13
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3701415
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 206 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor Author

tvami commented May 7, 2022

+alca

@perrotta
Copy link
Contributor

perrotta commented May 8, 2022

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants