Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLT menu development for 12_3_X + deprecation of customizeHLTforPatatrack functions #37865

Merged
merged 1 commit into from May 10, 2022

Conversation

missirol
Copy link
Contributor

@missirol missirol commented May 9, 2022

backport of #37862

PR description:

Development of HLT menus for CMSSW_12_3_X.

Includes the integration of the following JIRA tickets.

  • CMSHLT-2298: [TSG] Update of GPU-related modules in the HLT combined table (use only EDAliases inside SwitchProducers)

This PR also empties [*] the Patatrack customisation functions for HLT. After the integration of CMSHLT-2288, those customisations are not needed anymore. In 12_3_X, it was preferred to keep the functions around to minimise the chance of breaking workflows not maintained by HLT. The functions are considered deprecated, and a warning is issued accordingly (cc: @fwyzard).

[*] This implies that this PR is not an exact backport of #37862.

PR validation:

TSG tests.

If this PR is a backport, please specify the original PR and why you need to backport that PR:

#37862

Development of HLT menus for Run-3 startup.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2022

A new Pull Request was created by @missirol (Marino Missiroli) for CMSSW_12_3_X.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor Author

missirol commented May 9, 2022

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b6181b/24540/summary.html
COMMIT: 967ef2a
CMSSW: CMSSW_12_3_X_2022-05-09-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37865/24540/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3696081
  • DQMHistoTests: Total failures: 13
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3696045
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@missirol missirol changed the title HLT menu development for 12_3_X HLT menu development for 12_3_X + deprecation of customizeHLTforPatatrack functions May 9, 2022
@missirol
Copy link
Contributor Author

missirol commented May 9, 2022

+hlt

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2022

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented May 10, 2022

+1

@cmsbuild cmsbuild merged commit 72d598f into cms-sw:CMSSW_12_3_X May 10, 2022
@missirol missirol deleted the HLTdevelopment123X branch May 12, 2022 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants