Phase2-hgx312 Add dd4hep version of DDHGCalSiliconRotatedModule and add the v17 version full silicon layers of HE part of HGCal #37897

bsunanda · 2022-05-11T03:02:53Z

PR description:

Add dd4hep version of DDHGCalSiliconRotatedModule and add the v17 version full silicon layers of HE part of HGCal

PR validation:

Use the cfg's in Geometry/HGCalCommonData/test/python

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

…sion full silicon layers of HE part of HGCal

cmsbuild · 2022-05-11T03:09:42Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37897/29907

This PR adds an extra 80KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37897/29907/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37897/29907/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

bsunanda · 2022-05-11T03:21:11Z

@cmsbuild Please test

cmsbuild · 2022-05-11T03:27:17Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37897/29909

This PR adds an extra 80KB to repository

cmsbuild · 2022-05-11T03:27:39Z

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

Geometry/HGCalCommonData (geometry, upgrade)

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks.
@trtomei, @beaucero, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2022-05-11T07:20:19Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fbf5df/24600/summary.html
COMMIT: 2c5af3d
CMSSW: CMSSW_12_4_X_2022-05-10-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37897/24600/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3696633
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3696609
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 206 log files, 45 edm output root files, 49 DQM output files
TriggerResults: no differences found

cmsbuild · 2022-05-12T01:56:52Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37897/29959

This PR adds an extra 84KB to repository

cmsbuild · 2022-05-12T01:57:11Z

Pull request #37897 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please check and sign again.

bsunanda · 2022-05-12T02:03:25Z

@cmsbuild Please test

cmsbuild · 2022-05-12T08:49:42Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fbf5df/24641/summary.html
COMMIT: 7ee01e9
CMSSW: CMSSW_12_4_X_2022-05-11-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37897/24641/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3697209
DQMHistoTests: Total failures: 8
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3697179
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 206 log files, 45 edm output root files, 49 DQM output files
TriggerResults: no differences found

bsunanda · 2022-05-12T15:02:21Z

@cvuosalo @civanch @srimanob Please approve this PR

bsunanda · 2022-05-13T01:01:40Z

@cvuosalo @civanch @srimanob Please approve this PR

srimanob · 2022-05-13T05:36:03Z

+Upgrade

bsunanda · 2022-05-13T13:41:18Z

@cvuosalo could you sign this for pre4

cvuosalo · 2022-05-13T16:31:11Z

+1

cmsbuild · 2022-05-13T16:31:35Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2022-05-14T13:35:34Z

Geometry/HGCalCommonData/plugins/dd4hep/DDHGCalSiliconRotatedModule.cc

+  std::vector<double> slopeT_;          // Slopes at the larger R
+  std::vector<double> zFrontT_;         // Starting Z values for the slopes
+  std::vector<double> rMaxFront_;       // Corresponding rMax's
+  std::vector<int> layerTypes_;         // Layer type (Centering, rotations..)


Since it is not obvious to me to understand it from the code: are really layerTipe_ and layerTypes_ different?
Any less ambiguous name for (at least) one of the two could not be invented?

They are indeed different - one rferes to all the layers and the other to the layer containing the wafer as described in the lfat file. May be we shall change one of the names in the next revision. Please merge this PR as it is.

perrotta · 2022-05-14T14:00:00Z

+1

Add dd4hep version of DDHGCalSiliconRotatedModule and add the v17 ver…

2ba05ec

…sion full silicon layers of HE part of HGCal

cmsbuild added this to the CMSSW_12_4_X milestone May 11, 2022

cmsbuild added code-checks-pending geometry-pending orp-pending pending-signatures tests-pending upgrade-pending labels May 11, 2022

cmsbuild added code-checks-rejected and removed code-checks-pending labels May 11, 2022

Code check

2c5af3d

cmsbuild added code-checks-pending and removed code-checks-rejected labels May 11, 2022

cmsbuild added tests-started and removed tests-pending labels May 11, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels May 11, 2022

cmsbuild added tests-approved and removed tests-started labels May 11, 2022

cmsbuild mentioned this pull request May 11, 2022

Phase2 hgx312B Add the remaining XML files needed to complete the definition of V17 of HGCal #37904

Closed

Bug fix by Pruthvi

0b786b8

cmsbuild added code-checks-pending tests-pending and removed tests-approved code-checks-approved labels May 11, 2022

Code check

7ee01e9

cmsbuild added code-checks-pending and removed code-checks-rejected labels May 12, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels May 12, 2022

cmsbuild added tests-started and removed tests-pending labels May 12, 2022

cmsbuild added tests-approved and removed tests-started labels May 12, 2022

cmsbuild added upgrade-approved and removed upgrade-pending labels May 13, 2022

cmsbuild added fully-signed geometry-approved and removed geometry-pending pending-signatures labels May 13, 2022

perrotta reviewed May 14, 2022

View reviewed changes

cmsbuild added orp-approved and removed orp-pending labels May 14, 2022

cmsbuild merged commit 8692305 into cms-sw:master May 14, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Phase2-hgx312 Add dd4hep version of DDHGCalSiliconRotatedModule and add the v17 version full silicon layers of HE part of HGCal #37897

Phase2-hgx312 Add dd4hep version of DDHGCalSiliconRotatedModule and add the v17 version full silicon layers of HE part of HGCal #37897

bsunanda commented May 11, 2022

cmsbuild commented May 11, 2022

bsunanda commented May 11, 2022

cmsbuild commented May 11, 2022

cmsbuild commented May 11, 2022

cmsbuild commented May 11, 2022

cmsbuild commented May 12, 2022

cmsbuild commented May 12, 2022

bsunanda commented May 12, 2022

cmsbuild commented May 12, 2022

bsunanda commented May 12, 2022

bsunanda commented May 13, 2022

srimanob commented May 13, 2022

bsunanda commented May 13, 2022

cvuosalo commented May 13, 2022

cmsbuild commented May 13, 2022

perrotta May 14, 2022

bsunanda May 14, 2022

perrotta commented May 14, 2022

Phase2-hgx312 Add dd4hep version of DDHGCalSiliconRotatedModule and add the v17 version full silicon layers of HE part of HGCal #37897

Phase2-hgx312 Add dd4hep version of DDHGCalSiliconRotatedModule and add the v17 version full silicon layers of HE part of HGCal #37897

Conversation

bsunanda commented May 11, 2022

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented May 11, 2022

bsunanda commented May 11, 2022

cmsbuild commented May 11, 2022

cmsbuild commented May 11, 2022

cmsbuild commented May 11, 2022

Comparison Summary

cmsbuild commented May 12, 2022

cmsbuild commented May 12, 2022

bsunanda commented May 12, 2022

cmsbuild commented May 12, 2022

Comparison Summary

bsunanda commented May 12, 2022

bsunanda commented May 13, 2022

srimanob commented May 13, 2022

bsunanda commented May 13, 2022

cvuosalo commented May 13, 2022

cmsbuild commented May 13, 2022

perrotta May 14, 2022

Choose a reason for hiding this comment

bsunanda May 14, 2022

Choose a reason for hiding this comment

perrotta commented May 14, 2022