RPC DQM updates for Run3

[minerva1993]

PR description:

Update of RPC DQM

• remove histograms (ClusterSize 1D MEs / from summary folders, RPCChamberQuality, ClusterSizeIn1Bin and some other 1D distributions) - reducing DQM root file size by ~ 0.7 MB.
• Change of plot format: ClusterSize 1D ME (cluster size vs entries) to 2D (cluster size vs roll, z axis to be entries) ME
• Refine report summary map to present dead channel fraction correctly (instructions will be updated once related DQM GUI codes are updated)
• Added 'Noise summary map' for shifters (GUI will be modified as well)
• Bug fixes
• Delete unused and duplicated file
• Presented at RPC weekly meeting: https://indico.cern.ch/event/1156425/#5-rpc-status-for-the-dqm-shift

PR validation:

• Passed runTheMatrix.py -l limited -i all --ibeos ( May 11 13:05:11 2022-date Wed May 11 12:43:48 2022; exit: 0 0 0 0 0 // 48 47 46 35 18 4 1 1 1 1 tests passed, 0 0 0 0 0 0 0 0 0 0 failed)
• Passed scram b runtests, code-checks, code-format
• In addition, tested with Cosmic22 data (Run350561, 347945 with CMSSW_12_3_0 and 12_2_1_patch1 respectively, eg. [1])

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

[1] Commands: cmsDriver.py step1 --conditions 123X_dataRun3_Prompt_v6 -s RAW2DIGI,L1Reco,RECO,DQM --datatier RECO,DQMIO --eventcontent RECO,DQM --data --process reRECO --scenario cosmics --customise Configuration/DataProcessing/RecoTLR.customiseCosmicData --era Run3 -n -1 --filein="root://eoscms.cern.ch//eos/cms/tier0/store/data/Commissioning2022/Cosmics/RAW/v1/000/350/561/00000/438297ee-bc1f-4a5c-9a6c-bf4e6a427f8b.root"

cmsDriver.py step2 -s HARVESTING:@standardDQM --conditions 123X_dataRun3_Prompt_v6 --data --geometry DB:Extended --scenario cosmics --filetype DQM --era Run3 -n -1 --filein=file:step1_RAW2DIGI_L1Reco_RECO_DQM_inDQM.root

[cmsbuild]

@minerva1993, CMSSW_12_4_X branch is closed for direct updates. cms-bot is going to move this PR to master branch.
In future, please use cmssw master branch to submit your changes.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37902/29926

• This PR adds an extra 44KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37902/29926/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37902/29926/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37902/29928

• This PR adds an extra 44KB to repository

[minerva1993]

@ahmad3213 @emanueleusai @jfernan2 @pmandrik @micsucmed @rvenditti
Dear DQM experts, I would kindly ask you to start test and review for this PR on RPC DQM. Thanks in advance.

[pmandrik]

Hi, to test DQM RPC client at P5 a backport to CMSSW_12_3_X is needed

[cmsbuild]

A new Pull Request was created by @minerva1993 (Jiwon Park) for master.

It involves the following packages:

• DQM/Integration (dqm)
• DQM/RPCMonitorClient (dqm)
• DQM/RPCMonitorDigi (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@acimmino, @battibass, @threus, @batinkov, @francescobrivio this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[minerva1993]

Hi, to test DQM RPC client at P5 a backport to CMSSW_12_3_X is needed

Thanks @pmandrik , I created another PR (#37917 ).

[emanueleusai]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0809f2/24679/summary.html
COMMIT: 46e1cc5
CMSSW: CMSSW_12_4_X_2022-05-12-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37902/24679/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3618991
• DQMHistoTests: Total failures: 14
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3618955
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 2024.7790000000002 KiB( 48 files compared)
• DQMHistoSizes: changed ( 1000.0,... ): 4.691 KiB RPC/Muon
• DQMHistoSizes: changed ( 1000.0,... ): 2.046 KiB RPC/AllHits
• DQMHistoSizes: changed ( 1000.0,... ): 0.958 KiB RPC/EventInfo
• DQMHistoSizes: changed ( 10024.0,... ): 13.123 KiB RPC/Muon
• DQMHistoSizes: changed ( 10024.0,... ): 10.091 KiB RPC/AllHits
• DQMHistoSizes: changed ( 11634.0,... ): 61.076 KiB RPC/Muon
• DQMHistoSizes: changed ( 11634.0,... ): 58.100 KiB RPC/AllHits
• DQMHistoSizes: changed ( 23234.0,... ): 53.604 KiB RPC/Muon
• DQMHistoSizes: changed ( 23234.0,... ): 50.428 KiB RPC/AllHits
• Checked 206 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[emanueleusai]

testing backport at P5

[minerva1993]

testing backport at P5

Hello, any news here? Thanks in advance, J.

[emanueleusai]

+1

[emanueleusai]

tests completed successfully

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[minerva1993]

I understand deadline of pre-release is closed already. I just wonder if this PR can be backported to 12_4_X later, as it does not change any physics quantities but only DQM updates?

[qliphy]

I understand deadline of pre-release is closed already. I just wonder if this PR can be backported to 12_4_X later, as it does not change any physics quantities but only DQM updates?

@minerva1993 Such a DQM PR could be allowed. Please make a backport PR to 12_4_X then.

[qliphy]

+1