New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phase2-hgx312C Add two more xml files to complete the v17 definition of HGCal #37905
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37905/29934
|
A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master. It involves the following packages:
@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild Please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-63ee6c/24625/summary.html Comparison SummarySummary:
|
+1 |
@srimanob Please approve this PR |
+Upgrade Add needed XML files for V17 HGCal and adapt code to handle it. No change in PR expected. |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
@@ -8,7 +8,7 @@ | |||
#include "Geometry/HGCalCommonData/interface/HGCalGeometryMode.h" | |||
#include "Geometry/HGCalCommonData/interface/HGCalParameters.h" | |||
|
|||
//#define EDM_ML_DEBUG | |||
#define EDM_ML_DEBUG |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this expected to remain uncommented?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are testing next version. We shall comment them at that time. Please merge this so that we can move forward
+1 |
PR description:
Add the remaining two xml files to complete the v17 definition of HGCal
PR validation:
With 2 additional PR's #37897 and #37898 use the runTheMatrix test workflows for Phase2 geometry
if this PR is a backport please specify the original PR and why you need to backport that PR:
Nothing special