EMTF emulator update to add support for Run 3 BDT LUTs #37910

eyigitba · 2022-05-11T16:27:15Z

PR description:

This PR adds support for the new EMTF BDT training for the start of Run 3. The new LUTs are not yet ready, but once they are ready they will be assigned ptLUTVersion_ = 8 which will make the emulator use the correct functions for pT scaling and pT conversion.

There is no change in behaviour when using the older versions of pT LUTs.

PR validation:

Validated with runTheMatrix.py -l limited -i all --ibeos

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

verify that the PR is really intended for the chosen branch
verify that changes follow CMS Naming, Coding, And Style Rules
verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

@jrotter2

…on from BDT value to pT

eyigitba · 2022-05-11T16:28:53Z

urgent

cmsbuild · 2022-05-11T16:34:48Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37910/29939

This PR adds an extra 20KB to repository

cmsbuild · 2022-05-11T16:35:15Z

A new Pull Request was created by @eyigitba for master.

It involves the following packages:

L1Trigger/L1TMuonEndCap (l1)

@epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please review it and eventually sign? Thanks.
@dinyar, @missirol, @thomreis, @Martin-Grunewald this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

epalencia · 2022-05-11T16:49:05Z

Please test

cmsbuild · 2022-05-11T20:55:02Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-71d8e5/24631/summary.html
COMMIT: 2332f79
CMSSW: CMSSW_12_4_X_2022-05-11-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37910/24631/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3697209
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3697185
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 206 log files, 45 edm output root files, 49 DQM output files
TriggerResults: no differences found

cecilecaillol · 2022-05-12T07:26:43Z

+l1

cmsbuild · 2022-05-12T07:27:06Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2022-05-12T07:57:48Z

L1Trigger/L1TMuonEndCap/src/PtAssignmentEngine2017.cc

-  // First "physics" LUTs for 2017, deployed June 7
-  if (ptLUTVersion_ >= 6) {
-    pt_xml = fmin(20., pt);  // Maximum scale set by muons with XML pT = 20 GeV (scaled pT ~35 GeV)
+  if (ptLUTVersion_ > 7) {   // First "physics" LUTs for 2022, will be deployed in June 2022


My impression (it can be wrong) is that it would better jump to eyes which is the first LUT version to be considered here if you replace it with

Suggested change

if (ptLUTVersion_ > 7) { // First "physics" LUTs for 2022, will be deployed in June 2022

if (ptLUTVersion_ >= 8) { // First "physics" LUTs for 2022, will be deployed in June 2022

as you do in the other case for versions >= 6

If you agree, you can update (here and below). If not, just tell us, and this PR is otherwise ready to get merged

…ersion is the first LUT version for Run 3

eyigitba · 2022-05-12T08:30:55Z

@perrotta , I think this makes sense. I changed all of them to >= 8 for making it easier to read. Thanks!

cmsbuild · 2022-05-12T08:37:35Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37910/29966

This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37910/29966/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37910/29966/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2022-05-12T09:03:27Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37910/29968

This PR adds an extra 20KB to repository

cmsbuild · 2022-05-12T09:03:52Z

Pull request #37910 was updated. @epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please check and sign again.

epalencia · 2022-05-12T09:11:59Z

Please test

cmsbuild · 2022-05-12T12:57:54Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-71d8e5/24653/summary.html
COMMIT: facc229
CMSSW: CMSSW_12_4_X_2022-05-11-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37910/24653/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3697209
DQMHistoTests: Total failures: 8
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3697179
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 206 log files, 45 edm output root files, 49 DQM output files
TriggerResults: no differences found

cecilecaillol · 2022-05-12T15:09:11Z

+l1

cmsbuild · 2022-05-12T15:09:31Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2022-05-12T15:45:58Z

+1

Add support for Run 3 BDT LUTs. New scaling function and new conversi…

2332f79

…on from BDT value to pT

cmsbuild added this to the CMSSW_12_4_X milestone May 11, 2022

cmsbuild added code-checks-pending l1-pending orp-pending pending-signatures tests-pending labels May 11, 2022

cmsbuild added the urgent label May 11, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels May 11, 2022

cmsbuild added tests-started and removed tests-pending labels May 11, 2022

cmsbuild added tests-approved and removed tests-started labels May 11, 2022

cmsbuild added fully-signed l1-approved and removed l1-pending pending-signatures labels May 12, 2022

perrotta reviewed May 12, 2022

View reviewed changes

Change the if statements for ptLUTVersion_ so it's more clear which v…

d890d4c

…ersion is the first LUT version for Run 3

cmsbuild removed l1-approved fully-signed tests-approved labels May 12, 2022

cmsbuild added l1-pending pending-signatures tests-pending labels May 12, 2022

cmsbuild added code-checks-rejected and removed code-checks-pending labels May 12, 2022

code format

facc229

cmsbuild added code-checks-pending and removed code-checks-rejected labels May 12, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels May 12, 2022

cmsbuild added tests-started and removed tests-pending labels May 12, 2022

cmsbuild added tests-approved and removed tests-started labels May 12, 2022

cmsbuild added fully-signed l1-approved and removed l1-pending pending-signatures labels May 12, 2022

cmsbuild added orp-approved and removed orp-pending labels May 12, 2022

cmsbuild merged commit 45088d6 into cms-sw:master May 12, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

EMTF emulator update to add support for Run 3 BDT LUTs #37910

EMTF emulator update to add support for Run 3 BDT LUTs #37910

eyigitba commented May 11, 2022 •

edited

eyigitba commented May 11, 2022

cmsbuild commented May 11, 2022

cmsbuild commented May 11, 2022

epalencia commented May 11, 2022

cmsbuild commented May 11, 2022

cecilecaillol commented May 12, 2022

cmsbuild commented May 12, 2022

perrotta May 12, 2022

eyigitba commented May 12, 2022

cmsbuild commented May 12, 2022

cmsbuild commented May 12, 2022

cmsbuild commented May 12, 2022

epalencia commented May 12, 2022

cmsbuild commented May 12, 2022

cecilecaillol commented May 12, 2022

cmsbuild commented May 12, 2022

perrotta commented May 12, 2022

	if (ptLUTVersion_ > 7) { // First "physics" LUTs for 2022, will be deployed in June 2022
	if (ptLUTVersion_ >= 8) { // First "physics" LUTs for 2022, will be deployed in June 2022

EMTF emulator update to add support for Run 3 BDT LUTs #37910

EMTF emulator update to add support for Run 3 BDT LUTs #37910

Conversation

eyigitba commented May 11, 2022 • edited

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

eyigitba commented May 11, 2022

cmsbuild commented May 11, 2022

cmsbuild commented May 11, 2022

epalencia commented May 11, 2022

cmsbuild commented May 11, 2022

Comparison Summary

cecilecaillol commented May 12, 2022

cmsbuild commented May 12, 2022

perrotta May 12, 2022

Choose a reason for hiding this comment

eyigitba commented May 12, 2022

cmsbuild commented May 12, 2022

cmsbuild commented May 12, 2022

cmsbuild commented May 12, 2022

epalencia commented May 12, 2022

cmsbuild commented May 12, 2022

Comparison Summary

cecilecaillol commented May 12, 2022

cmsbuild commented May 12, 2022

perrotta commented May 12, 2022

eyigitba commented May 11, 2022 •

edited