Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean unused dependencies from BuildFiles #37915

Merged
merged 1 commit into from May 16, 2022
Merged

Clean unused dependencies from BuildFiles #37915

merged 1 commit into from May 16, 2022

Conversation

guitargeek
Copy link
Contributor

PR description:

Another quick BuildFile cleaning PR in the style of many before (for example #36834).

In many cases, the dependencies had to be moved to the appropriate BuildFile, for example from a plugins directory to the library directory or vice versa.

This PR cleans unnecessary includes from CMSSW BuildFiles that were added in the last months.

PR validation:

CMSSW compiles.

if this PR is a backport please specify the original PR and why you need to backport that PR:

No backport intended.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37915/29955

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @guitargeek (Jonas Rembser) for master.

It involves the following packages:

  • CUDADataFormats/TrackingRecHit (heterogeneous, reconstruction)
  • CalibTracker/SiStripDCS (alca)
  • CalibTracker/SiStripHitEfficiency (alca)
  • CalibTracker/SiStripQuality (alca)
  • Calibration/EcalCalibAlgos (alca)
  • CondFormats/SiStripObjects (db, alca)
  • DQM/GEM (dqm)
  • DataFormats/L1TMuonPhase2 (l1)
  • GeneratorInterface/ExternalDecays (generators)
  • GeneratorInterface/Hydjet2Interface (generators)
  • HeterogeneousCore/MPIServices (heterogeneous)
  • L1Trigger/DemonstratorTools (l1)
  • L1Trigger/L1THGCalUtilities (upgrade, l1)
  • L1Trigger/L1TTrackMatch (upgrade, l1)
  • L1Trigger/Phase2L1GMT (l1)
  • L1Trigger/Phase2L1Taus (l1)
  • L1Trigger/VertexFinder (l1)
  • RecoEgamma/EgammaTools (reconstruction)

@SiewYan, @jpata, @Saptaparna, @rekovic, @alberto-sanchez, @cecilecaillol, @yuanchao, @makortel, @ahmad3213, @cmsbuild, @fwyzard, @GurpreetSinghChahal, @pmandrik, @epalencia, @emanueleusai, @AdrianoDee, @jfernan2, @slava77, @ggovi, @micsucmed, @francescobrivio, @malbouis, @mkirsano, @clacaputo, @srimanob, @tvami, @rvenditti can you please review it and eventually sign? Thanks.
@erikbutz, @echabert, @jainshilpi, @pieterdavid, @robervalwalsh, @valsdav, @Martin-Grunewald, @trtomei, @jbsauvan, @thomreis, @alberto-sanchez, @threus, @varuns23, @seemasharmafnal, @makortel, @watson-ij, @lgray, @missirol, @simonepigazzini, @beaucero, @Sam-Harper, @eyigitba, @rovere, @VinInn, @tocheng, @mmusich, @argiro, @mkirsano, @rchatter, @gbenelli, @sobhatta, @afiqaize, @dinyar, @wrtabb, @amarini, @ram1123 this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@AdrianoDee
Copy link
Contributor

Please test

@fwyzard
Copy link
Contributor

fwyzard commented May 12, 2022

+heterogeneous

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-399f4f/24645/summary.html
COMMIT: 9cf9201
CMSSW: CMSSW_12_4_X_2022-05-11-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37915/24645/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3697209
  • DQMHistoTests: Total failures: 13
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3697173
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 206 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@AdrianoDee
Copy link
Contributor

+upgrade

@emanueleusai
Copy link
Member

+1

@tvami
Copy link
Contributor

tvami commented May 12, 2022

+1

  • technical PR

@SiewYan
Copy link
Contributor

SiewYan commented May 13, 2022

+1

@cecilecaillol
Copy link
Contributor

+l1

@jpata
Copy link
Contributor

jpata commented May 16, 2022

+reconstruction

  • technical

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet