Removed static from CachingSeedCleanerByHitPosition::good

[Dr15Jones]

The function local static was to a class with no member data and
no virtual functions. Since it had no state there was no need to make
it static and making it static meant the compiler had to use lots of
extra machine code. Removing the static and making it const makes the
code easier to reason about and avoids complaints from the static
analyzer.

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_1_X.

Removed static from CachingSeedCleanerByHitPosition::good

It involves the following packages:

RecoTracker/CkfPattern

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks.
@ghellwig, @GiacomoSguazzoni, @rovere, @gpetruc, @cerati, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[cmsbuild]

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3792/1426/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3792/1426/summary.html

[Dr15Jones]

@slava77 @anton-a ping?

[ktf]

Trivial, bypassing. Complain if not ok.

[slava77]

+1

for #3792 e08c4b1

tested in CMSSW_7_1_X_2014-05-12-0200 (test area sign369decB)
no changes observed in monitored quantities