Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12_2_X backport] fix in bc->e filter #37931

Merged
merged 2 commits into from May 17, 2022

Conversation

swagata87
Copy link
Contributor

PR description:

See details in PR description of #37869
This is an exact backport of 37869.
The backport is being made following a discussion in today's PPD meeting, during this talk:
https://indico.cern.ch/event/1158486/#30-retraining-of-pf-electron-i
The plan is that once this backport PR is merged and a new 12_2_X release is made, EGM will request QCD b/c->e samples again, in 12_2_X. With those samples, we will check the performance of DNN-based PF ID.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 12, 2022

A new Pull Request was created by @swagata87 (Swagata Mukherjee) for CMSSW_12_2_X.

It involves the following packages:

  • Configuration/Generator (generators)
  • GeneratorInterface/GenFilters (generators)

@SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @GurpreetSinghChahal, @alberto-sanchez can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @alberto-sanchez, @mkirsano, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@swagata87
Copy link
Contributor Author

backport of #37869

@SiewYan
Copy link
Contributor

SiewYan commented May 13, 2022

please test

@SiewYan
Copy link
Contributor

SiewYan commented May 13, 2022

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9541e5/24692/summary.html
COMMIT: bb59ada
CMSSW: CMSSW_12_2_X_2022-05-12-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37931/24692/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 3251324
  • DQMHistoTests: Total failures: 12
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3251290
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@swagata87
Copy link
Contributor Author

Hi generator experts,
is there anything else needed from our side about this PR?

@Saptaparna
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented May 17, 2022

+1

@cmsbuild cmsbuild merged commit a4df806 into cms-sw:CMSSW_12_2_X May 17, 2022
@qliphy qliphy mentioned this pull request May 18, 2022
@qliphy
Copy link
Contributor

qliphy commented May 18, 2022

@swagata87 CMSSW_12_2_4 is now ready: https://github.com/cms-sw/cmssw/releases/CMSSW_12_2_4

@swagata87
Copy link
Contributor Author

@swagata87 CMSSW_12_2_4 is now ready: https://github.com/cms-sw/cmssw/releases/CMSSW_12_2_4

Many thanks Qiang and Andrea.
This will be really helpful for our PF ID studies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants