New mva taggers backport from 71X to 53X #3795
Conversation
…opy in MVAComputer.cc
|
A new Pull Request was created by @pvmulder (Petra Van Mulders) for CMSSW_5_3_X. New mva taggers backport from 71X to 53X It involves the following packages: DataFormats/BTauReco @nclopezo, @monttj, @cmsbuild, @anton-a, @thspeer, @slava77, @vadler, @Degano can you please review it and eventually sign? Thanks. |
| @@ -21,3 +21,21 @@ | |||
| extSVDeltaRToJet = cms.double(0.3) | |||
|
|
|||
| ) | |||
|
|
|||
| secondaryVertexTagInfosV2 = cms.EDProducer("SecondaryVertexProducer", | |||
There was a problem hiding this comment.
@pvmulder To make things less error-prone, why not define this as
secondaryVertexTagInfosV2 = secondaryVertexTagInfos.clone()
secondaryVertexTagInfosV2.trackSelection.qualityClass = cms.string('any')Just a suggestion.
|
@pvmulder OK, looks good. The old CVS does not change its 53X behavior. The same can now be applied to 6_2_X_SLHC. Thanks |
| trackP0Par, // track momentum along the jet axis, in the jet rest frame | ||
| trackP0ParRatio, // track momentum along the jet axis, in the jet rest frame, normalized to its energy" | ||
| trackChi2, // track fit chi2 | ||
| trackNTotalHits, // number of valid total hits | ||
| trackNPixelHits, // number of valid pixel hits | ||
|
|
||
| chargedHadronEnergyFraction, // fraction of the jet energy coming from charged hadrons |
There was a problem hiding this comment.
@pvmulder This is a cosmetic detail and I did notice it before but why are all the descriptions no longer aligned. With GitHub's very strange choice of the visible line length, this issue becomes apparent.
There was a problem hiding this comment.
@ferencek This is a problem in my editor that is not well-configured. In my editor things seems perfectly aligned, but not in other editors.
There was a problem hiding this comment.
@pvmulder Maybe try with some other editor just for this file and TaggingVariable.cc. Otherwise, I can also easily fix it.
2 similar comments
|
+1 |
|
+1 |
|
@pvmulder Could you clarify about configuration files - I see no changes introduced in RecoBTag/SecondaryVertex/python/combinedSecondaryVertexCommon_cfi.py , RecoBTag/SecondaryVertex/python/trackPseudoSelection_cfi.py , RecoBTag/SecondaryVertex/python/trackSelection_cfi.py , RecoBTag/SecondaryVertex/python/vertexTrackSelection_cfi.py and this deviates from 71X PRs. Is it part of preserving "the standard CSV" behavior? |
|
@StoyanStoynev |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_5_3_X IBs unless changes or unless it breaks tests. @smuzaffar can you please take care of it? |
|
+tested |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_5_3_X IBs unless changes (tests are also fine). @smuzaffar can you please take care of it? |
…_71X_to_53X New mva taggers backport from 71X to 53X
Backport of the merged 71X pull requests:
#2622
#3384
#3664
#3733
but with changes in configuration files and CombinedSVComputer.cc to keep the standard CSV without a change