Phase2-gex134 Modify C17 to see the new numbering of HCAL #37951

bsunanda · 2022-05-15T12:38:37Z

PR description:

Modify C17 to see the new numbering of HCAL

PR validation:

Use the runTheMatrix test workflows

if this PR is a backport please specify the original PR and why you need to backport that PR:

othing special

bsunanda · 2022-05-15T12:38:59Z

@cmsbuild Please test

cmsbuild · 2022-05-15T12:44:32Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37951/30018

This PR adds an extra 28KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/Geometry/python/dict2026Geometry.py modified in PR(s): Drop tracker geometries T22,T23,T27,T28 - first commit #37874

cmsbuild · 2022-05-15T12:44:57Z

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

Configuration/Geometry (geometry, upgrade)
Geometry/CMSCommonData (geometry, upgrade)

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks.
@vargasa, @kpedro88, @fabiocos, @Martin-Grunewald, @missirol, @trtomei, @beaucero, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2022-05-15T16:48:36Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-46e449/24726/summary.html
COMMIT: 571f8b0
CMSSW: CMSSW_12_4_X_2022-05-15-0000/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37951/24726/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-46e449/11634.301_TTbar_14TeV+2021_Run3FS+TTbar_14TeV_TuneCP5_GenSim+HARVESTNano

Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3741432
DQMHistoTests: Total failures: 92
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3741318
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 208 log files, 45 edm output root files, 50 DQM output files
TriggerResults: no differences found

cvuosalo · 2022-05-16T17:03:31Z

+1

srimanob · 2022-05-16T17:21:37Z

Do we expect to see any changes in Phase-2 D88 in both DDD and DD4hep from this PR? Just to make sure to understand the effect of this PR. Thanks.

bsunanda · 2022-05-17T07:48:01Z

This make changes to some rare process. I am not sure if the difference can be seen in tests with small samples

srimanob · 2022-05-17T18:22:18Z

+Upgrade

This fix follows the validation report of HCAL [*] and it should be the target for the next Phase-2 DD4hep validation. However, it seems unclear to me if the change is expected also for DDD as file Geometry/CMSCommonData/python/cmsExtendedGeometry2026D86XML_cfi.py
also changes. The description of validation campaign should be clear.

[*]
https://cms-pdmv.cern.ch/valdb/?srch=dd4hep&selected=CMSSW_12_4_0_pre3_D88_DD4HEP&Reconstruction=true&RFull=true

cmsbuild · 2022-05-17T18:22:44Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2022-05-18T05:36:33Z

+Upgrade

This fix follows the validation report of HCAL [*] and it should be the target for the next Phase-2 DD4hep validation. However, it seems unclear to me if the change is expected also for DDD as file Geometry/CMSCommonData/python/cmsExtendedGeometry2026D86XML_cfi.py also changes. The description of validation campaign should be clear.

[*] https://cms-pdmv.cern.ch/valdb/?srch=dd4hep&selected=CMSSW_12_4_0_pre3_D88_DD4HEP&Reconstruction=true&RFull=true

@srimanob will you take care of notifying it to @cms-sw/pdmv-l2 , so that it can be correctly taken into account in that validation campaign?

bsunanda · 2022-09-04T04:18:42Z

@srimanob Please uphold this PR. It makes changes in the right direction

srimanob · 2022-09-04T05:35:58Z

unhold

cmsbuild · 2022-09-04T05:36:23Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

srimanob · 2022-09-04T05:37:18Z

@cmsbuild please test workflow 39434.911

srimanob · 2022-09-04T05:44:45Z

Hi @bsunanda

It will be great if you could help to understand more the situation.

Is this PR a bug-fix or to improve?
As mention here, this PR does not fix the issue of bad hcal id in DIGI and RECO step. What is exactly the change that this PR makes.
Should it go to C18, C19, C20 also? Also backport for 12_5 phase-2 production?

Thanks.

bsunanda · 2022-09-04T06:52:50Z

Hi, this is a bug fix and should be included in all Phase 2 scenarios of CMS. Once this is integrated I can update all calorimeter descriptions with this

srimanob · 2022-09-04T06:55:58Z

type bug-fix

cmsbuild · 2022-09-04T18:01:03Z

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-46e449/27312/summary.html
COMMIT: 571f8b0
CMSSW: CMSSW_12_6_X_2022-09-04-0000/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37951/27312/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

138.1138.1_PromptCosmics+RunCosmics2021+RECOCOSDPROMPTRUN3+ALCACOSDPROMPTRUN3+HARVESTDCPROMPTRUN3/step2_PromptCosmics+RunCosmics2021+RECOCOSDPROMPTRUN3+ALCACOSDPROMPTRUN3+HARVESTDCPROMPTRUN3.log
138.2138.2_ExpressCosmics+RunCosmics2021+RECOCOSDEXPRUN3+ALCACOSDEXPRUN3+HARVESTDCEXPRUN3/step2_ExpressCosmics+RunCosmics2021+RECOCOSDEXPRUN3+ALCACOSDEXPRUN3+HARVESTDCEXPRUN3.log

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 5 differences found in the comparisons
DQMHistoTests: Total files compared: 52
DQMHistoTests: Total histograms compared: 3712527
DQMHistoTests: Total failures: 57
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3712448
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 51 files compared)
Checked 216 log files, 49 edm output root files, 52 DQM output files
TriggerResults: no differences found

srimanob · 2022-09-05T02:45:35Z

Failure in INPUT does not relate to this PR.

Would it be better if @bsunanda confirm the issue of bad HCAL ID which still show up in PR test (as mentioned before),
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-46e449/27312/runTheMatrix-results/39434.911_TTbar_14TeV+2026D88_DD4hep+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal/

bsunanda · 2022-09-14T07:46:33Z

@cmsbuild Please test

cmsbuild · 2022-09-14T11:54:29Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-46e449/27517/summary.html
COMMIT: 571f8b0
CMSSW: CMSSW_12_6_X_2022-09-13-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37951/27517/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 51
DQMHistoTests: Total histograms compared: 3618326
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3618302
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
Checked 212 log files, 49 edm output root files, 51 DQM output files
TriggerResults: no differences found

perrotta · 2022-09-14T21:52:13Z

+1

srimanob · 2022-09-20T16:19:44Z

As this PR merged after 12_6_0_pre2, I would like to remind @cms-sw/pdmv-l2 to make a clear validation statement on the change of D88.

REF, see comment
#37951 (comment)

kskovpen · 2022-09-20T16:25:44Z

Thanks @srimanob , we will take a note.

Modify C17 to see the new numbering of HCAL

571f8b0

cmsbuild added this to the CMSSW_12_4_X milestone May 15, 2022

cmsbuild added code-checks-pending geometry-pending orp-pending pending-signatures tests-started upgrade-pending labels May 15, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels May 15, 2022

cmsbuild added tests-approved and removed tests-started labels May 15, 2022

smuzaffar modified the milestones: CMSSW_12_4_X, CMSSW_12_5_X May 16, 2022

cmsbuild added geometry-approved and removed geometry-pending labels May 16, 2022

cmsbuild added fully-signed upgrade-approved and removed pending-signatures upgrade-pending labels May 17, 2022

cmsbuild added fully-signed and removed pending-signatures hold labels Sep 4, 2022

cmsbuild added tests-started and removed tests-approved labels Sep 4, 2022

cmsbuild added the bug-fix label Sep 4, 2022

cmsbuild added tests-rejected and removed tests-started labels Sep 4, 2022

cmsbuild added tests-started and removed tests-rejected labels Sep 14, 2022

cmsbuild added tests-approved and removed tests-started labels Sep 14, 2022

cmsbuild added orp-approved and removed orp-pending labels Sep 14, 2022

cmsbuild merged commit ec65e51 into cms-sw:master Sep 14, 2022

makortel mentioned this pull request Sep 20, 2022

Crashes in workflow 39434.911 #39445

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Phase2-gex134 Modify C17 to see the new numbering of HCAL #37951

Phase2-gex134 Modify C17 to see the new numbering of HCAL #37951

bsunanda commented May 15, 2022

bsunanda commented May 15, 2022

cmsbuild commented May 15, 2022

cmsbuild commented May 15, 2022

cmsbuild commented May 15, 2022

cvuosalo commented May 16, 2022

srimanob commented May 16, 2022 •

edited

bsunanda commented May 17, 2022

srimanob commented May 17, 2022

cmsbuild commented May 17, 2022

perrotta commented May 18, 2022

bsunanda commented Sep 4, 2022

srimanob commented Sep 4, 2022

cmsbuild commented Sep 4, 2022

srimanob commented Sep 4, 2022

srimanob commented Sep 4, 2022

bsunanda commented Sep 4, 2022

srimanob commented Sep 4, 2022

cmsbuild commented Sep 4, 2022

srimanob commented Sep 5, 2022

bsunanda commented Sep 14, 2022

cmsbuild commented Sep 14, 2022

perrotta commented Sep 14, 2022

srimanob commented Sep 20, 2022

kskovpen commented Sep 20, 2022

Phase2-gex134 Modify C17 to see the new numbering of HCAL #37951

Phase2-gex134 Modify C17 to see the new numbering of HCAL #37951

Conversation

bsunanda commented May 15, 2022

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

bsunanda commented May 15, 2022

cmsbuild commented May 15, 2022

cmsbuild commented May 15, 2022

cmsbuild commented May 15, 2022

Comparison Summary

cvuosalo commented May 16, 2022

srimanob commented May 16, 2022 • edited

bsunanda commented May 17, 2022

srimanob commented May 17, 2022

cmsbuild commented May 17, 2022

perrotta commented May 18, 2022

bsunanda commented Sep 4, 2022

srimanob commented Sep 4, 2022

cmsbuild commented Sep 4, 2022

srimanob commented Sep 4, 2022

srimanob commented Sep 4, 2022

bsunanda commented Sep 4, 2022

srimanob commented Sep 4, 2022

cmsbuild commented Sep 4, 2022

RelVals-INPUT

Comparison Summary

srimanob commented Sep 5, 2022

bsunanda commented Sep 14, 2022

cmsbuild commented Sep 14, 2022

Comparison Summary

perrotta commented Sep 14, 2022

srimanob commented Sep 20, 2022

kskovpen commented Sep 20, 2022

srimanob commented May 16, 2022 •

edited