Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add another excluded era for displaced muons #37953

Merged

Conversation

perrotta
Copy link
Contributor

This is an attempt to solve the unit test failure in testTauEmbeddingProducers that showed up after the merging of #37805, as notified in #37805 (comment)

Disclaimer: I am not able to test it now (sunday afternoon, etc.), but to speed up I let bot doing it, something which is not very efficient during working days when I have all computing facilities available, but it could speed up things now that we are otherwise ready to build CMSSW_12_4_0_pre4

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37953/30021

  • This PR adds an extra 16KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @perrotta (Andrea Perrotta) for master.

It involves the following packages:

  • PhysicsTools/PatAlgos (reconstruction)

@jpata, @cmsbuild, @clacaputo, @slava77 can you please review it and eventually sign? Thanks.
@AlexDeMoor, @rappoccio, @gouskos, @jdolen, @JyothsnaKomaragiri, @ahinzmann, @schoef, @emilbols, @jdamgov, @mbluj, @nhanvtran, @gkasieczka, @hatakeyamak, @gpetruc, @azotz, @mariadalfonso, @demuller, @andrzejnovak, @seemasharmafnal, @mmarionncern this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor Author

test parameters:

  • TauAnalysis/MCEmbeddingTools

@perrotta
Copy link
Contributor Author

test parameters:

  • cms-addpkg TauAnalysis/MCEmbeddingTools

@perrotta
Copy link
Contributor Author

test parameters:

  • cms-addpkg = TauAnalysis/MCEmbeddingTools

@perrotta
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dad70d/24727/summary.html
COMMIT: fd4aed0
CMSSW: CMSSW_12_4_X_2022-05-15-0000/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37953/24727/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-dad70d/11634.301_TTbar_14TeV+2021_Run3FS+TTbar_14TeV_TuneCP5_GenSim+HARVESTNano

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3741432
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3741402
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor Author

testTauEmbeddingProducers succeeds now!
@cms-sw/reconstruction-l2 do you see any issue with the proposed solution?

@perrotta
Copy link
Contributor Author

urgent

@perrotta
Copy link
Contributor Author

+1

@perrotta
Copy link
Contributor Author

merge

@cmsbuild cmsbuild merged commit 9c0c506 into cms-sw:master May 15, 2022
@perrotta perrotta deleted the addAnotherExcludedEraForDisplacedMuons branch May 15, 2022 20:56
@jfernan2
Copy link
Contributor

jfernan2 commented Sep 18, 2023

+1
(for the records)

@cmsbuild
Copy link
Contributor

Pull request #37953 was updated. @simonepigazzini, @jfernan2, @mandrenguyen, @vlimant can you please check and sign again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants