Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for Double32_t bug #3796

Merged
merged 1 commit into from May 10, 2014

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented May 9, 2014

This is a workaround for a ROOT bug that causes two relval tests to fail while reading files written with ROOT5.
Fixing the ROOT bug cannot cure the problem, because the ROOT bug is in ROOT5, not ROOT 6, and fixing the bug in ROOT5 would not magically update all files already written with ROOT 5.
The bug is that if a member of a persistent class specified in an xml selection file contains a Double32_t, the Double32_t is properly stored on disk only if there is a iotype selection rule for that field. If not, the item is stored as a double. The bug does not exist in ROOT6. ROOT6 expects a Double32_t, and cannot convert the double to a Double32_t, causing a fatal error. It is not easy to modify ROOT6 to do the conversion.
The easiest fix is to replace Double32_t with double in the code for those cases where there was no iotype selection rule. This does not increase the size on disk, because in these cases, they are already stored as double.
NOTE: At some time in the future, if we can enhance ROOT6 to do the double=>Double32_conversion when reading a file, this workaround could be removed. I do not know if that is feasible or not.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2014

A new Pull Request was created by @wmtan for CMSSW_7_1_ROOT6_X.

Workaround for Double32_t bug

It involves the following packages:

DataFormats/JetReco
DataFormats/ParticleFlowReco
RecoEgamma/EgammaElectronAlgos

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks.
@TaiSakuma, @nhanvtran, @bachtis, @lgray this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

davidlt added a commit that referenced this pull request May 10, 2014
@davidlt davidlt merged commit 733dcc5 into cms-sw:CMSSW_7_1_ROOT6_X May 10, 2014
@wmtan wmtan deleted the WorkaroundForDouble32Bug branch June 3, 2014 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants