move TfGraphDefWrapper and TfGraphDefProducer from RecoTracker/FinalTrackSelectors to PhysicsTools/TensorFlow

[mmusich]

resolves #37958

PR description:

As per #37958 (comment).
Also moved TfGraphRecord from TrackingTools/Records to PhysicsTools/TensorFlow in commit ae0c89c

PR validation:

cmssw compiles

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37968/30049

• This PR adds an extra 40KB to repository

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

• PhysicsTools/TensorFlow (reconstruction)
• RecoHGCal/TICL (upgrade, reconstruction)
• RecoTracker/FinalTrackSelectors (reconstruction)
• RecoTracker/MkFit (reconstruction)

@clacaputo, @cmsbuild, @AdrianoDee, @srimanob, @slava77, @jpata can you please review it and eventually sign? Thanks.
@beaucero, @makortel, @felicepantaleo, @riga, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @apsallid, @sobhatta, @ebrondol, @lecriste, @hatakeyamak, @trtomei, @gpetruc, @mmusich, @mtosi, @dgulhan this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[jpata]

@riga @yongbinfeng can you please review this from the ML side? Potentially some info on the TfGraphDef could be in the ML docs as well.

[jpata]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3d10be/24775/summary.html
COMMIT: 929e238
CMSSW: CMSSW_12_5_X_2022-05-16-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37968/24775/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-3d10be/11634.301_TTbar_14TeV+2021_Run3FS+TTbar_14TeV_TuneCP5_GenSim+HARVESTNano

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3741432
• DQMHistoTests: Total failures: 14
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3741396
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37968/30072

• This PR adds an extra 40KB to repository

[cmsbuild]

Pull request #37968 was updated. @clacaputo, @cmsbuild, @AdrianoDee, @srimanob, @slava77, @jpata can you please check and sign again.

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3d10be/24821/summary.html
COMMIT: ae0c89c
CMSSW: CMSSW_12_5_X_2022-05-17-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37968/24821/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3672375
• DQMHistoTests: Total failures: 13
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3672339
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 49 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[jpata]

+reconstruction

• technical, addresses Find a better home for RecoTracker.FinalTrackSelectors._tfGraphDefProducer #37958 (code cleanup for the future)

[mmusich]

@cms-sw/upgrade-l2 please check and sign.
Thank you

[srimanob]

+Upgrade

This consider to be technical PR follow the suggestion in #37958

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1