Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLT menu development for 12_3_X [12_5_X] #37978

Merged
merged 2 commits into from May 18, 2022

Conversation

missirol
Copy link
Contributor

PR description:

Development of HLT menus for CMSSW_12_3_X.

This is the PR for the master branch, which will then be backported to 12_4_X and 12_3_X (the latter is the release cycle currently used for HLT-menu development for Run 3).

Includes the integration of the following JIRA tickets.

  • CMSHLT-2287: [TSG] New Stream for GPU-vs-CPU comparisons in DQM
  • CMSHLT-2300: [TRK] Update "timeThreshold" parameter value for BeamSpot
  • CMSHLT-2303: [TSG] Redefinition of split PDs for EphemeralPhysics and EphemeralZeroBias
  • CMSHLT-2309: [EXO] Disable HLT_PFMET1XX_PFJet100_looseRecoiling_v triggers

The PR also includes a fix for the customisation function to run the latest HLT GRun menu on Run-2 data.

PR validation:

TSG tests.

If this PR is a backport, please specify the original PR and why you need to backport that PR:

N/A

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37978/30050

  • This PR adds an extra 836KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @missirol (Marino Missiroli) for master.

It involves the following packages:

  • Configuration/HLT (hlt)
  • HLTrigger/Configuration (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @silviodonato, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-62cf1e/24789/summary.html
COMMIT: bf9021e
CMSSW: CMSSW_12_5_X_2022-05-17-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37978/24789/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-62cf1e/11634.301_TTbar_14TeV+2021_Run3FS+TTbar_14TeV_TuneCP5_GenSim+HARVESTNano

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 21 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3672390
  • DQMHistoTests: Total failures: 79
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3672288
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 5.0600000000000005 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 0.844 KiB HLT/Filters
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: found differences in 1 / 49 workflows

@missirol
Copy link
Contributor Author

+hlt

  • differences in the PR-tests outputs are in line with changes to HLT GRun menu

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented May 18, 2022

+1

@cmsbuild cmsbuild merged commit 45098e0 into cms-sw:master May 18, 2022
@missirol missirol deleted the HLTdevelopment123X_for125X branch May 24, 2022 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants