Remove nonfunctional and unmaintained FP420 code

[jpata]

PR description:

FP420 is no longer developed, the code is not maintained, and not runnable.
We got a confirmation neither CTPPS nor Proton want to pick up the maintenance.

Addresses #36612.

PR validation:

Compiles.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37983/30053

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @jpata (Joosep Pata) for master.

It involves the following packages:

• DataFormats/FP420Cluster (reconstruction)
• DataFormats/FP420Digi (simulation)
• RecoRomanPot/RecoFP420 (reconstruction)

@civanch, @clacaputo, @cmsbuild, @mdhildreth, @slava77, @jpata can you please review it and eventually sign? Thanks.
@rovere this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[jpata]

@cmsbuild please test

[cmsbuild]

-1

Failed Tests: Build HeaderConsistency
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-87be4d/24787/summary.html
COMMIT: ca711f1
CMSSW: CMSSW_12_5_X_2022-05-17-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37983/24787/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_5_X_2022-05-17-1100/src/SimRomanPot/SimFP420/src/LandauFP420.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_5_X_2022-05-17-1100/src/SimRomanPot/SimFP420/src/PileUpFP420.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_5_X_2022-05-17-1100/src/SimRomanPot/SimFP420/src/ZeroSuppressFP420.cc
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_5_X_2022-05-17-1100/src/SimRomanPot/SimFP420/interface/FP420DigiMain.h:7,
                 from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_5_X_2022-05-17-1100/src/SimRomanPot/SimFP420/src/FP420DigiMain.cc:9:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_5_X_2022-05-17-1100/poison/DataFormats/FP420Digi/interface/DigiCollectionFP420.h:1:2: error: #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.
    1 | #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.
      |  ^~~~~
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_5_X_2022-05-17-1100/src/SimRomanPot/SimFP420/interface/FP420DigiMain.h:8,
                 from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_5_X_2022-05-17-1100/src/SimRomanPot/SimFP420/src/FP420DigiMain.cc:9:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_5_X_2022-05-17-1100/poison/DataFormats/FP420Digi/interface/HDigiFP420.h:1:2: error: #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.


[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37983/30054

• This PR adds an extra 12KB to repository

[cmsbuild]

Pull request #37983 was updated. @smuzaffar, @civanch, @Dr15Jones, @makortel, @mdhildreth, @cmsbuild, @clacaputo, @slava77, @jpata can you please check and sign again.

[jpata]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-87be4d/24790/summary.html
COMMIT: ee05e5f
CMSSW: CMSSW_12_5_X_2022-05-17-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37983/24790/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-87be4d/11634.301_TTbar_14TeV+2021_Run3FS+TTbar_14TeV_TuneCP5_GenSim+HARVESTNano

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3672456
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3672426
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[jpata]

+reconstruction

• addresses review current use cases of RecoFP420 #36612
• technical, no changes

[civanch]

+1

[jpata]

@cms-sw/core-l2 would you be OK signing this?

[makortel]

+core

Happy to, the need just missed my attention

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1