Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

link lost tracks to taus [12_4_X] #37986

Merged
merged 5 commits into from May 19, 2022

Conversation

mbluj
Copy link
Contributor

@mbluj mbluj commented May 17, 2022

PR description:

This PR is a clone of #37918, i.e. it is created with the same development branch. Full description of the original PR is repeated below for convenience.

This PR adds links between taus and tracks used to build their charged hadron candidates, but not contained by PF-particles. The links are added at both RECO/AOD and MiniAOD levels.

At RECO/AOD level the link is created by a dedicated "modifier" plugin which adds to a tau object edm::Ptrs to members of (general)track collection, while at miniAOD level it is done via modified PATTauSlimmer module which stores in tau object edm::Ptrs to members of lostTracks collection. In both cases already existing data members of respectively reco::BaseTau and pat::Tau objects are reused. Linking at RECO/AOD is needed to produce link at miniAOD.

Expected changes: small number of taus (<1%) will contain up to 2 additional edm::Ptrs. Other tau features will stay unchanged.

PR validation:

Standard tests, i.e. runTheMatrix.py -l limited -i all --ibeos, passed successfully.

Results of other tests like increase of size/CPU/memory usage provided within the original PR.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #37918.

Needed as thanks to it miniAOD user has access to all charged prongs of reconstructed taus.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mbluj for CMSSW_12_4_X.

It involves the following packages:

  • DataFormats/PatCandidates (reconstruction)
  • PhysicsTools/PatAlgos (reconstruction)
  • RecoTauTag/Configuration (reconstruction)
  • RecoTauTag/RecoTau (reconstruction)

@jpata, @cmsbuild, @clacaputo, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @hatakeyamak, @emilbols, @mbluj, @demuller, @seemasharmafnal, @mmarionncern, @missirol, @ahinzmann, @jdolen, @azotz, @rovere, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @mariadalfonso, @AlexDeMoor, @JyothsnaKomaragiri, @gpetruc, @andrzejnovak this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@jpata
Copy link
Contributor

jpata commented May 18, 2022

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b40256/24814/summary.html
COMMIT: 754ab28
CMSSW: CMSSW_12_4_X_2022-05-17-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37986/24814/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-b40256/11634.301_TTbar_14TeV+2021_Run3FS+TTbar_14TeV_TuneCP5_GenSim+HARVESTNano

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 48 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3741432
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3741402
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@jpata
Copy link
Contributor

jpata commented May 18, 2022

+reconstruction

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented May 19, 2022

+1

@cmsbuild cmsbuild merged commit ec0993e into cms-sw:CMSSW_12_4_X May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants