New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
link lost tracks to taus [12_4_X] #37986
link lost tracks to taus [12_4_X] #37986
Conversation
A new Pull Request was created by @mbluj for CMSSW_12_4_X. It involves the following packages:
@jpata, @cmsbuild, @clacaputo, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b40256/24814/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
+reconstruction
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR is a clone of #37918, i.e. it is created with the same development branch. Full description of the original PR is repeated below for convenience.
This PR adds links between taus and tracks used to build their charged hadron candidates, but not contained by PF-particles. The links are added at both RECO/AOD and MiniAOD levels.
At RECO/AOD level the link is created by a dedicated "modifier" plugin which adds to a tau object edm::Ptrs to members of (general)track collection, while at miniAOD level it is done via modified PATTauSlimmer module which stores in tau object edm::Ptrs to members of lostTracks collection. In both cases already existing data members of respectively reco::BaseTau and pat::Tau objects are reused. Linking at RECO/AOD is needed to produce link at miniAOD.
Expected changes: small number of taus (<1%) will contain up to 2 additional edm::Ptrs. Other tau features will stay unchanged.
PR validation:
Standard tests, i.e.
runTheMatrix.py -l limited -i all --ibeos
, passed successfully.Results of other tests like increase of size/CPU/memory usage provided within the original PR.
if this PR is a backport please specify the original PR and why you need to backport that PR:
Backport of #37918.
Needed as thanks to it miniAOD user has access to all charged prongs of reconstructed taus.