Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pixel Heterogeneous DQM: add module rechit @cpu / @gpu comparisons [backport to 12.3.X] #37989

Merged
merged 3 commits into from May 20, 2022
Merged

Pixel Heterogeneous DQM: add module rechit @cpu / @gpu comparisons [backport to 12.3.X] #37989

merged 3 commits into from May 20, 2022

Conversation

sroychow
Copy link
Contributor

PR description:

Backport of #37860

PR validation:

Will need PR #37971 to compile.

@sroychow
resolve conflict and add 1D difference
f07d9aa 
apply code formatting

add 1D differnce and change rechit indput tag

fix a bug
@sroychow
remove redundant 2D maps
8bc03f0
@sroychow
fix histo ranges and binning
5020155
@cmsbuild cmsbuild added this to the CMSSW_12_3_X milestone May 17, 2022
@cmsbuild
Copy link
Contributor

cmsbuild commented May 17, 2022 •
edited

A new Pull Request was created by @sroychow (Suvankar Roy Chowdhury) for CMSSW_12_3_X.

It involves the following packages:

  • DQM/SiPixelPhase1Heterogeneous (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@hdelanno, @fioriNTU, @jandrea, @idebruyn, @mmusich, @threus this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@sroychow
Copy link
Contributor Author

code-checks with #37971

@sroychow
Copy link
Contributor Author

test parameters:

  • enable_tests = gpu
  • workflows_gpu = 11634.503, 11634.506, 11634.583, 11634.587
  • workflow = 11634.501
  • relvals_opt= -w standard,highstats,pileup,generator,extendedgen,production,upgrade,cleanedupgrade,ged

@sroychow
Copy link
Contributor Author

enable gpu

@sroychow
Copy link
Contributor Author

please test with #37971

@sroychow
Copy link
Contributor Author

type trk

@cmsbuild cmsbuild added the trk label May 17, 2022
@sroychow
Copy link
Contributor Author

backport of #37860

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5b23d5/24798/summary.html
COMMIT: 5020155
CMSSW: CMSSW_12_3_X_2022-05-17-1100/slc7_amd64_gcc10
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37989/24798/install.sh to create a dev area with all the needed externals and cmssw changes.

GPU Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-5b23d5/11634.503_TTbar_14TeV+2021_Patatrack_PixelOnlyGPU_Validation+TTbar_14TeV_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-5b23d5/11634.583_TTbar_14TeV+2021_Patatrack_AllGPU_Validation+TTbar_14TeV_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-5b23d5/11634.587_TTbar_14TeV+2021_Patatrack_AllTripletsGPU_Validation+TTbar_14TeV_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 7
  • DQMHistoTests: Total histograms compared: 76180
  • DQMHistoTests: Total failures: 38
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 76142
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1528.4199999999996 KiB( 6 files compared)
  • DQMHistoSizes: changed ( 11634.506 ): -3488.195 KiB SiPixelHeterogeneous/PixelRecHitsSoA
  • DQMHistoSizes: changed ( 11634.503,... ): 8648.654 KiB SiPixelHeterogeneous/PixelRecHitsCompareGPUvsCPU
  • DQMHistoSizes: changed ( 11634.503,... ): -3488.225 KiB SiPixelHeterogeneous/PixelRecHitsSoACPU
  • DQMHistoSizes: changed ( 11634.503,... ): -3488.225 KiB SiPixelHeterogeneous/PixelRecHitsSoAGPU
  • Checked 24 log files, 18 edm output root files, 7 DQM output files
  • TriggerResults: no differences found

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3712956
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3712926
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -3488.195 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 11634.501 ): -3488.195 KiB SiPixelHeterogeneous/PixelRecHitsSoA
  • Checked 208 log files, 48 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild cmsbuild removed the backport label May 20, 2022
@mmusich
Copy link
Contributor

mmusich commented May 20, 2022

urgent

  • should be included in the next 12.3.X release, for HLT monitoring purposes.

@perrotta
Copy link
Contributor

+1

  • Succesfully merged in master since CMSSW_12_5_X_2022-05-20-1100

@cmsbuild cmsbuild merged commit f92ffa9 into cms-sw:CMSSW_12_3_X May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport-ok dqm-approved fully-signed orp-approved requires-external tests-approved trk urgent
Projects
None yet
Milestone
CMSSW_12_3_X
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sroychow @cmsbuild @emanueleusai @mmusich @perrotta