Remove L1Reco from Phase2 workflow

[srimanob]

PR description:

As discussed in #33012, the L1Reco step is obsolete for Phase-2. It is an unclear point if we should rerun L1TrackTrigger,L1 again in RECO or not. This is to be clarified.

PR validation:

None

if this PR is a backport please specify the original PR and why you need to backport that PR:

No need of backport.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38010/30090

• This PR adds an extra 48KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Configuration/PyReleaseValidation/python/relval_steps.py modified in PR(s): Modifications of the Pixel Charge Reweighting for RunDependent MC #37823

[cmsbuild]

A new Pull Request was created by @srimanob (Phat Srimanobhas) for master.

It involves the following packages:

• Configuration/PyReleaseValidation (pdmv, upgrade)

@jordan-martins, @bbilin, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen can you please review it and eventually sign? Thanks.
@makortel, @kpedro88, @fabiocos, @Martin-Grunewald, @missirol, @trtomei, @beaucero, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[srimanob]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-79c5f8/24851/summary.html
COMMIT: 417552a
CMSSW: CMSSW_12_5_X_2022-05-18-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38010/24851/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 50 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3672423
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3672393
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[kskovpen]

+pdmv

[srimanob]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-79c5f8/25046/summary.html
COMMIT: 417552a
CMSSW: CMSSW_12_5_X_2022-05-27-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38010/25046/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 52 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3648315
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3648285
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[srimanob]

+Upgrade

This PR is to remove obsolete L1Reco step from Phase-2 sequences. No change is expected as no one in Phase-2 should use objected produced from L1Reco. Additional L1 steps will be added to RECO sequence if need, in later PR. This is in discussion with L1T.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

@srimanob would this removal affect validation and monitoring of the L1T developments for phase 2 which are currently being integrated in CMSSW?
Attn @cms-sw/l1-l2

[srimanob]

Hi @perrotta
This was confirmed by L1T team in #33012 that L1Reco produced obsolete L1 objects and no meaning in Phase-2 and it can be removed.

[perrotta]

+1

• According to the discussion in the github issue L1Reco step in Phase2 #33012, @cms-sw/l1-l2 agree with removing L1Reco from upgrade workflows, as it is not needed.