Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EGM] Remove unused sub-package RecoEgamma/Examples #38026

Merged
merged 4 commits into from Jun 7, 2022

Conversation

swagata87
Copy link
Contributor

PR description:

Removed unused sub-package RecoEgamma/Examples.
Purely technical PR. No physics change is expected.
Addresses this issue: #36590

PR validation:

CMSSW compiles.
Checked that the following worked successfully:
runTheMatrix.py -l 11834.0

This PR is not a backport.
Backport not needed.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38026/30098

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @swagata87 (Swagata Mukherjee) for master.

It involves the following packages:

  • RecoEgamma/Examples (reconstruction)

@jpata, @cmsbuild, @clacaputo, @slava77 can you please review it and eventually sign? Thanks.
@Sam-Harper, @jainshilpi, @valsdav, @lgray, @sobhatta, @afiqaize, @wrtabb, @varuns23, @ram1123 this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@swagata87
Copy link
Contributor Author

@cmsbuild please test

@swagata87 swagata87 marked this pull request as ready for review May 20, 2022 15:16
@swagata87 swagata87 changed the title [WIP] Remove unused sub-package RecoEgamma/Examples [Do not merge] Remove unused sub-package RecoEgamma/Examples May 20, 2022
@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b2803e/24877/summary.html
COMMIT: 2a5c28e
CMSSW: CMSSW_12_5_X_2022-05-20-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38026/24877/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

----- Begin Fatal Exception 20-May-2022 19:12:33 CEST-----------------------
An exception of category 'PluginLibraryLoadError' occurred while
   [0] Constructing the EventProcessor
   [1] While attempting to load plugin EgammaSuperClusterMerger
Exception Message:
unable to load /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38026/24877/CMSSW_12_5_X_2022-05-20-1100/lib/el8_amd64_gcc10/poisoned/plugin-poisoned-RecoEgammaExamplesPlugins.so because /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38026/24877/CMSSW_12_5_X_2022-05-20-1100/lib/el8_amd64_gcc10/poisoned/plugin-poisoned-RecoEgammaExamplesPlugins.so: cannot open shared object file: No such file or directory
----- End Fatal Exception -------------------------------------------------

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38026/30104

  • This PR adds an extra 12KB to repository

  • Found files with invalid states:

    • RecoEgamma/Examples/plugins/plugins.cc:

@cmsbuild
Copy link
Contributor

Pull request #38026 was updated. @jpata, @cmsbuild, @clacaputo, @slava77 can you please check and sign again.

@jpata
Copy link
Contributor

jpata commented May 25, 2022

Would it make sense to move EgammaSuperClusterMerger from this now-empty Examples package to RecoEgamma/EgammaIsolationAlgos, where it is used?

Then RecoEgamma/Examples could really be deleted.

@jpata
Copy link
Contributor

jpata commented May 30, 2022

type egamma

@swagata87
Copy link
Contributor Author

I will get back to this PR after ~1 week (going on a vacation.. )

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38026/30402

  • This PR adds an extra 12KB to repository

  • Found files with invalid states:

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2022

Pull request #38026 was updated. @jpata, @cmsbuild, @clacaputo, @slava77 can you please check and sign again.

@jpata
Copy link
Contributor

jpata commented Jun 6, 2022

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b2803e/25304/summary.html
COMMIT: 091770e
CMSSW: CMSSW_12_5_X_2022-06-06-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38026/25304/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3651603
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3651573
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@jpata
Copy link
Contributor

jpata commented Jun 7, 2022

+reconstruction

  • technical cleanup of dead code

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jun 7, 2022

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants