New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EGM] Remove unused sub-package RecoEgamma/Examples #38026
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38026/30098
|
A new Pull Request was created by @swagata87 (Swagata Mukherjee) for master. It involves the following packages:
@jpata, @cmsbuild, @clacaputo, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
-1 Failed Tests: RelVals RelVals
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38026/30104 |
Pull request #38026 was updated. @jpata, @cmsbuild, @clacaputo, @slava77 can you please check and sign again. |
Would it make sense to move EgammaSuperClusterMerger from this now-empty Examples package to RecoEgamma/EgammaIsolationAlgos, where it is used? Then RecoEgamma/Examples could really be deleted. |
type egamma |
I will get back to this PR after ~1 week (going on a vacation.. ) |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38026/30402 |
Pull request #38026 was updated. @jpata, @cmsbuild, @clacaputo, @slava77 can you please check and sign again. |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b2803e/25304/summary.html Comparison SummarySummary:
|
+reconstruction
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Removed unused sub-package RecoEgamma/Examples.
Purely technical PR. No physics change is expected.
Addresses this issue: #36590
PR validation:
CMSSW compiles.
Checked that the following worked successfully:
runTheMatrix.py -l 11834.0
This PR is not a backport.
Backport not needed.