[12.4.X] SiStripHitEfficiency PCL Workflow: miscellaneous fixes

[mmusich]

backport of #38075

PR description:

This PR implements few bug-fixes in the SiStripHitEfficiency PCL Workflow as spotted in the Tier-0 replay dmwm/T0#4674 (comment).

• 28b45e3 loosens the cut on the track multiplicity (used to be 100 to limit the size of the internal SiStrip Calibration Trees, but now that the workflow is centrally supported that is not a problem anymore)
• 412f379 adds plots for monitoring the total number of tracks used and its correlation with PU
• 1c9637e and b8e5f2a are the core of the bug-fix and allow several histograms that were previously empty to be filled.
• 615a871 makes the input / output folder in the DQM file configurable
• ed6ba6f reduces the amount of hardcoded constants in the code

PR validation:

I've run the following commands to test the ALCAPROMPT production:

cmsDriver.py testReAlCa -s ALCA:PromptCalibProdSiStripHitEfficiency --conditions 123X_dataRun2_v2 --scenario pp --data --era Run2_2018 --datatier ALCARECO --eventcontent ALCARECO --processName=ReAlCa -n 100000 --dasquery='file dataset=/StreamExpress/Run2018D-SiStripCalMinBias-Express-v1/ALCARECO run=325172' --nThreads=4 --no_exec 

followed by:

cmsDriver.py stepHarvest -s ALCAHARVEST:SiStripHitEff --conditions 123X_dataRun2_v2 --scenario pp --data --era Run2_2018 --filein file:PromptCalibProdSiStripHitEfficiency.root -n -1 --no_exec                        

to test the ALCAHARVESTING step.
I have also run successfully:

• runTheMatrix.py -l 1001.0, 1001.2
• scram b runtests

if this PR is a backport please specify the original PR and why you need to backport that PR:

verbatim backport of #38075

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_12_4_X.

It involves the following packages:

• CalibTracker/SiStripHitEfficiency (alca)
• Calibration/TkAlCaRecoProducers (alca)

@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@echabert, @pieterdavid, @robervalwalsh, @gbenelli, @tocheng, @mmusich, @threus this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

• Backported from SiStripHitEfficiency PCL Workflow: miscellaneous fixes #38075

[mmusich]

type trk

[mmusich]

type bug-fix

[mmusich]

@cmsbuild, please test

[mmusich]

@cms-sw/alca-l2, I have a branch with the same changes for 12.3.X too.
I know it's too late for the first collisions at 900GeV, let me know if you think it's worth opening a PR or not.

[tvami]

Hi Marco, given that we need the GEM change in 12_3_X for early 13.6 TeV collisions, I'd say it makes sense to do the 12_3_X backport.

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-76b24c/24986/summary.html
COMMIT: 218ea5f
CMSSW: CMSSW_12_4_X_2022-05-25-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38079/24986/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

• 25202.225202.2_TTbar_13+TTbar_13INPUT+DIGIUP15APVSimu_PU25+RECOUP15_PU25_HIPM+HARVESTUP15_PU25/step2_TTbar_13+TTbar_13INPUT+DIGIUP15APVSimu_PU25+RECOUP15_PU25_HIPM+HARVESTUP15_PU25.log
• 11024.211024.2_TTbar_13UP18HEfailINPUT+TTbar_13UP18HEfailINPUT+DigiFullHEfail+RecoFullHEfail+HARVESTFullHEfail+NanoFullHEfail/step2_TTbar_13UP18HEfailINPUT+TTbar_13UP18HEfailINPUT+DigiFullHEfail+RecoFullHEfail+HARVESTFullHEfail+NanoFullHEfail.log
• 25202.025202.0_TTbar_13+TTbar_13INPUT+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+NANOUP15_PU25/step2_TTbar_13+TTbar_13INPUT+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+NANOUP15_PU25.log

Expand to see more relval errors ...

• 25202.1

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3672196
• DQMHistoTests: Total failures: 31
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3672142
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -104.806 KiB( 49 files compared)
• DQMHistoSizes: changed ( 1001.0 ): -104.810 KiB AlCaReco/SiStripHitEfficiency
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[cmsbuild]

Pull request #38079 was updated. @cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please check and sign again.

[mmusich]

@cmsbuild, please test

[mmusich]

given that we need the GEM change in 12_3_X for early 13.6 TeV collisions, I'd say it makes sense to do the 12_3_X backport.

here it is: #38095

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-76b24c/25025/summary.html
COMMIT: 52cd76e
CMSSW: CMSSW_12_4_X_2022-05-26-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38079/25025/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

• 250206.17DAS Error
• 250206.18DAS Error
• 250206.181DAS Error

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3672196
• DQMHistoTests: Total failures: 37
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3672136
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -104.81400000000001 KiB( 49 files compared)
• DQMHistoSizes: changed ( 1001.0 ): -104.810 KiB AlCaReco/SiStripHitEfficiency
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[tvami]

@cmsbuild , please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-76b24c/25032/summary.html
COMMIT: 52cd76e
CMSSW: CMSSW_12_4_X_2022-05-26-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38079/25032/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3672196
• DQMHistoTests: Total failures: 32
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3672142
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -104.81 KiB( 49 files compared)
• DQMHistoSizes: changed ( 1001.0 ): -104.810 KiB AlCaReco/SiStripHitEfficiency
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[tvami]

+alca

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1