[DQM] Fixed filling for TDCfatal in DT Online DQM Backport123X

[jfernan2]

PR description:
Fixed a bug which made that Overflows and hit rejections/error were wrongly considered as TDCFatal too

PR validation:
Tested with private Online DQM client and run 351168

Checked that runTheMatrix.py -l limited works too

backport of #38078

[jfernan2]

backport of #38078

[cmsbuild]

A new Pull Request was created by @jfernan2 for CMSSW_12_3_X.

It involves the following packages:

• DQM/DTMonitorModule (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@battibass this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

• Backported from [DQM] Fixed filling for TDCfatal in DT Online DQM #38078

[jfernan2]

please test

[cmsbuild]

-1

Failed Tests: RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ee82e6/24998/summary.html
COMMIT: 7efe66e
CMSSW: CMSSW_12_3_X_2022-05-25-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38083/24998/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

• 25202.0

----- Begin Fatal Exception 25-May-2022 14:59:31 UTC-----------------------
An exception of category 'FileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
   [2] Calling RootInputFileSequence::initTheFile()
   [3] Calling StorageFactory::open()
   [4] Calling XrdFile::open()
Exception Message:
Failed to open the file 'root://cms-xrd-global.cern.ch//store/relval/CMSSW_10_6_0/RelValMinBias_13/GEN-SIM/106X_mcRun2_asymptotic_v3-v1/10000/81EB7C70-3926-5440-8F1A-B6BB738F2616.root'
   Additional Info:
      [a] Calling RootInputFileSequence::initTheFile(): fail to open the file with name root://eoscms.cern.ch//eos/cms/store/user/cmsbuild/store/relval/CMSSW_10_6_0/RelValMinBias_13/GEN-SIM/106X_mcRun2_asymptotic_v3-v1/10000/81EB7C70-3926-5440-8F1A-B6BB738F2616.root
      [b] Input file root://cms-xrd-global.cern.ch//store/relval/CMSSW_10_6_0/RelValMinBias_13/GEN-SIM/106X_mcRun2_asymptotic_v3-v1/10000/81EB7C70-3926-5440-8F1A-B6BB738F2616.root could not be opened.
      [c] XrdCl::File::Open(name='root://cms-xrd-global.cern.ch//store/relval/CMSSW_10_6_0/RelValMinBias_13/GEN-SIM/106X_mcRun2_asymptotic_v3-v1/10000/81EB7C70-3926-5440-8F1A-B6BB738F2616.root', flags=0x10, permissions=0660) => error '[ERROR] Server responded with an error: [3011] No servers are available to read the file.
' (errno=3011, code=400). No additional data servers were found.
      [d] Last URL tried: root://cms-xrd-global.cern.ch:1094//store/relval/CMSSW_10_6_0/RelValMinBias_13/GEN-SIM/106X_mcRun2_asymptotic_v3-v1/10000/81EB7C70-3926-5440-8F1A-B6BB738F2616.root?tried=&xrdcl.requuid=d102e610-9093-4e55-b16a-59928840e87d
      [e] Problematic data server: cms-xrd-global.cern.ch:1094
      [f] Disabled source: cms-xrd-global.cern.ch:1094
----- End Fatal Exception -------------------------------------------------

RelVals-INPUT

• 36.036.0_Wjet_Pt_3000_3500+Wjet_Pt_3000_3500INPUT+DIGI+RECO+HARVEST/step2_Wjet_Pt_3000_3500+Wjet_Pt_3000_3500INPUT+DIGI+RECO+HARVEST.log
• 37.037.0_LM1_sfts+LM1_sftsINPUT+DIGI+RECO+HARVEST/step2_LM1_sfts+LM1_sftsINPUT+DIGI+RECO+HARVEST.log
• 38.038.0_QCD_FlatPt_15_3000HS+QCD_FlatPt_15_3000HSINPUT+DIGI+RECO+HARVEST/step2_QCD_FlatPt_15_3000HS+QCD_FlatPt_15_3000HSINPUT+DIGI+RECO+HARVEST.log

Expand to see more relval errors ...

• 39.0

[emanueleusai]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ee82e6/25004/summary.html
COMMIT: 7efe66e
CMSSW: CMSSW_12_3_X_2022-05-25-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38083/25004/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3627395
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3627365
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 48 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 205 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[emanueleusai]

• contributor tested online client privately

[emanueleusai]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1