Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLT menu development for 12_4_X (1/N) [12_5_X] #38107

Merged
merged 1 commit into from May 28, 2022

Conversation

missirol
Copy link
Contributor

PR description:

Development of HLT menus for CMSSW_12_4_X.

This is the PR for the master branch, which will then be backported to 12_4_X (the latter is the release cycle currently used for HLT-menu development for Run 3).

Includes the integration of the following JIRA tickets.

  • CMSHLT-2275: [TAU] Update of thresholds in TAU triggers for Run 3
  • CMSHLT-2280: [EXO] New triggers for LLP searches (L1SingleJetLLP, soft di-electrons)
  • CMSHLT-2301: [MUO,EXO] Triggers with new displaced-muon reconstruction.
  • CMSHLT-2302: [TSG] Updates to reduce per-event size of Scouting stream
  • CMSHLT-2305: [B2G] Update of DeepJet WP in HT+5Jet+2BTag triggers
  • CMSHLT-2308: [BPH] Update of triggers for Tau->3Mu search (new L1T seed for Run 3)
  • CMSHLT-2319: [TSG] Re-align STORM menus with updates introduced online by FOG (includes CMSHLT-2322)

PR validation:

TSG tests.

If this PR is a backport, please specify the original PR and why you need to backport that PR:

N/A

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38107/30219

  • This PR adds an extra 832KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @missirol (Marino Missiroli) for master.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor Author

enable gpu

@missirol
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d90ea8/25051/summary.html
COMMIT: 0ca9232
CMSSW: CMSSW_12_5_X_2022-05-27-1100/el8_amd64_gcc10
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38107/25051/install.sh to create a dev area with all the needed externals and cmssw changes.

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • Reco comparison had 3 failed jobs
  • DQMHistoTests: Total files compared: 4
  • DQMHistoTests: Total histograms compared: 19864
  • DQMHistoTests: Total failures: 26
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 19838
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
  • Checked 12 log files, 9 edm output root files, 4 DQM output files
  • TriggerResults: found differences in 3 / 3 workflows

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3648315
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3648285
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor Author

+hlt

  • generally no differences in PR-tests outputs, as expected (the HLT menu used in RelVals was recently changed to the "2022 V1.1" frozen HLT menu, which is not modified by this PR)
  • some residual differences in GPU wfs are attributed to non-reproducibility of outputs on GPU

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

  • Updates to the HLT menus

@cmsbuild cmsbuild merged commit 328410a into cms-sw:master May 28, 2022
@missirol missirol deleted the HLTdevelopment124X_for125X branch May 28, 2022 11:04
@missirol missirol changed the title HLT menu development for 12_4_X [12_5_X] HLT menu development for 12_4_X (1/N) [12_5_X] Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants