Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorten folders name for710pre8 #3811

Merged
merged 2 commits into from May 12, 2014

Conversation

HuguesBrun
Copy link
Contributor

This PR will shorten the name of the folders in Muons/RecoMuonsV/MultiTrack and HLT/Muon/MultiTrack to let them be displayed by the DQM Gui

before changes:

before_changes

after changes

after_changes

Send a notification to @abbiendi

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @HuguesBrun (Hugues BRUN) for CMSSW_7_1_X.

Shorten folders name for710pre8

It involves the following packages:

Validation/RecoMuon

@ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@deguio
Copy link
Contributor

deguio commented May 12, 2014

@HuguesBrun
did you add histograms also?
F.

@HuguesBrun
Copy link
Contributor Author

Hello @deguio
The fix I did in the PostProcessor_cff.py had the effect to add 3 1D histograms in the Muons/RecoMuonsV/MultiTrack (you see them in the snapshot). There are no other plots added.

Thank you,
Hugues

@abbiendi
Copy link
Contributor

Hi, this is a very simple change, but it can improve life a lot for people using the DQM GUI, as it is clear from the displays...
(also I would apply it to 62X_SLHC branch for the same reasons)

Giovanni

@deguio
Copy link
Contributor

deguio commented May 12, 2014

+1
as soon as tests confirm

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

@deguio
Copy link
Contributor

deguio commented May 12, 2014

just keep in mind that the RelMon reports will be broken because of this change. make sure that all the validators are informed.
thanks,
F.

@HuguesBrun
Copy link
Contributor Author

Just to be sure that I understand, It will be only for the pre8 validation because the folders will have different names ? So it will be fixed by itself for pre9 validation, right ?

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

ktf added a commit that referenced this pull request May 12, 2014
…pre8

DQM -- Shorten folders name for710pre8
@ktf ktf merged commit 1bf40ef into cms-sw:CMSSW_7_1_X May 12, 2014
@deguio
Copy link
Contributor

deguio commented May 12, 2014

@HuguesBrun
correct.

F.

@cmsbuild
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants