Phase2-hgx314 A step toward the V17 version of HGCal Geometry

[bsunanda]

PR description:

A step toward the V17 version of HGCal Geometry. The tools to get cell u,v from the position or the position from u,v are now part of the main link to SIM/RECO geometry - HGCalDDDConst. These codes take care of all types of cells (full and partial wafers) in the correct way. In earlier implementations of V16/V15/... the extended cells were not fully treated and parts of the cells could not be identified (x,y to u,v were not proper). The current implementation will take care of this - so the results of those versions will be marginally affected.

PR validation:

Tested using a script inside Geometry/HGCalCommonData/test/python

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38118/30231

• This PR adds an extra 72KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38118/30231/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38118/30231/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38118/30232

• This PR adds an extra 72KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

• Geometry/HGCalCommonData (geometry, upgrade)
• SimG4CMS/Calo (simulation)

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks.
@cvuosalo, @rovere, @fabiocos, @trtomei, @thomreis, @felicepantaleo, @simonepigazzini, @beaucero, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-32c3e5/25062/summary.html
COMMIT: 436f271
CMSSW: CMSSW_12_5_X_2022-05-29-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38118/25062/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 18426 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3648315
• DQMHistoTests: Total failures: 228400
• DQMHistoTests: Total nulls: 11
• DQMHistoTests: Total successes: 3419882
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: found differences in 1 / 49 workflows

[civanch]

@bsunanda , previous Phase-2 WFs D49, D60, D77 are also affected, results are different. Is this expected?

[bsunanda]

There was a bug in getting detid from position affecting all extended cells. This is taken care of here. Now the question is should one use the buggy software or ignore the difference

[cmsbuild]

Pull request #38118 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @AdrianoDee, @srimanob can you please check and sign again.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-32c3e5/25143/summary.html
COMMIT: 2c37728
CMSSW: CMSSW_12_5_X_2022-05-31-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38118/25143/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 18430 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3649923
• DQMHistoTests: Total failures: 228405
• DQMHistoTests: Total nulls: 12
• DQMHistoTests: Total successes: 3421484
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 49 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: found differences in 1 / 49 workflows

[cvuosalo]

+1

[civanch]

+1

[srimanob]

Hi @bsunanda
Could you please update the PR description, mentioned about the bug and fix from this PR? Thanks.

[bsunanda]

@cvuosalo @civanch @srimanob Please approve this PR

[bsunanda]

@srimanob Please approve this PR

[bsunanda]

@perrotta @qliphy @srimanob Could you merge this PR urgently

[srimanob]

+Upgrade

This PR can be considered as an improvement on getting the cell position. It affects previous geometries also. This should be monitored when validation comes. FYI @cms-sw/pdmv-l2

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1
a bug is fixed in getting detid from position affecting all extended cells, Phase-2 WFs results get changed.