Implemented new strategy to generate OI seeds for displaced muons (backport)

[alexsr-98]

PR description:

backport of #38076

This PR implements a new iteration to generate OI seeds for displaced muons. To activate this iteration a flag is added in order to be able to turn off this part of the code and don't interfere with the current algorithm. These slides contain information regarding the problem that we observed and this solution. In slide 7, the performance is shown (compare yellow and brown histograms) and more information regarding the rates and timing is in the backup.

PR validation:

PR validated in #38076

if this PR is a backport please specify the original PR and why you need to backport that PR:

backport of #38076
Backport needed for HLT during 2022 pp data-taking.

[cmsbuild]

A new Pull Request was created by @alexsr-98 for CMSSW_12_4_X.

It involves the following packages:

• RecoMuon/TrackerSeedGenerator (reconstruction)

@jpata, @cmsbuild, @clacaputo, @slava77 can you please review it and eventually sign? Thanks.
@HuguesBrun, @abbiendi, @Fedespring, @bellan, @sscruz, @jhgoh, @CeliaFernandez, @trocino, @cericeci, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

• Backported from Implemented new strategy to generate OI seeds for displaced muons #38076

[missirol]

assign hlt

based on #38076 (comment)

[missirol]

backport of #38076

[cmsbuild]

New categories assigned: hlt

@missirol,@Martin-Grunewald you have been requested to review this Pull request/Issue and eventually sign? Thanks

[missirol]

@alexsr-98 , please squash the commits into 1

[cmsbuild]

Pull request #38137 was updated. @Martin-Grunewald, @clacaputo, @cmsbuild, @missirol, @slava77, @jpata can you please check and sign again.

[missirol]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-03ddf4/25102/summary.html
COMMIT: 6a9735d
CMSSW: CMSSW_12_4_X_2022-05-30-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38137/25102/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3668385
• DQMHistoTests: Total failures: 13
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3668349
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 49 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[missirol]

+hlt

[clacaputo]

+reconstruction

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1