Deal with exception in EventProcessor constructor

[Dr15Jones]

PR description:

If an exception happens in the constructor, delete the object in the order done explicitly in the destructor while the Services are active.

PR validation:

Code compiles and all framework unit tests pass.

fixes cms-sw/framework-team#407

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38144/30284

• This PR adds an extra 32KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38144/30284/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38144/30284/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38144/30286

• This PR adds an extra 32KB to repository

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

• FWCore/Framework (core)

@cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please review it and eventually sign? Thanks.
@makortel, @wddgit this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[makortel]

@cmsbuild, please test

[wddgit]

When do we need "CMS_SA_ALLOW" on the try statement? Is it when there is a "catch (...)"? Some places we do this and some places we don't. I had thought it was for the code rule checker, but I am not sure that is correct. One reason I am asking is other code I am working also has "catch(...)". @gartung

[makortel]

Good catch @wddgit, indeed the static analyzer should complain on try with catch (...) without CMS_SA_ALLOW.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38144/30299

• This PR adds an extra 32KB to repository

[cmsbuild]

Pull request #38144 was updated. @cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please check and sign again.

[Dr15Jones]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6e97b6/25128/summary.html
COMMIT: ef4bafc
CMSSW: CMSSW_12_5_X_2022-05-31-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38144/25128/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @fwyzard Set a missing parameter in the dqmSaver in the hltHarvesting test #38132
• @malbouis Add DoubleMuonLowMass PD to autoAlca #38128
• @cms-tsg-storm Move HLT:@relval2021 to GRun until V1.2 is ready #38135

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6e97b6/25128/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6e97b6/25128/git-merge-result

Comparison Summary

Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3648309
• DQMHistoTests: Total failures: 1298
• DQMHistoTests: Total nulls: 37
• DQMHistoTests: Total successes: 3646952
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 833.5120000000001 KiB( 49 files compared)
• DQMHistoSizes: changed ( 11634.0,... ): 132.827 KiB HLT/HLTEgammaValidation
• DQMHistoSizes: changed ( 11634.0,... ): 6.138 KiB HLT/Filters
• DQMHistoSizes: changed ( 11634.0,... ): -0.047 KiB HLT/TAU
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: found differences in 3 / 49 workflows

[makortel]

@cmsbuild, please test

For cleaner comparisons

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6e97b6/25142/summary.html
COMMIT: ef4bafc
CMSSW: CMSSW_12_5_X_2022-05-31-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38144/25142/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3649923
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3649899
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[makortel]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

merge
RelVals-INPUT error not related